diff options
author | Michael Wang <wangyun@linux.vnet.ibm.com> | 2012-10-10 22:43:21 -0400 |
---|---|---|
committer | NeilBrown <neilb@suse.de> | 2012-10-10 22:43:21 -0400 |
commit | fd177481b440c3f7b5ee9b821a76b29fdf2a6712 (patch) | |
tree | ae05afc6aa944768ff0874237af77d4e35b6c61a /drivers/md | |
parent | af7cf25dd15b74a78bff8ed5dc969b20dae9554d (diff) |
raid: replace list_for_each_continue_rcu with new interface
This patch replaces list_for_each_continue_rcu() with
list_for_each_entry_continue_rcu() to save a few lines
of code and allow removing list_for_each_continue_rcu().
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
-rw-r--r-- | drivers/md/bitmap.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c index 94e7f6ba2e11..df73375c160a 100644 --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c | |||
@@ -163,20 +163,17 @@ static struct md_rdev *next_active_rdev(struct md_rdev *rdev, struct mddev *mdde | |||
163 | * As devices are only added or removed when raid_disk is < 0 and | 163 | * As devices are only added or removed when raid_disk is < 0 and |
164 | * nr_pending is 0 and In_sync is clear, the entries we return will | 164 | * nr_pending is 0 and In_sync is clear, the entries we return will |
165 | * still be in the same position on the list when we re-enter | 165 | * still be in the same position on the list when we re-enter |
166 | * list_for_each_continue_rcu. | 166 | * list_for_each_entry_continue_rcu. |
167 | */ | 167 | */ |
168 | struct list_head *pos; | ||
169 | rcu_read_lock(); | 168 | rcu_read_lock(); |
170 | if (rdev == NULL) | 169 | if (rdev == NULL) |
171 | /* start at the beginning */ | 170 | /* start at the beginning */ |
172 | pos = &mddev->disks; | 171 | rdev = list_entry_rcu(&mddev->disks, struct md_rdev, same_set); |
173 | else { | 172 | else { |
174 | /* release the previous rdev and start from there. */ | 173 | /* release the previous rdev and start from there. */ |
175 | rdev_dec_pending(rdev, mddev); | 174 | rdev_dec_pending(rdev, mddev); |
176 | pos = &rdev->same_set; | ||
177 | } | 175 | } |
178 | list_for_each_continue_rcu(pos, &mddev->disks) { | 176 | list_for_each_entry_continue_rcu(rdev, &mddev->disks, same_set) { |
179 | rdev = list_entry(pos, struct md_rdev, same_set); | ||
180 | if (rdev->raid_disk >= 0 && | 177 | if (rdev->raid_disk >= 0 && |
181 | !test_bit(Faulty, &rdev->flags)) { | 178 | !test_bit(Faulty, &rdev->flags)) { |
182 | /* this is a usable devices */ | 179 | /* this is a usable devices */ |