Merge branch 'for-linus' of git://neil.brown.name/md

* 'for-linus' of git://neil.brown.name/md: (24 commits)
  md: clean up do_md_stop
  md: fix another deadlock with removing sysfs attributes.
  md: move revalidate_disk() back outside open_mutex
  md/raid10: fix deadlock with unaligned read during resync
  md/bitmap:  separate out loading a bitmap from initialising the structures.
  md/bitmap: prepare for storing write-intent-bitmap via dm-dirty-log.
  md/bitmap: optimise scanning of empty bitmaps.
  md/bitmap: clean up plugging calls.
  md/bitmap: reduce dependence on sysfs.
  md/bitmap: white space clean up and similar.
  md/raid5: export raid5 unplugging interface.
  md/plug: optionally use plugger to unplug an array during resync/recovery.
  md/raid5: add simple plugging infrastructure.
  md/raid5: export is_congested test
  raid5: Don't set read-ahead when there is no queue
  md: add support for raising dm events.
  md: export various start/stop interfaces
  md: split out md_rdev_init
  md: be more careful setting MD_CHANGE_CLEAN
  md/raid5: ensure we create a unique name for kmem_cache when mddev has no gendisk
  ...

1 files changed, 18 insertions, 0 deletions

diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 62ecb6650fd0..a88aeb5198c7 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -825,11 +825,29 @@ static int make_request(mddev_t *mddev, struct bio * bio)
                  */
                 bp = bio_split(bio,
                                chunk_sects - (bio->bi_sector & (chunk_sects - 1)) );
+
+                /* Each of these 'make_request' calls will call 'wait_barrier'.
+                 * If the first succeeds but the second blocks due to the resync
+                 * thread raising the barrier, we will deadlock because the
+                 * IO to the underlying device will be queued in generic_make_request
+                 * and will never complete, so will never reduce nr_pending.
+                 * So increment nr_waiting here so no new raise_barriers will
+                 * succeed, and so the second wait_barrier cannot block.
+                 */
+                spin_lock_irq(&conf->resync_lock);
+                conf->nr_waiting++;
+                spin_unlock_irq(&conf->resync_lock);
+
                 if (make_request(mddev, &bp->bio1))
                         generic_make_request(&bp->bio1);
                 if (make_request(mddev, &bp->bio2))
                         generic_make_request(&bp->bio2);
 
+                spin_lock_irq(&conf->resync_lock);
+                conf->nr_waiting--;
+                wake_up(&conf->wait_barrier);
+                spin_unlock_irq(&conf->resync_lock);
+
                 bio_pair_release(bp);
                 return 0;
         bad_map: