aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/isdn
diff options
context:
space:
mode:
authorHannes Eder <hannes@hanneseder.net>2009-02-25 08:11:03 -0500
committerDavid S. Miller <davem@davemloft.net>2009-02-27 04:00:42 -0500
commite86a6a1b7849217bb3b1ef725c7fee86ed6dae33 (patch)
tree0b21b43e06baf645990185fa9dbd4bdf944c6416 /drivers/isdn
parentcf80063a7d8b1b477236e5491730c1ff71fc5577 (diff)
drivers/isdn/hisax: fix sparse warning: Should it be static?
Impact: Move declarations to a header file. Fix this sparse warning: drivers/isdn/hisax/callc.c:24:12: warning: symbol 'lli_revision' was not declared. Should it be static? drivers/isdn/hisax/config.c:84:12: warning: symbol 'CardType' was not declared. Should it be static? drivers/isdn/hisax/config.c:362:5: warning: symbol 'nrcards' was not declared. Should it be static? drivers/isdn/hisax/isdnl1.c:21:12: warning: symbol 'l1_revision' was not declared. Should it be static? drivers/isdn/hisax/isdnl2.c:22:12: warning: symbol 'l2_revision' was not declared. Should it be static? drivers/isdn/hisax/isdnl3.c:22:12: warning: symbol 'l3_revision' was not declared. Should it be static? drivers/isdn/hisax/tei.c:23:12: warning: symbol 'tei_revision' was not declared. Should it be static? Signed-off-by: Hannes Eder <hannes@hanneseder.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn')
-rw-r--r--drivers/isdn/hisax/callc.c1
-rw-r--r--drivers/isdn/hisax/config.c6
-rw-r--r--drivers/isdn/hisax/hfcscard.c2
-rw-r--r--drivers/isdn/hisax/hisax.h9
-rw-r--r--drivers/isdn/hisax/isdnl1.c4
-rw-r--r--drivers/isdn/hisax/sedlbauer.c2
-rw-r--r--drivers/isdn/hisax/teles0.c2
-rw-r--r--drivers/isdn/hisax/teles3.c1
8 files changed, 11 insertions, 16 deletions
diff --git a/drivers/isdn/hisax/callc.c b/drivers/isdn/hisax/callc.c
index 7c56c44f0fd1..025a20d487c5 100644
--- a/drivers/isdn/hisax/callc.c
+++ b/drivers/isdn/hisax/callc.c
@@ -24,7 +24,6 @@
24const char *lli_revision = "$Revision: 2.59.2.4 $"; 24const char *lli_revision = "$Revision: 2.59.2.4 $";
25 25
26extern struct IsdnCard cards[]; 26extern struct IsdnCard cards[];
27extern int nrcards;
28 27
29static int init_b_st(struct Channel *chanp, int incoming); 28static int init_b_st(struct Channel *chanp, int incoming);
30static void release_b_st(struct Channel *chanp); 29static void release_b_st(struct Channel *chanp);
diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c
index ded9d0baf607..4fab18d4d02f 100644
--- a/drivers/isdn/hisax/config.c
+++ b/drivers/isdn/hisax/config.c
@@ -361,12 +361,6 @@ module_param_array(io1, int, NULL, 0);
361 361
362int nrcards; 362int nrcards;
363 363
364extern const char *l1_revision;
365extern const char *l2_revision;
366extern const char *l3_revision;
367extern const char *lli_revision;
368extern const char *tei_revision;
369
370char *HiSax_getrev(const char *revision) 364char *HiSax_getrev(const char *revision)
371{ 365{
372 char *rev; 366 char *rev;
diff --git a/drivers/isdn/hisax/hfcscard.c b/drivers/isdn/hisax/hfcscard.c
index cf082665cc8b..20d7688b397b 100644
--- a/drivers/isdn/hisax/hfcscard.c
+++ b/drivers/isdn/hisax/hfcscard.c
@@ -16,8 +16,6 @@
16#include "hfc_2bds0.h" 16#include "hfc_2bds0.h"
17#include "isdnl1.h" 17#include "isdnl1.h"
18 18
19extern const char *CardType[];
20
21static const char *hfcs_revision = "$Revision: 1.10.2.4 $"; 19static const char *hfcs_revision = "$Revision: 1.10.2.4 $";
22 20
23static irqreturn_t 21static irqreturn_t
diff --git a/drivers/isdn/hisax/hisax.h b/drivers/isdn/hisax/hisax.h
index e8d429fda846..f8527046f197 100644
--- a/drivers/isdn/hisax/hisax.h
+++ b/drivers/isdn/hisax/hisax.h
@@ -121,6 +121,15 @@
121 121
122#ifdef __KERNEL__ 122#ifdef __KERNEL__
123 123
124extern const char *CardType[];
125extern int nrcards;
126
127extern const char *l1_revision;
128extern const char *l2_revision;
129extern const char *l3_revision;
130extern const char *lli_revision;
131extern const char *tei_revision;
132
124/* include l3dss1 & ni1 specific process structures, but no other defines */ 133/* include l3dss1 & ni1 specific process structures, but no other defines */
125#ifdef CONFIG_HISAX_EURO 134#ifdef CONFIG_HISAX_EURO
126 #define l3dss1_process 135 #define l3dss1_process
diff --git a/drivers/isdn/hisax/isdnl1.c b/drivers/isdn/hisax/isdnl1.c
index a14204ec88ee..317f16f516f2 100644
--- a/drivers/isdn/hisax/isdnl1.c
+++ b/drivers/isdn/hisax/isdnl1.c
@@ -18,12 +18,12 @@
18 * 18 *
19 */ 19 */
20 20
21const char *l1_revision = "$Revision: 2.46.2.5 $";
22
23#include <linux/init.h> 21#include <linux/init.h>
24#include "hisax.h" 22#include "hisax.h"
25#include "isdnl1.h" 23#include "isdnl1.h"
26 24
25const char *l1_revision = "$Revision: 2.46.2.5 $";
26
27#define TIMER3_VALUE 7000 27#define TIMER3_VALUE 7000
28 28
29static struct Fsm l1fsm_b; 29static struct Fsm l1fsm_b;
diff --git a/drivers/isdn/hisax/sedlbauer.c b/drivers/isdn/hisax/sedlbauer.c
index a10dfa82c734..5569a522e2a1 100644
--- a/drivers/isdn/hisax/sedlbauer.c
+++ b/drivers/isdn/hisax/sedlbauer.c
@@ -48,8 +48,6 @@
48#include <linux/pci.h> 48#include <linux/pci.h>
49#include <linux/isapnp.h> 49#include <linux/isapnp.h>
50 50
51extern const char *CardType[];
52
53static const char *Sedlbauer_revision = "$Revision: 1.34.2.6 $"; 51static const char *Sedlbauer_revision = "$Revision: 1.34.2.6 $";
54 52
55static const char *Sedlbauer_Types[] = 53static const char *Sedlbauer_Types[] =
diff --git a/drivers/isdn/hisax/teles0.c b/drivers/isdn/hisax/teles0.c
index 48581335f43c..3ca0bed1b88c 100644
--- a/drivers/isdn/hisax/teles0.c
+++ b/drivers/isdn/hisax/teles0.c
@@ -21,8 +21,6 @@
21#include "isac.h" 21#include "isac.h"
22#include "hscx.h" 22#include "hscx.h"
23 23
24extern const char *CardType[];
25
26static const char *teles0_revision = "$Revision: 2.15.2.4 $"; 24static const char *teles0_revision = "$Revision: 2.15.2.4 $";
27 25
28#define TELES_IOMEM_SIZE 0x400 26#define TELES_IOMEM_SIZE 0x400
diff --git a/drivers/isdn/hisax/teles3.c b/drivers/isdn/hisax/teles3.c
index 5dc9f1a43629..e9f5bb4cdffa 100644
--- a/drivers/isdn/hisax/teles3.c
+++ b/drivers/isdn/hisax/teles3.c
@@ -20,7 +20,6 @@
20#include "hscx.h" 20#include "hscx.h"
21#include "isdnl1.h" 21#include "isdnl1.h"
22 22
23extern const char *CardType[];
24static const char *teles3_revision = "$Revision: 2.19.2.4 $"; 23static const char *teles3_revision = "$Revision: 2.19.2.4 $";
25 24
26#define byteout(addr,val) outb(val,addr) 25#define byteout(addr,val) outb(val,addr)