diff options
author | Adrian Bunk <bunk@stusta.de> | 2006-03-25 06:08:06 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-25 11:22:59 -0500 |
commit | 1f4d4a80fbcb1e09cfb95660bcd2b677ea6d04c1 (patch) | |
tree | 713ba892d072d36eaf13f28096050fae794a1edb /drivers/isdn | |
parent | daff89f324755f87a060d5125a205c0755811ea9 (diff) |
[PATCH] i4l/isdn_tty.c: fix a check-after-use
Fix a check-after-use spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/isdn')
-rw-r--r-- | drivers/isdn/i4l/isdn_tty.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c index aeaa1db74bd8..3585fb1f3344 100644 --- a/drivers/isdn/i4l/isdn_tty.c +++ b/drivers/isdn/i4l/isdn_tty.c | |||
@@ -2345,12 +2345,15 @@ isdn_tty_at_cout(char *msg, modem_info * info) | |||
2345 | u_long flags; | 2345 | u_long flags; |
2346 | struct sk_buff *skb = NULL; | 2346 | struct sk_buff *skb = NULL; |
2347 | char *sp = NULL; | 2347 | char *sp = NULL; |
2348 | int l = strlen(msg); | 2348 | int l; |
2349 | 2349 | ||
2350 | if (!msg) { | 2350 | if (!msg) { |
2351 | printk(KERN_WARNING "isdn_tty: Null-Message in isdn_tty_at_cout\n"); | 2351 | printk(KERN_WARNING "isdn_tty: Null-Message in isdn_tty_at_cout\n"); |
2352 | return; | 2352 | return; |
2353 | } | 2353 | } |
2354 | |||
2355 | l = strlen(msg); | ||
2356 | |||
2354 | spin_lock_irqsave(&info->readlock, flags); | 2357 | spin_lock_irqsave(&info->readlock, flags); |
2355 | tty = info->tty; | 2358 | tty = info->tty; |
2356 | if ((info->flags & ISDN_ASYNC_CLOSING) || (!tty)) { | 2359 | if ((info->flags & ISDN_ASYNC_CLOSING) || (!tty)) { |