aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/isdn/hisax/isurf.c
diff options
context:
space:
mode:
authorJeff Garzik <jeff@garzik.org>2007-10-31 03:42:07 -0400
committerJeff Garzik <jgarzik@redhat.com>2008-04-20 18:22:31 -0400
commit8349304d12cf1313bdbd6eb2083701d86809be24 (patch)
tree599d43c202cda35b80966d9f364559484ca4145a /drivers/isdn/hisax/isurf.c
parentd38c8475b4f3a684ac673dcedc88ffdb17b74882 (diff)
[ISDN] Hisax: eliminate many unnecessary references to CardType[]
For the vast majority of CardType[card->typ] uses (but not all!), the string is constant for each driver. Therefore, we may replace CardType[card->typ] with the actual string describing the driver, making each printk() a bit more simple. This also has the nice, intended side effect of greatly reducing external references to hisax global CardType[]. This will be of value once the ISDN drivers are converted to the ISA/PCI/PNP hotplug APIs. Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/isdn/hisax/isurf.c')
-rw-r--r--drivers/isdn/hisax/isurf.c13
1 files changed, 4 insertions, 9 deletions
diff --git a/drivers/isdn/hisax/isurf.c b/drivers/isdn/hisax/isurf.c
index 55de06953540..ca4161798cdf 100644
--- a/drivers/isdn/hisax/isurf.c
+++ b/drivers/isdn/hisax/isurf.c
@@ -17,8 +17,6 @@
17#include "isdnl1.h" 17#include "isdnl1.h"
18#include <linux/isapnp.h> 18#include <linux/isapnp.h>
19 19
20extern const char *CardType[];
21
22static const char *ISurf_revision = "$Revision: 1.12.2.4 $"; 20static const char *ISurf_revision = "$Revision: 1.12.2.4 $";
23 21
24#define byteout(addr,val) outb(val,addr) 22#define byteout(addr,val) outb(val,addr)
@@ -251,22 +249,19 @@ setup_isurf(struct IsdnCard *card)
251 return(0); 249 return(0);
252 } 250 }
253#else 251#else
254 printk(KERN_WARNING "HiSax: %s port/mem not set\n", 252 printk(KERN_WARNING "HiSax: Siemens I-Surf port/mem not set\n");
255 CardType[card->typ]);
256 return (0); 253 return (0);
257#endif 254#endif
258 } 255 }
259 if (!request_region(cs->hw.isurf.reset, 1, "isurf isdn")) { 256 if (!request_region(cs->hw.isurf.reset, 1, "isurf isdn")) {
260 printk(KERN_WARNING 257 printk(KERN_WARNING
261 "HiSax: %s config port %x already in use\n", 258 "HiSax: Siemens I-Surf config port %x already in use\n",
262 CardType[card->typ],
263 cs->hw.isurf.reset); 259 cs->hw.isurf.reset);
264 return (0); 260 return (0);
265 } 261 }
266 if (!request_region(cs->hw.isurf.phymem, ISURF_IOMEM_SIZE, "isurf iomem")) { 262 if (!request_region(cs->hw.isurf.phymem, ISURF_IOMEM_SIZE, "isurf iomem")) {
267 printk(KERN_WARNING 263 printk(KERN_WARNING "HiSax: Siemens I-Surf memory region "
268 "HiSax: %s memory region %lx-%lx already in use\n", 264 "%lx-%lx already in use\n",
269 CardType[card->typ],
270 cs->hw.isurf.phymem, 265 cs->hw.isurf.phymem,
271 cs->hw.isurf.phymem + ISURF_IOMEM_SIZE); 266 cs->hw.isurf.phymem + ISURF_IOMEM_SIZE);
272 release_region(cs->hw.isurf.reset, 1); 267 release_region(cs->hw.isurf.reset, 1);