irqchip: mips-gic: Use proper iomem accessors

Get rid of the ugly GICREAD/GICWRITE/GICBIS macros and use proper
iomem accessors instead.  Since the GIC registers are not directly
accessed outside of the GIC driver any more, make gic_base static
and move all the GIC register manipulation macros out of gic.h,
converting them to static inline functions.

Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Paul Burton <paul.burton@imgtec.com>
Cc: Qais Yousef <qais.yousef@imgtec.com>
Cc: John Crispin <blogic@openwrt.org>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/8127/
Patchwork: https://patchwork.linux-mips.org/patch/8229/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

1 files changed, 135 insertions, 71 deletions

diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
index b5fad6377736..88086d7e7c51 100644
--- a/drivers/irqchip/irq-mips-gic.c
+++ b/drivers/irqchip/irq-mips-gic.c
@@ -23,7 +23,6 @@
 
 unsigned int gic_frequency;
 unsigned int gic_present;
-unsigned long _gic_base;
 
 struct gic_pcpu_mask {
         DECLARE_BITMAP(pcpu_mask, GIC_MAX_INTRS);
@@ -37,6 +36,7 @@ struct gic_intrmask_regs {
         DECLARE_BITMAP(intrmask, GIC_MAX_INTRS);
 };
 
+static void __iomem *gic_base;
 static struct gic_pcpu_mask pcpu_masks[NR_CPUS];
 static struct gic_pending_regs pending_regs[NR_CPUS];
 static struct gic_intrmask_regs intrmask_regs[NR_CPUS];
@@ -49,15 +49,82 @@ static struct irq_chip gic_level_irq_controller, gic_edge_irq_controller;
 
 static void __gic_irq_dispatch(void);
 
+static inline unsigned int gic_read(unsigned int reg)
+{
+        return __raw_readl(gic_base + reg);
+}
+
+static inline void gic_write(unsigned int reg, unsigned int val)
+{
+        __raw_writel(val, gic_base + reg);
+}
+
+static inline void gic_update_bits(unsigned int reg, unsigned int mask,
+                                   unsigned int val)
+{
+        unsigned int regval;
+
+        regval = gic_read(reg);
+        regval &= ~mask;
+        regval |= val;
+        gic_write(reg, regval);
+}
+
+static inline void gic_reset_mask(unsigned int intr)
+{
+        gic_write(GIC_REG(SHARED, GIC_SH_RMASK) + GIC_INTR_OFS(intr),
+                  1 << GIC_INTR_BIT(intr));
+}
+
+static inline void gic_set_mask(unsigned int intr)
+{
+        gic_write(GIC_REG(SHARED, GIC_SH_SMASK) + GIC_INTR_OFS(intr),
+                  1 << GIC_INTR_BIT(intr));
+}
+
+static inline void gic_set_polarity(unsigned int intr, unsigned int pol)
+{
+        gic_update_bits(GIC_REG(SHARED, GIC_SH_SET_POLARITY) +
+                        GIC_INTR_OFS(intr), 1 << GIC_INTR_BIT(intr),
+                        pol << GIC_INTR_BIT(intr));
+}
+
+static inline void gic_set_trigger(unsigned int intr, unsigned int trig)
+{
+        gic_update_bits(GIC_REG(SHARED, GIC_SH_SET_TRIGGER) +
+                        GIC_INTR_OFS(intr), 1 << GIC_INTR_BIT(intr),
+                        trig << GIC_INTR_BIT(intr));
+}
+
+static inline void gic_set_dual_edge(unsigned int intr, unsigned int dual)
+{
+        gic_update_bits(GIC_REG(SHARED, GIC_SH_SET_DUAL) + GIC_INTR_OFS(intr),
+                        1 << GIC_INTR_BIT(intr),
+                        dual << GIC_INTR_BIT(intr));
+}
+
+static inline void gic_map_to_pin(unsigned int intr, unsigned int pin)
+{
+        gic_write(GIC_REG(SHARED, GIC_SH_INTR_MAP_TO_PIN_BASE) +
+                  GIC_SH_MAP_TO_PIN(intr), GIC_MAP_TO_PIN_MSK | pin);
+}
+
+static inline void gic_map_to_vpe(unsigned int intr, unsigned int vpe)
+{
+        gic_write(GIC_REG(SHARED, GIC_SH_INTR_MAP_TO_VPE_BASE) +
+                  GIC_SH_MAP_TO_VPE_REG_OFF(intr, vpe),
+                  GIC_SH_MAP_TO_VPE_REG_BIT(vpe));
+}
+
 #if defined(CONFIG_CSRC_GIC) || defined(CONFIG_CEVT_GIC)
 cycle_t gic_read_count(void)
 {
         unsigned int hi, hi2, lo;
 
         do {
-                GICREAD(GIC_REG(SHARED, GIC_SH_COUNTER_63_32), hi);
-                GICREAD(GIC_REG(SHARED, GIC_SH_COUNTER_31_00), lo);
-                GICREAD(GIC_REG(SHARED, GIC_SH_COUNTER_63_32), hi2);
+                hi = gic_read(GIC_REG(SHARED, GIC_SH_COUNTER_63_32));
+                lo = gic_read(GIC_REG(SHARED, GIC_SH_COUNTER_31_00));
+                hi2 = gic_read(GIC_REG(SHARED, GIC_SH_COUNTER_63_32));
         } while (hi2 != hi);
 
         return (((cycle_t) hi) << 32) + lo;
@@ -67,7 +134,7 @@ unsigned int gic_get_count_width(void)
 {
         unsigned int bits, config;
 
-        GICREAD(GIC_REG(SHARED, GIC_SH_CONFIG), config);
+        config = gic_read(GIC_REG(SHARED, GIC_SH_CONFIG));
         bits = 32 + 4 * ((config & GIC_SH_CONFIG_COUNTBITS_MSK) >>
                          GIC_SH_CONFIG_COUNTBITS_SHF);
 
@@ -76,9 +143,9 @@ unsigned int gic_get_count_width(void)
 
 void gic_write_compare(cycle_t cnt)
 {
-        GICWRITE(GIC_REG(VPE_LOCAL, GIC_VPE_COMPARE_HI),
+        gic_write(GIC_REG(VPE_LOCAL, GIC_VPE_COMPARE_HI),
                                 (int)(cnt >> 32));
-        GICWRITE(GIC_REG(VPE_LOCAL, GIC_VPE_COMPARE_LO),
+        gic_write(GIC_REG(VPE_LOCAL, GIC_VPE_COMPARE_LO),
                                 (int)(cnt & 0xffffffff));
 }
 
@@ -88,10 +155,10 @@ void gic_write_cpu_compare(cycle_t cnt, int cpu)
 
         local_irq_save(flags);
 
-        GICWRITE(GIC_REG(VPE_LOCAL, GIC_VPE_OTHER_ADDR), cpu);
-        GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_COMPARE_HI),
+        gic_write(GIC_REG(VPE_LOCAL, GIC_VPE_OTHER_ADDR), cpu);
+        gic_write(GIC_REG(VPE_OTHER, GIC_VPE_COMPARE_HI),
                                 (int)(cnt >> 32));
-        GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_COMPARE_LO),
+        gic_write(GIC_REG(VPE_OTHER, GIC_VPE_COMPARE_LO),
                                 (int)(cnt & 0xffffffff));
 
         local_irq_restore(flags);
@@ -101,8 +168,8 @@ cycle_t gic_read_compare(void)
 {
         unsigned int hi, lo;
 
-        GICREAD(GIC_REG(VPE_LOCAL, GIC_VPE_COMPARE_HI), hi);
-        GICREAD(GIC_REG(VPE_LOCAL, GIC_VPE_COMPARE_LO), lo);
+        hi = gic_read(GIC_REG(VPE_LOCAL, GIC_VPE_COMPARE_HI));
+        lo = gic_read(GIC_REG(VPE_LOCAL, GIC_VPE_COMPARE_LO));
 
         return (((cycle_t) hi) << 32) + lo;
 }
@@ -116,7 +183,7 @@ static bool gic_local_irq_is_routable(int intr)
         if (cpu_has_veic)
                 return true;
 
-        GICREAD(GIC_REG(VPE_LOCAL, GIC_VPE_CTL), vpe_ctl);
+        vpe_ctl = gic_read(GIC_REG(VPE_LOCAL, GIC_VPE_CTL));
         switch (intr) {
         case GIC_LOCAL_INT_TIMER:
                 return vpe_ctl & GIC_VPE_CTL_TIMER_RTBL_MSK;
@@ -136,7 +203,7 @@ unsigned int gic_get_timer_pending(void)
 {
         unsigned int vpe_pending;
 
-        GICREAD(GIC_REG(VPE_LOCAL, GIC_VPE_PEND), vpe_pending);
+        vpe_pending = gic_read(GIC_REG(VPE_LOCAL, GIC_VPE_PEND));
         return vpe_pending & GIC_VPE_PEND_TIMER_MSK;
 }
 
@@ -146,12 +213,13 @@ static void gic_bind_eic_interrupt(int irq, int set)
         irq -= GIC_PIN_TO_VEC_OFFSET;
 
         /* Set irq to use shadow set */
-        GICWRITE(GIC_REG_ADDR(VPE_LOCAL, GIC_VPE_EIC_SS(irq)), set);
+        gic_write(GIC_REG(VPE_LOCAL, GIC_VPE_EIC_SHADOW_SET_BASE) +
+                  GIC_VPE_EIC_SS(irq), set);
 }
 
 void gic_send_ipi(unsigned int intr)
 {
-        GICWRITE(GIC_REG(SHARED, GIC_SH_WEDGE), 0x80000000 | intr);
+        gic_write(GIC_REG(SHARED, GIC_SH_WEDGE), 0x80000000 | intr);
 }
 
 int gic_get_c0_compare_int(void)
@@ -178,23 +246,21 @@ static unsigned int gic_get_int(void)
 {
         unsigned int i;
         unsigned long *pending, *intrmask, *pcpu_mask;
-        unsigned long *pending_abs, *intrmask_abs;
+        unsigned long pending_reg, intrmask_reg;
 
         /* Get per-cpu bitmaps */
         pending = pending_regs[smp_processor_id()].pending;
         intrmask = intrmask_regs[smp_processor_id()].intrmask;
         pcpu_mask = pcpu_masks[smp_processor_id()].pcpu_mask;
 
-        pending_abs = (unsigned long *) GIC_REG_ABS_ADDR(SHARED,
-                                                         GIC_SH_PEND_31_0_OFS);
-        intrmask_abs = (unsigned long *) GIC_REG_ABS_ADDR(SHARED,
-                                                          GIC_SH_MASK_31_0_OFS);
+        pending_reg = GIC_REG(SHARED, GIC_SH_PEND_31_0);
+        intrmask_reg = GIC_REG(SHARED, GIC_SH_MASK_31_0);
 
         for (i = 0; i < BITS_TO_LONGS(gic_shared_intrs); i++) {
-                GICREAD(*pending_abs, pending[i]);
-                GICREAD(*intrmask_abs, intrmask[i]);
-                pending_abs++;
-                intrmask_abs++;
+                pending[i] = gic_read(pending_reg);
+                intrmask[i] = gic_read(intrmask_reg);
+                pending_reg += 0x4;
+                intrmask_reg += 0x4;
         }
 
         bitmap_and(pending, pending, intrmask, gic_shared_intrs);
@@ -205,19 +271,19 @@ static unsigned int gic_get_int(void)
 
 static void gic_mask_irq(struct irq_data *d)
 {
-        GIC_CLR_INTR_MASK(GIC_HWIRQ_TO_SHARED(d->hwirq));
+        gic_reset_mask(GIC_HWIRQ_TO_SHARED(d->hwirq));
 }
 
 static void gic_unmask_irq(struct irq_data *d)
 {
-        GIC_SET_INTR_MASK(GIC_HWIRQ_TO_SHARED(d->hwirq));
+        gic_set_mask(GIC_HWIRQ_TO_SHARED(d->hwirq));
 }
 
 static void gic_ack_irq(struct irq_data *d)
 {
         unsigned int irq = GIC_HWIRQ_TO_SHARED(d->hwirq);
 
-        GICWRITE(GIC_REG(SHARED, GIC_SH_WEDGE), irq);
+        gic_write(GIC_REG(SHARED, GIC_SH_WEDGE), irq);
 }
 
 static int gic_set_type(struct irq_data *d, unsigned int type)
@@ -229,34 +295,34 @@ static int gic_set_type(struct irq_data *d, unsigned int type)
         spin_lock_irqsave(&gic_lock, flags);
         switch (type & IRQ_TYPE_SENSE_MASK) {
         case IRQ_TYPE_EDGE_FALLING:
-                GIC_SET_POLARITY(irq, GIC_POL_NEG);
-                GIC_SET_TRIGGER(irq, GIC_TRIG_EDGE);
-                GIC_SET_DUAL(irq, GIC_TRIG_DUAL_DISABLE);
+                gic_set_polarity(irq, GIC_POL_NEG);
+                gic_set_trigger(irq, GIC_TRIG_EDGE);
+                gic_set_dual_edge(irq, GIC_TRIG_DUAL_DISABLE);
                 is_edge = true;
                 break;
         case IRQ_TYPE_EDGE_RISING:
-                GIC_SET_POLARITY(irq, GIC_POL_POS);
-                GIC_SET_TRIGGER(irq, GIC_TRIG_EDGE);
-                GIC_SET_DUAL(irq, GIC_TRIG_DUAL_DISABLE);
+                gic_set_polarity(irq, GIC_POL_POS);
+                gic_set_trigger(irq, GIC_TRIG_EDGE);
+                gic_set_dual_edge(irq, GIC_TRIG_DUAL_DISABLE);
                 is_edge = true;
                 break;
         case IRQ_TYPE_EDGE_BOTH:
                 /* polarity is irrelevant in this case */
-                GIC_SET_TRIGGER(irq, GIC_TRIG_EDGE);
-                GIC_SET_DUAL(irq, GIC_TRIG_DUAL_ENABLE);
+                gic_set_trigger(irq, GIC_TRIG_EDGE);
+                gic_set_dual_edge(irq, GIC_TRIG_DUAL_ENABLE);
                 is_edge = true;
                 break;
         case IRQ_TYPE_LEVEL_LOW:
-                GIC_SET_POLARITY(irq, GIC_POL_NEG);
-                GIC_SET_TRIGGER(irq, GIC_TRIG_LEVEL);
-                GIC_SET_DUAL(irq, GIC_TRIG_DUAL_DISABLE);
+                gic_set_polarity(irq, GIC_POL_NEG);
+                gic_set_trigger(irq, GIC_TRIG_LEVEL);
+                gic_set_dual_edge(irq, GIC_TRIG_DUAL_DISABLE);
                 is_edge = false;
                 break;
         case IRQ_TYPE_LEVEL_HIGH:
         default:
-                GIC_SET_POLARITY(irq, GIC_POL_POS);
-                GIC_SET_TRIGGER(irq, GIC_TRIG_LEVEL);
-                GIC_SET_DUAL(irq, GIC_TRIG_DUAL_DISABLE);
+                gic_set_polarity(irq, GIC_POL_POS);
+                gic_set_trigger(irq, GIC_TRIG_LEVEL);
+                gic_set_dual_edge(irq, GIC_TRIG_DUAL_DISABLE);
                 is_edge = false;
                 break;
         }
@@ -292,7 +358,7 @@ static int gic_set_affinity(struct irq_data *d, const struct cpumask *cpumask,
         spin_lock_irqsave(&gic_lock, flags);
 
         /* Re-route this IRQ */
-        GIC_SH_MAP_TO_VPE_SMASK(irq, first_cpu(tmp));
+        gic_map_to_vpe(irq, first_cpu(tmp));
 
         /* Update the pcpu_masks */
         for (i = 0; i < NR_CPUS; i++)
@@ -331,8 +397,8 @@ static unsigned int gic_get_local_int(void)
 {
         unsigned long pending, masked;
 
-        GICREAD(GIC_REG(VPE_LOCAL, GIC_VPE_PEND), pending);
-        GICREAD(GIC_REG(VPE_LOCAL, GIC_VPE_MASK), masked);
+        pending = gic_read(GIC_REG(VPE_LOCAL, GIC_VPE_PEND));
+        masked = gic_read(GIC_REG(VPE_LOCAL, GIC_VPE_MASK));
 
         bitmap_and(&pending, &pending, &masked, GIC_NUM_LOCAL_INTRS);
 
@@ -343,14 +409,14 @@ static void gic_mask_local_irq(struct irq_data *d)
 {
         int intr = GIC_HWIRQ_TO_LOCAL(d->hwirq);
 
-        GICWRITE(GIC_REG(VPE_LOCAL, GIC_VPE_RMASK), 1 << intr);
+        gic_write(GIC_REG(VPE_LOCAL, GIC_VPE_RMASK), 1 << intr);
 }
 
 static void gic_unmask_local_irq(struct irq_data *d)
 {
         int intr = GIC_HWIRQ_TO_LOCAL(d->hwirq);
 
-        GICWRITE(GIC_REG(VPE_LOCAL, GIC_VPE_SMASK), 1 << intr);
+        gic_write(GIC_REG(VPE_LOCAL, GIC_VPE_SMASK), 1 << intr);
 }
 
 static struct irq_chip gic_local_irq_controller = {
@@ -367,8 +433,8 @@ static void gic_mask_local_irq_all_vpes(struct irq_data *d)
 
         spin_lock_irqsave(&gic_lock, flags);
         for (i = 0; i < gic_vpes; i++) {
-                GICWRITE(GIC_REG(VPE_LOCAL, GIC_VPE_OTHER_ADDR), i);
-                GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_RMASK), 1 << intr);
+                gic_write(GIC_REG(VPE_LOCAL, GIC_VPE_OTHER_ADDR), i);
+                gic_write(GIC_REG(VPE_OTHER, GIC_VPE_RMASK), 1 << intr);
         }
         spin_unlock_irqrestore(&gic_lock, flags);
 }
@@ -381,8 +447,8 @@ static void gic_unmask_local_irq_all_vpes(struct irq_data *d)
 
         spin_lock_irqsave(&gic_lock, flags);
         for (i = 0; i < gic_vpes; i++) {
-                GICWRITE(GIC_REG(VPE_LOCAL, GIC_VPE_OTHER_ADDR), i);
-                GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_SMASK), 1 << intr);
+                gic_write(GIC_REG(VPE_LOCAL, GIC_VPE_OTHER_ADDR), i);
+                gic_write(GIC_REG(VPE_OTHER, GIC_VPE_SMASK), 1 << intr);
         }
         spin_unlock_irqrestore(&gic_lock, flags);
 }
@@ -462,7 +528,7 @@ static __init void gic_ipi_init_one(unsigned int intr, int cpu,
                                       GIC_SHARED_TO_HWIRQ(intr));
         int i;
 
-        GIC_SH_MAP_TO_VPE_SMASK(intr, cpu);
+        gic_map_to_vpe(intr, cpu);
         for (i = 0; i < NR_CPUS; i++)
                 clear_bit(intr, pcpu_masks[i].pcpu_mask);
         set_bit(intr, pcpu_masks[cpu].pcpu_mask);
@@ -500,19 +566,19 @@ static void __init gic_basic_init(void)
 
         /* Setup defaults */
         for (i = 0; i < gic_shared_intrs; i++) {
-                GIC_SET_POLARITY(i, GIC_POL_POS);
-                GIC_SET_TRIGGER(i, GIC_TRIG_LEVEL);
-                GIC_CLR_INTR_MASK(i);
+                gic_set_polarity(i, GIC_POL_POS);
+                gic_set_trigger(i, GIC_TRIG_LEVEL);
+                gic_reset_mask(i);
         }
 
         for (i = 0; i < gic_vpes; i++) {
                 unsigned int j;
 
-                GICWRITE(GIC_REG(VPE_LOCAL, GIC_VPE_OTHER_ADDR), i);
+                gic_write(GIC_REG(VPE_LOCAL, GIC_VPE_OTHER_ADDR), i);
                 for (j = 0; j < GIC_NUM_LOCAL_INTRS; j++) {
                         if (!gic_local_irq_is_routable(j))
                                 continue;
-                        GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_RMASK), 1 << j);
+                        gic_write(GIC_REG(VPE_OTHER, GIC_VPE_RMASK), 1 << j);
                 }
         }
 }
@@ -548,29 +614,29 @@ static int gic_local_irq_domain_map(struct irq_domain *d, unsigned int virq,
         for (i = 0; i < gic_vpes; i++) {
                 u32 val = GIC_MAP_TO_PIN_MSK | gic_cpu_pin;
 
-                GICWRITE(GIC_REG(VPE_LOCAL, GIC_VPE_OTHER_ADDR), i);
+                gic_write(GIC_REG(VPE_LOCAL, GIC_VPE_OTHER_ADDR), i);
 
                 switch (intr) {
                 case GIC_LOCAL_INT_WD:
-                        GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_WD_MAP), val);
+                        gic_write(GIC_REG(VPE_OTHER, GIC_VPE_WD_MAP), val);
                         break;
                 case GIC_LOCAL_INT_COMPARE:
-                        GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_COMPARE_MAP), val);
+                        gic_write(GIC_REG(VPE_OTHER, GIC_VPE_COMPARE_MAP), val);
                         break;
                 case GIC_LOCAL_INT_TIMER:
-                        GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_TIMER_MAP), val);
+                        gic_write(GIC_REG(VPE_OTHER, GIC_VPE_TIMER_MAP), val);
                         break;
                 case GIC_LOCAL_INT_PERFCTR:
-                        GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_PERFCTR_MAP), val);
+                        gic_write(GIC_REG(VPE_OTHER, GIC_VPE_PERFCTR_MAP), val);
                         break;
                 case GIC_LOCAL_INT_SWINT0:
-                        GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_SWINT0_MAP), val);
+                        gic_write(GIC_REG(VPE_OTHER, GIC_VPE_SWINT0_MAP), val);
                         break;
                 case GIC_LOCAL_INT_SWINT1:
-                        GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_SWINT1_MAP), val);
+                        gic_write(GIC_REG(VPE_OTHER, GIC_VPE_SWINT1_MAP), val);
                         break;
                 case GIC_LOCAL_INT_FDC:
-                        GICWRITE(GIC_REG(VPE_OTHER, GIC_VPE_FDC_MAP), val);
+                        gic_write(GIC_REG(VPE_OTHER, GIC_VPE_FDC_MAP), val);
                         break;
                 default:
                         pr_err("Invalid local IRQ %d\n", intr);
@@ -593,10 +659,9 @@ static int gic_shared_irq_domain_map(struct irq_domain *d, unsigned int virq,
                                  handle_level_irq);
 
         spin_lock_irqsave(&gic_lock, flags);
-        GICWRITE(GIC_REG_ADDR(SHARED, GIC_SH_MAP_TO_PIN(intr)),
-                 GIC_MAP_TO_PIN_MSK | gic_cpu_pin);
+        gic_map_to_pin(intr, gic_cpu_pin);
         /* Map to VPE 0 by default */
-        GIC_SH_MAP_TO_VPE_SMASK(intr, 0);
+        gic_map_to_vpe(intr, 0);
         set_bit(intr, pcpu_masks[0].pcpu_mask);
         spin_unlock_irqrestore(&gic_lock, flags);
 
@@ -622,10 +687,9 @@ void __init gic_init(unsigned long gic_base_addr,
 {
         unsigned int gicconfig;
 
-        _gic_base = (unsigned long) ioremap_nocache(gic_base_addr,
-                                                    gic_addrspace_size);
+        gic_base = ioremap_nocache(gic_base_addr, gic_addrspace_size);
 
-        GICREAD(GIC_REG(SHARED, GIC_SH_CONFIG), gicconfig);
+        gicconfig = gic_read(GIC_REG(SHARED, GIC_SH_CONFIG));
         gic_shared_intrs = (gicconfig & GIC_SH_CONFIG_NUMINTRS_MSK) >>
                    GIC_SH_CONFIG_NUMINTRS_SHF;
         gic_shared_intrs = ((gic_shared_intrs + 1) * 8);