aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/iommu
diff options
context:
space:
mode:
authorNeil Horman <nhorman@tuxdriver.com>2013-09-27 12:53:35 -0400
committerJoerg Roedel <joro@8bytes.org>2013-10-04 10:19:26 -0400
commit05104a4e8713b27291c7bb49c1e7e68b4e243571 (patch)
treedbd54a2c9e1e5aa55f9fc058c383a4c5a3180fa6 /drivers/iommu
parent15c03dd4859ab16f9212238f29dd315654aa94f6 (diff)
iommu: Remove stack trace from broken irq remapping warning
The warning for the irq remapping broken check in intel_irq_remapping.c is pretty pointless. We need the warning, but we know where its comming from, the stack trace will always be the same, and it needlessly triggers things like Abrt. This changes the warning to just print a text warning about BIOS being broken, without the stack trace, then sets the appropriate taint bit. Since we automatically disable irq remapping, theres no need to contiue making Abrt jump at this problem Signed-off-by: Neil Horman <nhorman@tuxdriver.com> CC: Joerg Roedel <joro@8bytes.org> CC: Bjorn Helgaas <bhelgaas@google.com> CC: Andy Lutomirski <luto@amacapital.net> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> CC: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Signed-off-by: Joerg Roedel <joro@8bytes.org>
Diffstat (limited to 'drivers/iommu')
-rw-r--r--drivers/iommu/intel_irq_remapping.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
index f71673dbb23d..b97d70b1abe0 100644
--- a/drivers/iommu/intel_irq_remapping.c
+++ b/drivers/iommu/intel_irq_remapping.c
@@ -525,12 +525,13 @@ static int __init intel_irq_remapping_supported(void)
525 if (disable_irq_remap) 525 if (disable_irq_remap)
526 return 0; 526 return 0;
527 if (irq_remap_broken) { 527 if (irq_remap_broken) {
528 WARN_TAINT(1, TAINT_FIRMWARE_WORKAROUND, 528 printk(KERN_WARNING
529 "This system BIOS has enabled interrupt remapping\n" 529 "This system BIOS has enabled interrupt remapping\n"
530 "on a chipset that contains an erratum making that\n" 530 "on a chipset that contains an erratum making that\n"
531 "feature unstable. To maintain system stability\n" 531 "feature unstable. To maintain system stability\n"
532 "interrupt remapping is being disabled. Please\n" 532 "interrupt remapping is being disabled. Please\n"
533 "contact your BIOS vendor for an update\n"); 533 "contact your BIOS vendor for an update\n");
534 add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
534 disable_irq_remap = 1; 535 disable_irq_remap = 1;
535 return 0; 536 return 0;
536 } 537 }