diff options
author | Suresh Siddha <suresh.b.siddha@intel.com> | 2012-06-14 21:28:49 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2012-06-15 08:17:29 -0400 |
commit | 7eb9ae0799b1e9f0b77733b432bc5f6f055b020b (patch) | |
tree | 368645d861bcffeabf7cc56763c6337d9e4cbd0d /drivers/iommu/intel_irq_remapping.c | |
parent | 879060d5745250c6f38304fd548d42b76f9df093 (diff) |
irq/apic: Use config_enabled(CONFIG_SMP) checks to clean up irq_set_affinity() for UP
Move the ->irq_set_affinity() routines out of the #ifdef CONFIG_SMP
sections and use config_enabled(CONFIG_SMP) checks inside those
routines. Thus making those routines simple null stubs for
!CONFIG_SMP and retaining those routines with no additional
runtime overhead for CONFIG_SMP kernels.
Cleans up the ifdef CONFIG_SMP in and around routines related to
irq_set_affinity in io_apic and irq_remapping subsystems.
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: torvalds@linux-foundation.org
Cc: joerg.roedel@amd.com
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Link: http://lkml.kernel.org/r/1339723729.3475.63.camel@sbsiddha-desk.sc.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/iommu/intel_irq_remapping.c')
-rw-r--r-- | drivers/iommu/intel_irq_remapping.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c index 853902a1b7db..e0b18f3ae9a8 100644 --- a/drivers/iommu/intel_irq_remapping.c +++ b/drivers/iommu/intel_irq_remapping.c | |||
@@ -902,7 +902,6 @@ static int intel_setup_ioapic_entry(int irq, | |||
902 | return 0; | 902 | return 0; |
903 | } | 903 | } |
904 | 904 | ||
905 | #ifdef CONFIG_SMP | ||
906 | /* | 905 | /* |
907 | * Migrate the IO-APIC irq in the presence of intr-remapping. | 906 | * Migrate the IO-APIC irq in the presence of intr-remapping. |
908 | * | 907 | * |
@@ -926,6 +925,9 @@ intel_ioapic_set_affinity(struct irq_data *data, const struct cpumask *mask, | |||
926 | struct irte irte; | 925 | struct irte irte; |
927 | int err; | 926 | int err; |
928 | 927 | ||
928 | if (!config_enabled(CONFIG_SMP)) | ||
929 | return -EINVAL; | ||
930 | |||
929 | if (!cpumask_intersects(mask, cpu_online_mask)) | 931 | if (!cpumask_intersects(mask, cpu_online_mask)) |
930 | return -EINVAL; | 932 | return -EINVAL; |
931 | 933 | ||
@@ -963,7 +965,6 @@ intel_ioapic_set_affinity(struct irq_data *data, const struct cpumask *mask, | |||
963 | cpumask_copy(data->affinity, mask); | 965 | cpumask_copy(data->affinity, mask); |
964 | return 0; | 966 | return 0; |
965 | } | 967 | } |
966 | #endif | ||
967 | 968 | ||
968 | static void intel_compose_msi_msg(struct pci_dev *pdev, | 969 | static void intel_compose_msi_msg(struct pci_dev *pdev, |
969 | unsigned int irq, unsigned int dest, | 970 | unsigned int irq, unsigned int dest, |
@@ -1065,9 +1066,7 @@ struct irq_remap_ops intel_irq_remap_ops = { | |||
1065 | .reenable = reenable_irq_remapping, | 1066 | .reenable = reenable_irq_remapping, |
1066 | .enable_faulting = enable_drhd_fault_handling, | 1067 | .enable_faulting = enable_drhd_fault_handling, |
1067 | .setup_ioapic_entry = intel_setup_ioapic_entry, | 1068 | .setup_ioapic_entry = intel_setup_ioapic_entry, |
1068 | #ifdef CONFIG_SMP | ||
1069 | .set_affinity = intel_ioapic_set_affinity, | 1069 | .set_affinity = intel_ioapic_set_affinity, |
1070 | #endif | ||
1071 | .free_irq = free_irte, | 1070 | .free_irq = free_irte, |
1072 | .compose_msi_msg = intel_compose_msi_msg, | 1071 | .compose_msi_msg = intel_compose_msi_msg, |
1073 | .msi_alloc_irq = intel_msi_alloc_irq, | 1072 | .msi_alloc_irq = intel_msi_alloc_irq, |