diff options
author | Markus Elfring <elfring@users.sourceforge.net> | 2015-02-11 13:10:21 -0500 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2015-02-12 02:07:13 -0500 |
commit | de3748f66f21642543e6f1acb1002937a8d2de2e (patch) | |
tree | e4daa25d38dd2ae03a026df28d8e97a43bd3cbcb /drivers/input | |
parent | 2b2f514705fa00df1bc01d68fe9decbb7d59fcc6 (diff) |
Input: adi - remove an unnecessary check
The input_free_device() function tests whether its argument is NULL and
then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
-rw-r--r-- | drivers/input/joystick/adi.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/input/joystick/adi.c b/drivers/input/joystick/adi.c index b78425765d3e..d09cefa37931 100644 --- a/drivers/input/joystick/adi.c +++ b/drivers/input/joystick/adi.c | |||
@@ -535,8 +535,7 @@ static int adi_connect(struct gameport *gameport, struct gameport_driver *drv) | |||
535 | } | 535 | } |
536 | } | 536 | } |
537 | fail2: for (i = 0; i < 2; i++) | 537 | fail2: for (i = 0; i < 2; i++) |
538 | if (port->adi[i].dev) | 538 | input_free_device(port->adi[i].dev); |
539 | input_free_device(port->adi[i].dev); | ||
540 | gameport_close(gameport); | 539 | gameport_close(gameport); |
541 | fail1: gameport_set_drvdata(gameport, NULL); | 540 | fail1: gameport_set_drvdata(gameport, NULL); |
542 | kfree(port); | 541 | kfree(port); |