diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-14 17:48:31 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-14 17:48:31 -0400 |
| commit | d1794f2c5b5817eb79ccc5e00701ca748d1b073a (patch) | |
| tree | 5a4c98e694e88a8c82f342d0cc9edb2a4cbbef36 /drivers/input | |
| parent | a41eebab7537890409ea9dfe0fcda9b5fbdb090d (diff) | |
| parent | 2fceef397f9880b212a74c418290ce69e7ac00eb (diff) | |
Merge branch 'bkl-removal' of git://git.lwn.net/linux-2.6
* 'bkl-removal' of git://git.lwn.net/linux-2.6: (146 commits)
IB/umad: BKL is not needed for ib_umad_open()
IB/uverbs: BKL is not needed for ib_uverbs_open()
bf561-coreb: BKL unneeded for open()
Call fasync() functions without the BKL
snd/PCM: fasync BKL pushdown
ipmi: fasync BKL pushdown
ecryptfs: fasync BKL pushdown
Bluetooth VHCI: fasync BKL pushdown
tty_io: fasync BKL pushdown
tun: fasync BKL pushdown
i2o: fasync BKL pushdown
mpt: fasync BKL pushdown
Remove BKL from remote_llseek v2
Make FAT users happier by not deadlocking
x86-mce: BKL pushdown
vmwatchdog: BKL pushdown
vmcp: BKL pushdown
via-pmu: BKL pushdown
uml-random: BKL pushdown
uml-mmapper: BKL pushdown
...
Diffstat (limited to 'drivers/input')
| -rw-r--r-- | drivers/input/input.c | 16 | ||||
| -rw-r--r-- | drivers/input/misc/hp_sdc_rtc.c | 2 | ||||
| -rw-r--r-- | drivers/input/misc/uinput.c | 3 | ||||
| -rw-r--r-- | drivers/input/mousedev.c | 12 | ||||
| -rw-r--r-- | drivers/input/serio/serio_raw.c | 6 |
5 files changed, 32 insertions, 7 deletions
diff --git a/drivers/input/input.c b/drivers/input/input.c index 27006fc18305..408df0bd6be5 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c | |||
| @@ -21,6 +21,7 @@ | |||
| 21 | #include <linux/device.h> | 21 | #include <linux/device.h> |
| 22 | #include <linux/mutex.h> | 22 | #include <linux/mutex.h> |
| 23 | #include <linux/rcupdate.h> | 23 | #include <linux/rcupdate.h> |
| 24 | #include <linux/smp_lock.h> | ||
| 24 | 25 | ||
| 25 | MODULE_AUTHOR("Vojtech Pavlik <vojtech@suse.cz>"); | 26 | MODULE_AUTHOR("Vojtech Pavlik <vojtech@suse.cz>"); |
| 26 | MODULE_DESCRIPTION("Input core"); | 27 | MODULE_DESCRIPTION("Input core"); |
| @@ -1588,13 +1589,17 @@ EXPORT_SYMBOL(input_unregister_handle); | |||
| 1588 | 1589 | ||
| 1589 | static int input_open_file(struct inode *inode, struct file *file) | 1590 | static int input_open_file(struct inode *inode, struct file *file) |
| 1590 | { | 1591 | { |
| 1591 | struct input_handler *handler = input_table[iminor(inode) >> 5]; | 1592 | struct input_handler *handler; |
| 1592 | const struct file_operations *old_fops, *new_fops = NULL; | 1593 | const struct file_operations *old_fops, *new_fops = NULL; |
| 1593 | int err; | 1594 | int err; |
| 1594 | 1595 | ||
| 1596 | lock_kernel(); | ||
| 1595 | /* No load-on-demand here? */ | 1597 | /* No load-on-demand here? */ |
| 1596 | if (!handler || !(new_fops = fops_get(handler->fops))) | 1598 | handler = input_table[iminor(inode) >> 5]; |
| 1597 | return -ENODEV; | 1599 | if (!handler || !(new_fops = fops_get(handler->fops))) { |
| 1600 | err = -ENODEV; | ||
| 1601 | goto out; | ||
| 1602 | } | ||
| 1598 | 1603 | ||
| 1599 | /* | 1604 | /* |
| 1600 | * That's _really_ odd. Usually NULL ->open means "nothing special", | 1605 | * That's _really_ odd. Usually NULL ->open means "nothing special", |
| @@ -1602,7 +1607,8 @@ static int input_open_file(struct inode *inode, struct file *file) | |||
| 1602 | */ | 1607 | */ |
| 1603 | if (!new_fops->open) { | 1608 | if (!new_fops->open) { |
| 1604 | fops_put(new_fops); | 1609 | fops_put(new_fops); |
| 1605 | return -ENODEV; | 1610 | err = -ENODEV; |
| 1611 | goto out; | ||
| 1606 | } | 1612 | } |
| 1607 | old_fops = file->f_op; | 1613 | old_fops = file->f_op; |
| 1608 | file->f_op = new_fops; | 1614 | file->f_op = new_fops; |
| @@ -1614,6 +1620,8 @@ static int input_open_file(struct inode *inode, struct file *file) | |||
| 1614 | file->f_op = fops_get(old_fops); | 1620 | file->f_op = fops_get(old_fops); |
| 1615 | } | 1621 | } |
| 1616 | fops_put(old_fops); | 1622 | fops_put(old_fops); |
| 1623 | out: | ||
| 1624 | unlock_kernel(); | ||
| 1617 | return err; | 1625 | return err; |
| 1618 | } | 1626 | } |
| 1619 | 1627 | ||
diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c index 45e5d05b01de..49d8abfe38fe 100644 --- a/drivers/input/misc/hp_sdc_rtc.c +++ b/drivers/input/misc/hp_sdc_rtc.c | |||
| @@ -35,6 +35,7 @@ | |||
| 35 | 35 | ||
| 36 | #include <linux/hp_sdc.h> | 36 | #include <linux/hp_sdc.h> |
| 37 | #include <linux/errno.h> | 37 | #include <linux/errno.h> |
| 38 | #include <linux/smp_lock.h> | ||
| 38 | #include <linux/types.h> | 39 | #include <linux/types.h> |
| 39 | #include <linux/init.h> | 40 | #include <linux/init.h> |
| 40 | #include <linux/module.h> | 41 | #include <linux/module.h> |
| @@ -408,6 +409,7 @@ static unsigned int hp_sdc_rtc_poll(struct file *file, poll_table *wait) | |||
| 408 | 409 | ||
| 409 | static int hp_sdc_rtc_open(struct inode *inode, struct file *file) | 410 | static int hp_sdc_rtc_open(struct inode *inode, struct file *file) |
| 410 | { | 411 | { |
| 412 | cycle_kernel_lock(); | ||
| 411 | return 0; | 413 | return 0; |
| 412 | } | 414 | } |
| 413 | 415 | ||
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c index a56ad4ba8fe2..2bcfa0b35061 100644 --- a/drivers/input/misc/uinput.c +++ b/drivers/input/misc/uinput.c | |||
| @@ -37,6 +37,7 @@ | |||
| 37 | #include <linux/fs.h> | 37 | #include <linux/fs.h> |
| 38 | #include <linux/miscdevice.h> | 38 | #include <linux/miscdevice.h> |
| 39 | #include <linux/uinput.h> | 39 | #include <linux/uinput.h> |
| 40 | #include <linux/smp_lock.h> | ||
| 40 | 41 | ||
| 41 | static int uinput_dev_event(struct input_dev *dev, unsigned int type, unsigned int code, int value) | 42 | static int uinput_dev_event(struct input_dev *dev, unsigned int type, unsigned int code, int value) |
| 42 | { | 43 | { |
| @@ -222,6 +223,7 @@ static int uinput_open(struct inode *inode, struct file *file) | |||
| 222 | if (!newdev) | 223 | if (!newdev) |
| 223 | return -ENOMEM; | 224 | return -ENOMEM; |
| 224 | 225 | ||
| 226 | lock_kernel(); | ||
| 225 | mutex_init(&newdev->mutex); | 227 | mutex_init(&newdev->mutex); |
| 226 | spin_lock_init(&newdev->requests_lock); | 228 | spin_lock_init(&newdev->requests_lock); |
| 227 | init_waitqueue_head(&newdev->requests_waitq); | 229 | init_waitqueue_head(&newdev->requests_waitq); |
| @@ -229,6 +231,7 @@ static int uinput_open(struct inode *inode, struct file *file) | |||
| 229 | newdev->state = UIST_NEW_DEVICE; | 231 | newdev->state = UIST_NEW_DEVICE; |
| 230 | 232 | ||
| 231 | file->private_data = newdev; | 233 | file->private_data = newdev; |
| 234 | unlock_kernel(); | ||
| 232 | 235 | ||
| 233 | return 0; | 236 | return 0; |
| 234 | } | 237 | } |
diff --git a/drivers/input/mousedev.c b/drivers/input/mousedev.c index b989748598ae..8137e50ded87 100644 --- a/drivers/input/mousedev.c +++ b/drivers/input/mousedev.c | |||
| @@ -14,6 +14,7 @@ | |||
| 14 | #define MOUSEDEV_MIX 31 | 14 | #define MOUSEDEV_MIX 31 |
| 15 | 15 | ||
| 16 | #include <linux/slab.h> | 16 | #include <linux/slab.h> |
| 17 | #include <linux/smp_lock.h> | ||
| 17 | #include <linux/poll.h> | 18 | #include <linux/poll.h> |
| 18 | #include <linux/module.h> | 19 | #include <linux/module.h> |
| 19 | #include <linux/init.h> | 20 | #include <linux/init.h> |
| @@ -545,16 +546,21 @@ static int mousedev_open(struct inode *inode, struct file *file) | |||
| 545 | if (i >= MOUSEDEV_MINORS) | 546 | if (i >= MOUSEDEV_MINORS) |
| 546 | return -ENODEV; | 547 | return -ENODEV; |
| 547 | 548 | ||
| 549 | lock_kernel(); | ||
| 548 | error = mutex_lock_interruptible(&mousedev_table_mutex); | 550 | error = mutex_lock_interruptible(&mousedev_table_mutex); |
| 549 | if (error) | 551 | if (error) { |
| 552 | unlock_kernel(); | ||
| 550 | return error; | 553 | return error; |
| 554 | } | ||
| 551 | mousedev = mousedev_table[i]; | 555 | mousedev = mousedev_table[i]; |
| 552 | if (mousedev) | 556 | if (mousedev) |
| 553 | get_device(&mousedev->dev); | 557 | get_device(&mousedev->dev); |
| 554 | mutex_unlock(&mousedev_table_mutex); | 558 | mutex_unlock(&mousedev_table_mutex); |
| 555 | 559 | ||
| 556 | if (!mousedev) | 560 | if (!mousedev) { |
| 561 | unlock_kernel(); | ||
| 557 | return -ENODEV; | 562 | return -ENODEV; |
| 563 | } | ||
| 558 | 564 | ||
| 559 | client = kzalloc(sizeof(struct mousedev_client), GFP_KERNEL); | 565 | client = kzalloc(sizeof(struct mousedev_client), GFP_KERNEL); |
| 560 | if (!client) { | 566 | if (!client) { |
| @@ -573,6 +579,7 @@ static int mousedev_open(struct inode *inode, struct file *file) | |||
| 573 | goto err_free_client; | 579 | goto err_free_client; |
| 574 | 580 | ||
| 575 | file->private_data = client; | 581 | file->private_data = client; |
| 582 | unlock_kernel(); | ||
| 576 | return 0; | 583 | return 0; |
| 577 | 584 | ||
| 578 | err_free_client: | 585 | err_free_client: |
| @@ -580,6 +587,7 @@ static int mousedev_open(struct inode *inode, struct file *file) | |||
| 580 | kfree(client); | 587 | kfree(client); |
| 581 | err_put_mousedev: | 588 | err_put_mousedev: |
| 582 | put_device(&mousedev->dev); | 589 | put_device(&mousedev->dev); |
| 590 | unlock_kernel(); | ||
| 583 | return error; | 591 | return error; |
| 584 | } | 592 | } |
| 585 | 593 | ||
diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c index 0403622ae267..c9397c8ee97e 100644 --- a/drivers/input/serio/serio_raw.c +++ b/drivers/input/serio/serio_raw.c | |||
| @@ -10,6 +10,7 @@ | |||
| 10 | */ | 10 | */ |
| 11 | 11 | ||
| 12 | #include <linux/slab.h> | 12 | #include <linux/slab.h> |
| 13 | #include <linux/smp_lock.h> | ||
| 13 | #include <linux/poll.h> | 14 | #include <linux/poll.h> |
| 14 | #include <linux/module.h> | 15 | #include <linux/module.h> |
| 15 | #include <linux/serio.h> | 16 | #include <linux/serio.h> |
| @@ -81,9 +82,10 @@ static int serio_raw_open(struct inode *inode, struct file *file) | |||
| 81 | struct serio_raw_list *list; | 82 | struct serio_raw_list *list; |
| 82 | int retval = 0; | 83 | int retval = 0; |
| 83 | 84 | ||
| 85 | lock_kernel(); | ||
| 84 | retval = mutex_lock_interruptible(&serio_raw_mutex); | 86 | retval = mutex_lock_interruptible(&serio_raw_mutex); |
| 85 | if (retval) | 87 | if (retval) |
| 86 | return retval; | 88 | goto out_bkl; |
| 87 | 89 | ||
| 88 | if (!(serio_raw = serio_raw_locate(iminor(inode)))) { | 90 | if (!(serio_raw = serio_raw_locate(iminor(inode)))) { |
| 89 | retval = -ENODEV; | 91 | retval = -ENODEV; |
| @@ -108,6 +110,8 @@ static int serio_raw_open(struct inode *inode, struct file *file) | |||
| 108 | 110 | ||
| 109 | out: | 111 | out: |
| 110 | mutex_unlock(&serio_raw_mutex); | 112 | mutex_unlock(&serio_raw_mutex); |
| 113 | out_bkl: | ||
| 114 | unlock_kernel(); | ||
| 111 | return retval; | 115 | return retval; |
| 112 | } | 116 | } |
| 113 | 117 | ||
