Merge branch 'next' into for-linus

7 files changed, 143 insertions, 81 deletions

diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index ce6f48c695f5..b9b7fc6ff1eb 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -24,6 +24,7 @@
 #include <linux/input.h>
 #include <linux/interrupt.h>
 #include <linux/slab.h>
+#include <linux/gpio.h>
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>
 #include <asm/irq.h>
@@ -68,6 +69,17 @@ struct ts_event {
         int     ignore;
 };
 
+/*
+ * We allocate this separately to avoid cache line sharing issues when
+ * driver is used with DMA-based SPI controllers (like atmel_spi) on
+ * systems where main memory is not DMA-coherent (most non-x86 boards).
+ */
+struct ads7846_packet {
+        u8                      read_x, read_y, read_z1, read_z2, pwrdown;
+        u16                     dummy;          /* for the pwrdown read */
+        struct ts_event         tc;
+};
+
 struct ads7846 {
         struct input_dev        *input;
         char                    phys[32];
@@ -85,9 +97,7 @@ struct ads7846 {
         u16                     x_plate_ohms;
         u16                     pressure_max;
 
-        u8                      read_x, read_y, read_z1, read_z2, pwrdown;
-        u16                     dummy;          /* for the pwrdown read */
-        struct ts_event         tc;
+        struct ads7846_packet   *packet;
 
         struct spi_transfer     xfer[18];
         struct spi_message      msg[5];
@@ -116,6 +126,7 @@ struct ads7846 {
         void                    *filter_data;
         void                    (*filter_cleanup)(void *data);
         int                     (*get_pendown_state)(void);
+        int                     gpio_pendown;
 };
 
 /* leave chip selected when we're done, for quicker re-select? */
@@ -461,10 +472,11 @@ static ssize_t ads7846_disable_store(struct device *dev,
                                      const char *buf, size_t count)
 {
         struct ads7846 *ts = dev_get_drvdata(dev);
-        char *endp;
-        int i;
+        long i;
+
+        if (strict_strtoul(buf, 10, &i))
+                return -EINVAL;
 
-        i = simple_strtoul(buf, &endp, 10);
         spin_lock_irq(&ts->lock);
 
         if (i)
@@ -491,6 +503,14 @@ static struct attribute_group ads784x_attr_group = {
 
 /*--------------------------------------------------------------------------*/
 
+static int get_pendown_state(struct ads7846 *ts)
+{
+        if (ts->get_pendown_state)
+                return ts->get_pendown_state();
+
+        return !gpio_get_value(ts->gpio_pendown);
+}
+
 /*
  * PENIRQ only kicks the timer.  The timer only reissues the SPI transfer,
  * to retrieve touchscreen status.
@@ -502,16 +522,17 @@ static struct attribute_group ads784x_attr_group = {
 static void ads7846_rx(void *ads)
 {
         struct ads7846          *ts = ads;
+        struct ads7846_packet   *packet = ts->packet;
         unsigned                Rt;
         u16                     x, y, z1, z2;
 
         /* ads7846_rx_val() did in-place conversion (including byteswap) from
          * on-the-wire format as part of debouncing to get stable readings.
          */
-        x = ts->tc.x;
-        y = ts->tc.y;
-        z1 = ts->tc.z1;
-        z2 = ts->tc.z2;
+        x = packet->tc.x;
+        y = packet->tc.y;
+        z1 = packet->tc.z1;
+        z2 = packet->tc.z2;
 
         /* range filtering */
         if (x == MAX_12BIT)
@@ -535,10 +556,10 @@ static void ads7846_rx(void *ads)
          * the maximum. Don't report it to user space, repeat at least
          * once more the measurement
          */
-        if (ts->tc.ignore || Rt > ts->pressure_max) {
+        if (packet->tc.ignore || Rt > ts->pressure_max) {
 #ifdef VERBOSE
                 pr_debug("%s: ignored %d pressure %d\n",
-                        ts->spi->dev.bus_id, ts->tc.ignore, Rt);
+                        ts->spi->dev.bus_id, packet->tc.ignore, Rt);
 #endif
                 hrtimer_start(&ts->timer, ktime_set(0, TS_POLL_PERIOD),
                               HRTIMER_MODE_REL);
@@ -550,7 +571,7 @@ static void ads7846_rx(void *ads)
          */
         if (ts->penirq_recheck_delay_usecs) {
                 udelay(ts->penirq_recheck_delay_usecs);
-                if (!ts->get_pendown_state())
+                if (!get_pendown_state(ts))
                         Rt = 0;
         }
 
@@ -631,6 +652,7 @@ static int ads7846_no_filter(void *ads, int data_idx, int *val)
 static void ads7846_rx_val(void *ads)
 {
         struct ads7846 *ts = ads;
+        struct ads7846_packet *packet = ts->packet;
         struct spi_message *m;
         struct spi_transfer *t;
         int val;
@@ -650,7 +672,7 @@ static void ads7846_rx_val(void *ads)
         case ADS7846_FILTER_REPEAT:
                 break;
         case ADS7846_FILTER_IGNORE:
-                ts->tc.ignore = 1;
+                packet->tc.ignore = 1;
                 /* Last message will contain ads7846_rx() as the
                  * completion function.
                  */
@@ -658,7 +680,7 @@ static void ads7846_rx_val(void *ads)
                 break;
         case ADS7846_FILTER_OK:
                 *(u16 *)t->rx_buf = val;
-                ts->tc.ignore = 0;
+