diff options
author | Jeff Garzik <jeff@garzik.org> | 2006-03-29 19:58:22 -0500 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2006-03-29 19:58:22 -0500 |
commit | 79072f38909e3d9883317238887460c39ddcc4cb (patch) | |
tree | 28369f5a844535ff836565eefd62695b0e890fa3 /drivers/input/serio | |
parent | 200d5a7684cc49ef4be40e832daf3f217e70dfbb (diff) | |
parent | 55d8ca4f8094246da6e71889a4e04bfafaa78b10 (diff) |
Merge branch 'upstream'
Diffstat (limited to 'drivers/input/serio')
-rw-r--r-- | drivers/input/serio/hil_mlc.c | 2 | ||||
-rw-r--r-- | drivers/input/serio/hp_sdc_mlc.c | 7 |
2 files changed, 5 insertions, 4 deletions
diff --git a/drivers/input/serio/hil_mlc.c b/drivers/input/serio/hil_mlc.c index 5704204964a3..ea499783fb12 100644 --- a/drivers/input/serio/hil_mlc.c +++ b/drivers/input/serio/hil_mlc.c | |||
@@ -556,7 +556,7 @@ static inline void hilse_setup_input(hil_mlc *mlc, struct hilse_node *node) { | |||
556 | do_gettimeofday(&(mlc->instart)); | 556 | do_gettimeofday(&(mlc->instart)); |
557 | mlc->icount = 15; | 557 | mlc->icount = 15; |
558 | memset(mlc->ipacket, 0, 16 * sizeof(hil_packet)); | 558 | memset(mlc->ipacket, 0, 16 * sizeof(hil_packet)); |
559 | if (down_trylock(&(mlc->isem))) BUG(); | 559 | BUG_ON(down_trylock(&(mlc->isem))); |
560 | 560 | ||
561 | return; | 561 | return; |
562 | } | 562 | } |
diff --git a/drivers/input/serio/hp_sdc_mlc.c b/drivers/input/serio/hp_sdc_mlc.c index 1c9426fd5205..aa4a8a4ccfdb 100644 --- a/drivers/input/serio/hp_sdc_mlc.c +++ b/drivers/input/serio/hp_sdc_mlc.c | |||
@@ -270,9 +270,10 @@ static void hp_sdc_mlc_out (hil_mlc *mlc) { | |||
270 | 270 | ||
271 | do_control: | 271 | do_control: |
272 | priv->emtestmode = mlc->opacket & HIL_CTRL_TEST; | 272 | priv->emtestmode = mlc->opacket & HIL_CTRL_TEST; |
273 | if ((mlc->opacket & (HIL_CTRL_APE | HIL_CTRL_IPF)) == HIL_CTRL_APE) { | 273 | |
274 | BUG(); /* we cannot emulate this, it should not be used. */ | 274 | /* we cannot emulate this, it should not be used. */ |
275 | } | 275 | BUG_ON((mlc->opacket & (HIL_CTRL_APE | HIL_CTRL_IPF)) == HIL_CTRL_APE); |
276 | |||
276 | if ((mlc->opacket & HIL_CTRL_ONLY) == HIL_CTRL_ONLY) goto control_only; | 277 | if ((mlc->opacket & HIL_CTRL_ONLY) == HIL_CTRL_ONLY) goto control_only; |
277 | if (mlc->opacket & HIL_CTRL_APE) { | 278 | if (mlc->opacket & HIL_CTRL_APE) { |
278 | BUG(); /* Should not send command/data after engaging APE */ | 279 | BUG(); /* Should not send command/data after engaging APE */ |