diff options
| author | Daniel Mack <daniel@caiaq.de> | 2010-04-12 07:17:25 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-20 16:21:38 -0400 |
| commit | 997ea58eb92f9970b8af7aae48800d0ef43b9423 (patch) | |
| tree | 65e021973e5a48ad7290d5be1f441940566468ad /drivers/input/mouse | |
| parent | 48679c6d772b1459a2945729e3a1256ac78fcabf (diff) | |
USB: rename usb_buffer_alloc() and usb_buffer_free() users
For more clearance what the functions actually do,
usb_buffer_alloc() is renamed to usb_alloc_coherent()
usb_buffer_free() is renamed to usb_free_coherent()
They should only be used in code which really needs DMA coherency.
All call sites have been changed accordingly, except for staging
drivers.
Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Pedro Ribeiro <pedrib@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/input/mouse')
| -rw-r--r-- | drivers/input/mouse/appletouch.c | 12 | ||||
| -rw-r--r-- | drivers/input/mouse/bcm5974.c | 24 |
2 files changed, 18 insertions, 18 deletions
diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c index 53ec7ddd1826..05edd75abca0 100644 --- a/drivers/input/mouse/appletouch.c +++ b/drivers/input/mouse/appletouch.c | |||
| @@ -806,8 +806,8 @@ static int atp_probe(struct usb_interface *iface, | |||
| 806 | if (!dev->urb) | 806 | if (!dev->urb) |
| 807 | goto err_free_devs; | 807 | goto err_free_devs; |
| 808 | 808 | ||
| 809 | dev->data = usb_buffer_alloc(dev->udev, dev->info->datalen, GFP_KERNEL, | 809 | dev->data = usb_alloc_coherent(dev->udev, dev->info->datalen, GFP_KERNEL, |
| 810 | &dev->urb->transfer_dma); | 810 | &dev->urb->transfer_dma); |
| 811 | if (!dev->data) | 811 | if (!dev->data) |
| 812 | goto err_free_urb; | 812 | goto err_free_urb; |
| 813 | 813 | ||
| @@ -862,8 +862,8 @@ static int atp_probe(struct usb_interface *iface, | |||
| 862 | return 0; | 862 | return 0; |
| 863 | 863 | ||
| 864 | err_free_buffer: | 864 | err_free_buffer: |
| 865 | usb_buffer_free(dev->udev, dev->info->datalen, | 865 | usb_free_coherent(dev->udev, dev->info->datalen, |
| 866 | dev->data, dev->urb->transfer_dma); | 866 | dev->data, dev->urb->transfer_dma); |
| 867 | err_free_urb: | 867 | err_free_urb: |
| 868 | usb_free_urb(dev->urb); | 868 | usb_free_urb(dev->urb); |
| 869 | err_free_devs: | 869 | err_free_devs: |
| @@ -881,8 +881,8 @@ static void atp_disconnect(struct usb_interface *iface) | |||
| 881 | if (dev) { | 881 | if (dev) { |
| 882 | usb_kill_urb(dev->urb); | 882 | usb_kill_urb(dev->urb); |
| 883 | input_unregister_device(dev->input); | 883 | input_unregister_device(dev->input); |
| 884 | usb_buffer_free(dev->udev, dev->info->datalen, | 884 | usb_free_coherent(dev->udev, dev->info->datalen, |
| 885 | dev->data, dev->urb->transfer_dma); | 885 | dev->data, dev->urb->transfer_dma); |
| 886 | usb_free_urb(dev->urb); | 886 | usb_free_urb(dev->urb); |
| 887 | kfree(dev); | 887 | kfree(dev); |
| 888 | } | 888 | } |
diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c index b89879bd860f..6dedded27222 100644 --- a/drivers/input/mouse/bcm5974.c +++ b/drivers/input/mouse/bcm5974.c | |||
| @@ -715,15 +715,15 @@ static int bcm5974_probe(struct usb_interface *iface, | |||
| 715 | if (!dev->tp_urb) | 715 | if (!dev->tp_urb) |
| 716 | goto err_free_bt_urb; | 716 | goto err_free_bt_urb; |
| 717 | 717 | ||
| 718 | dev->bt_data = usb_buffer_alloc(dev->udev, | 718 | dev->bt_data = usb_alloc_coherent(dev->udev, |
| 719 | dev->cfg.bt_datalen, GFP_KERNEL, | 719 | dev->cfg.bt_datalen, GFP_KERNEL, |
| 720 | &dev->bt_urb->transfer_dma); | 720 | &dev->bt_urb->transfer_dma); |
| 721 | if (!dev->bt_data) | 721 | if (!dev->bt_data) |
| 722 | goto err_free_urb; | 722 | goto err_free_urb; |
| 723 | 723 | ||
| 724 | dev->tp_data = usb_buffer_alloc(dev->udev, | 724 | dev->tp_data = usb_alloc_coherent(dev->udev, |
| 725 | dev->cfg.tp_datalen, GFP_KERNEL, | 725 | dev->cfg.tp_datalen, GFP_KERNEL, |
| 726 | &dev->tp_urb->transfer_dma); | 726 | &dev->tp_urb->transfer_dma); |
| 727 | if (!dev->tp_data) | 727 | if (!dev->tp_data) |
| 728 | goto err_free_bt_buffer; | 728 | goto err_free_bt_buffer; |
| 729 | 729 | ||
| @@ -765,10 +765,10 @@ static int bcm5974_probe(struct usb_interface *iface, | |||
| 765 | return 0; | 765 | return 0; |
| 766 | 766 | ||
| 767 | err_free_buffer: | 767 | err_free_buffer: |
| 768 | usb_buffer_free(dev->udev, dev->cfg.tp_datalen, | 768 | usb_free_coherent(dev->udev, dev->cfg.tp_datalen, |
| 769 | dev->tp_data, dev->tp_urb->transfer_dma); | 769 | dev->tp_data, dev->tp_urb->transfer_dma); |
| 770 | err_free_bt_buffer: | 770 | err_free_bt_buffer: |
| 771 | usb_buffer_free(dev->udev, dev->cfg.bt_datalen, | 771 | usb_free_coherent(dev->udev, dev->cfg.bt_datalen, |
| 772 | dev->bt_data, dev->bt_urb->transfer_dma); | 772 | dev->bt_data, dev->bt_urb->transfer_dma); |
| 773 | err_free_urb: | 773 | err_free_urb: |
| 774 | usb_free_urb(dev->tp_urb); | 774 | usb_free_urb(dev->tp_urb); |
| @@ -788,10 +788,10 @@ static void bcm5974_disconnect(struct usb_interface *iface) | |||
| 788 | usb_set_intfdata(iface, NULL); | 788 | usb_set_intfdata(iface, NULL); |
| 789 | 789 | ||
| 790 | input_unregister_device(dev->input); | 790 | input_unregister_device(dev->input); |
| 791 | usb_buffer_free(dev->udev, dev->cfg.tp_datalen, | 791 | usb_free_coherent(dev->udev, dev->cfg.tp_datalen, |
| 792 | dev->tp_data, dev->tp_urb->transfer_dma); | 792 | dev->tp_data, dev->tp_urb->transfer_dma); |
| 793 | usb_buffer_free(dev->udev, dev->cfg.bt_datalen, | 793 | usb_free_coherent(dev->udev, dev->cfg.bt_datalen, |
| 794 | dev->bt_data, dev->bt_urb->transfer_dma); | 794 | dev->bt_data, dev->bt_urb->transfer_dma); |
| 795 | usb_free_urb(dev->tp_urb); | 795 | usb_free_urb(dev->tp_urb); |
| 796 | usb_free_urb(dev->bt_urb); | 796 | usb_free_urb(dev->bt_urb); |
| 797 | kfree(dev); | 797 | kfree(dev); |
