diff options
author | Paul E. McKenney <paul.mckenney@linaro.org> | 2012-08-17 07:43:11 -0400 |
---|---|---|
committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2012-08-20 11:11:04 -0400 |
commit | bff4a394795add6b919debc009f72b7607f5d4bf (patch) | |
tree | 360835587cec7602990bcb735905db14fd9d02e7 /drivers/infiniband | |
parent | c0e12e51b0522f7f5f09ea90273dbb724afb054d (diff) |
infiniband: ehca: Fix compiler warnings
Fix comp_task() to return void to match smp_hotplug_thread's thread_fn
member, and adjust indirection on the ->cpu_comp_threads per-CPU
member of the ehca_comp_pool structure.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Diffstat (limited to 'drivers/infiniband')
-rw-r--r-- | drivers/infiniband/hw/ehca/ehca_irq.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c index 83a00955146b..8615d7cf7e01 100644 --- a/drivers/infiniband/hw/ehca/ehca_irq.c +++ b/drivers/infiniband/hw/ehca/ehca_irq.c | |||
@@ -707,7 +707,7 @@ static void queue_comp_task(struct ehca_cq *__cq) | |||
707 | BUG_ON(!cpu_online(cpu_id)); | 707 | BUG_ON(!cpu_online(cpu_id)); |
708 | 708 | ||
709 | cct = per_cpu_ptr(pool->cpu_comp_tasks, cpu_id); | 709 | cct = per_cpu_ptr(pool->cpu_comp_tasks, cpu_id); |
710 | thread = per_cpu_ptr(pool->cpu_comp_threads, cpu_id); | 710 | thread = *per_cpu_ptr(pool->cpu_comp_threads, cpu_id); |
711 | BUG_ON(!cct || !thread); | 711 | BUG_ON(!cct || !thread); |
712 | 712 | ||
713 | spin_lock_irqsave(&cct->task_lock, flags); | 713 | spin_lock_irqsave(&cct->task_lock, flags); |
@@ -716,7 +716,7 @@ static void queue_comp_task(struct ehca_cq *__cq) | |||
716 | if (cq_jobs > 0) { | 716 | if (cq_jobs > 0) { |
717 | cpu_id = find_next_online_cpu(pool); | 717 | cpu_id = find_next_online_cpu(pool); |
718 | cct = per_cpu_ptr(pool->cpu_comp_tasks, cpu_id); | 718 | cct = per_cpu_ptr(pool->cpu_comp_tasks, cpu_id); |
719 | thread = per_cpu_ptr(pool->cpu_comp_threads, cpu_id); | 719 | thread = *per_cpu_ptr(pool->cpu_comp_threads, cpu_id); |
720 | BUG_ON(!cct || !thread); | 720 | BUG_ON(!cct || !thread); |
721 | } | 721 | } |
722 | __queue_comp_task(__cq, cct, thread); | 722 | __queue_comp_task(__cq, cct, thread); |
@@ -761,7 +761,7 @@ static void comp_task_park(unsigned int cpu) | |||
761 | 761 | ||
762 | cpu = find_next_online_cpu(pool); | 762 | cpu = find_next_online_cpu(pool); |
763 | target = per_cpu_ptr(pool->cpu_comp_tasks, cpu); | 763 | target = per_cpu_ptr(pool->cpu_comp_tasks, cpu); |
764 | thread = per_cpu_ptr(pool->cpu_comp_threads, cpu); | 764 | thread = *per_cpu_ptr(pool->cpu_comp_threads, cpu); |
765 | spin_lock_irq(&target->task_lock); | 765 | spin_lock_irq(&target->task_lock); |
766 | list_for_each_entry_safe(cq, tmp, &list, entry) { | 766 | list_for_each_entry_safe(cq, tmp, &list, entry) { |
767 | list_del(&cq->entry); | 767 | list_del(&cq->entry); |
@@ -788,7 +788,7 @@ static int comp_task_should_run(unsigned int cpu) | |||
788 | return cct->cq_jobs; | 788 | return cct->cq_jobs; |
789 | } | 789 | } |
790 | 790 | ||
791 | static int comp_task(unsigned int cpu) | 791 | static void comp_task(unsigned int cpu) |
792 | { | 792 | { |
793 | struct ehca_cpu_comp_task *cct = this_cpu_ptr(pool->cpu_comp_tasks); | 793 | struct ehca_cpu_comp_task *cct = this_cpu_ptr(pool->cpu_comp_tasks); |
794 | int cql_empty; | 794 | int cql_empty; |