ethtool: fix drvinfo strings set in drivers

Use strlcpy where possible to ensure the string is \0 terminated.
Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
and custom defines.
Use snprintf instead of sprint.
Remove unnecessary inits of ->fw_version
Remove unnecessary inits of drvinfo struct.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 7 insertions, 5 deletions

diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c
index 9542e1644a5c..177cf7664726 100644
--- a/drivers/infiniband/hw/nes/nes_nic.c
+++ b/drivers/infiniband/hw/nes/nes_nic.c
@@ -1317,11 +1317,13 @@ static void nes_netdev_get_drvinfo(struct net_device *netdev,
         struct nes_vnic *nesvnic = netdev_priv(netdev);
         struct nes_adapter *nesadapter = nesvnic->nesdev->nesadapter;
 
-        strcpy(drvinfo->driver, DRV_NAME);
-        strcpy(drvinfo->bus_info, pci_name(nesvnic->nesdev->pcidev));
-        sprintf(drvinfo->fw_version, "%u.%u", nesadapter->firmware_version>>16,
-                                nesadapter->firmware_version & 0x000000ff);
-        strcpy(drvinfo->version, DRV_VERSION);
+        strlcpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
+        strlcpy(drvinfo->bus_info, pci_name(nesvnic->nesdev->pcidev),
+                sizeof(drvinfo->bus_info));
+        snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
+                 "%u.%u", nesadapter->firmware_version >> 16,
+                 nesadapter->firmware_version & 0x000000ff);
+        strlcpy(drvinfo->version, DRV_VERSION, sizeof(drvinfo->version));
         drvinfo->testinfo_len = 0;
         drvinfo->eedump_len = 0;
         drvinfo->regdump_len = 0;