IB: Coverity fixes to sysfs.c

Fix two bugs found by coverity:
 - Memory leak in error path of alloc_group_attrs()
 - Fencepost error in state_show(): the test should be < ARRAY_SIZE(),
   not <= ARRAY_SIZE().

Signed-off-by: Roland Dreier <rolandd@cisco.com>

1 files changed, 4 insertions, 2 deletions

diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
index 49601bb8475b..15121cb5a1f6 100644
--- a/drivers/infiniband/core/sysfs.c
+++ b/drivers/infiniband/core/sysfs.c
@@ -112,7 +112,7 @@ static ssize_t state_show(struct ib_port *p, struct port_attribute *unused,
                 return ret;
 
         return sprintf(buf, "%d: %s\n", attr.state,
-                       attr.state >= 0 && attr.state <= ARRAY_SIZE(state_name) ?
+                       attr.state >= 0 && attr.state < ARRAY_SIZE(state_name) ?
                        state_name[attr.state] : "UNKNOWN");
 }
 
@@ -472,8 +472,10 @@ alloc_group_attrs(ssize_t (*show)(struct ib_port *,
                         goto err;
 
                 if (snprintf(element->name, sizeof(element->name),
-                             "%d", i) >= sizeof(element->name))
+                             "%d", i) >= sizeof(element->name)) {
+                        kfree(element);
                         goto err;
+                }
 
                 element->attr.attr.name  = element->name;
                 element->attr.attr.mode  = S_IRUGO;