diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:37 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-03-27 07:46:37 -0400 |
commit | 22aa4b32a19b1f231d4ce7e9af6354b577a22a35 (patch) | |
tree | 3e773e7102e4ea6bb6b4c00edce442c4e8f37edb /drivers/ide/at91_ide.c | |
parent | e6830a86c260d73c6f370aa7ed17ee6c71e5ee05 (diff) |
ide: remove ide_task_t typedef
While at it:
- rename struct ide_task_s to struct ide_cmd
- remove stale comments from idedisk_{read_native,set}_max_address()
- drop unused 'cmd' argument from ide_{cmd,task}_ioctl()
- drop unused 'task' argument from tx4939ide_tf_load_fixup()
- rename ide_complete_task() to ide_complete_cmd()
- use consistent naming for struct ide_cmd variables
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/at91_ide.c')
-rw-r--r-- | drivers/ide/at91_ide.c | 62 |
1 files changed, 31 insertions, 31 deletions
diff --git a/drivers/ide/at91_ide.c b/drivers/ide/at91_ide.c index 6eabf9e31290..6be7d87382ab 100644 --- a/drivers/ide/at91_ide.c +++ b/drivers/ide/at91_ide.c | |||
@@ -185,55 +185,55 @@ static void ide_mm_outb(u8 value, unsigned long port) | |||
185 | writeb(value, (void __iomem *) port); | 185 | writeb(value, (void __iomem *) port); |
186 | } | 186 | } |
187 | 187 | ||
188 | static void at91_ide_tf_load(ide_drive_t *drive, ide_task_t *task) | 188 | static void at91_ide_tf_load(ide_drive_t *drive, struct ide_cmd *cmd) |
189 | { | 189 | { |
190 | ide_hwif_t *hwif = drive->hwif; | 190 | ide_hwif_t *hwif = drive->hwif; |
191 | struct ide_io_ports *io_ports = &hwif->io_ports; | 191 | struct ide_io_ports *io_ports = &hwif->io_ports; |
192 | struct ide_taskfile *tf = &task->tf; | 192 | struct ide_taskfile *tf = &cmd->tf; |
193 | u8 HIHI = (task->tf_flags & IDE_TFLAG_LBA48) ? 0xE0 : 0xEF; | 193 | u8 HIHI = (cmd->tf_flags & IDE_TFLAG_LBA48) ? 0xE0 : 0xEF; |
194 | 194 | ||
195 | if (task->tf_flags & IDE_FTFLAG_FLAGGED) | 195 | if (cmd->tf_flags & IDE_FTFLAG_FLAGGED) |
196 | HIHI = 0xFF; | 196 | HIHI = 0xFF; |
197 | 197 | ||
198 | if (task->tf_flags & IDE_FTFLAG_OUT_DATA) { | 198 | if (cmd->tf_flags & IDE_FTFLAG_OUT_DATA) { |
199 | u16 data = (tf->hob_data << 8) | tf->data; | 199 | u16 data = (tf->hob_data << 8) | tf->data; |
200 | 200 | ||
201 | at91_ide_output_data(drive, NULL, &data, 2); | 201 | at91_ide_output_data(drive, NULL, &data, 2); |
202 | } | 202 | } |
203 | 203 | ||
204 | if (task->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE) | 204 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_FEATURE) |
205 | ide_mm_outb(tf->hob_feature, io_ports->feature_addr); | 205 | ide_mm_outb(tf->hob_feature, io_ports->feature_addr); |
206 | if (task->tf_flags & IDE_TFLAG_OUT_HOB_NSECT) | 206 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_NSECT) |
207 | ide_mm_outb(tf->hob_nsect, io_ports->nsect_addr); | 207 | ide_mm_outb(tf->hob_nsect, io_ports->nsect_addr); |
208 | if (task->tf_flags & IDE_TFLAG_OUT_HOB_LBAL) | 208 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAL) |
209 | ide_mm_outb(tf->hob_lbal, io_ports->lbal_addr); | 209 | ide_mm_outb(tf->hob_lbal, io_ports->lbal_addr); |
210 | if (task->tf_flags & IDE_TFLAG_OUT_HOB_LBAM) | 210 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAM) |
211 | ide_mm_outb(tf->hob_lbam, io_ports->lbam_addr); | 211 | ide_mm_outb(tf->hob_lbam, io_ports->lbam_addr); |
212 | if (task->tf_flags & IDE_TFLAG_OUT_HOB_LBAH) | 212 | if (cmd->tf_flags & IDE_TFLAG_OUT_HOB_LBAH) |
213 | ide_mm_outb(tf->hob_lbah, io_ports->lbah_addr); | 213 | ide_mm_outb(tf->hob_lbah, io_ports->lbah_addr); |
214 | 214 | ||
215 | if (task->tf_flags & IDE_TFLAG_OUT_FEATURE) | 215 | if (cmd->tf_flags & IDE_TFLAG_OUT_FEATURE) |
216 | ide_mm_outb(tf->feature, io_ports->feature_addr); | 216 | ide_mm_outb(tf->feature, io_ports->feature_addr); |
217 | if (task->tf_flags & IDE_TFLAG_OUT_NSECT) | 217 | if (cmd->tf_flags & IDE_TFLAG_OUT_NSECT) |
218 | ide_mm_outb(tf->nsect, io_ports->nsect_addr); | 218 | ide_mm_outb(tf->nsect, io_ports->nsect_addr); |
219 | if (task->tf_flags & IDE_TFLAG_OUT_LBAL) | 219 | if (cmd->tf_flags & IDE_TFLAG_OUT_LBAL) |
220 | ide_mm_outb(tf->lbal, io_ports->lbal_addr); | 220 | ide_mm_outb(tf->lbal, io_ports->lbal_addr); |
221 | if (task->tf_flags & IDE_TFLAG_OUT_LBAM) | 221 | if (cmd->tf_flags & IDE_TFLAG_OUT_LBAM) |
222 | ide_mm_outb(tf->lbam, io_ports->lbam_addr); | 222 | ide_mm_outb(tf->lbam, io_ports->lbam_addr); |
223 | if (task->tf_flags & IDE_TFLAG_OUT_LBAH) | 223 | if (cmd->tf_flags & IDE_TFLAG_OUT_LBAH) |
224 | ide_mm_outb(tf->lbah, io_ports->lbah_addr); | 224 | ide_mm_outb(tf->lbah, io_ports->lbah_addr); |
225 | 225 | ||
226 | if (task->tf_flags & IDE_TFLAG_OUT_DEVICE) | 226 | if (cmd->tf_flags & IDE_TFLAG_OUT_DEVICE) |
227 | ide_mm_outb((tf->device & HIHI) | drive->select, io_ports->device_addr); | 227 | ide_mm_outb((tf->device & HIHI) | drive->select, io_ports->device_addr); |
228 | } | 228 | } |
229 | 229 | ||
230 | static void at91_ide_tf_read(ide_drive_t *drive, ide_task_t *task) | 230 | static void at91_ide_tf_read(ide_drive_t *drive, struct ide_cmd *cmd) |
231 | { | 231 | { |
232 | ide_hwif_t *hwif = drive->hwif; | 232 | ide_hwif_t *hwif = drive->hwif; |
233 | struct ide_io_ports *io_ports = &hwif->io_ports; | 233 | struct ide_io_ports *io_ports = &hwif->io_ports; |
234 | struct ide_taskfile *tf = &task->tf; | 234 | struct ide_taskfile *tf = &cmd->tf; |
235 | 235 | ||
236 | if (task->tf_flags & IDE_FTFLAG_IN_DATA) { | 236 | if (cmd->tf_flags & IDE_FTFLAG_IN_DATA) { |
237 | u16 data; | 237 | u16 data; |
238 | 238 | ||
239 | at91_ide_input_data(drive, NULL, &data, 2); | 239 | at91_ide_input_data(drive, NULL, &data, 2); |
@@ -244,31 +244,31 @@ static void at91_ide_tf_read(ide_drive_t *drive, ide_task_t *task) | |||
244 | /* be sure we're looking at the low order bits */ | 244 | /* be sure we're looking at the low order bits */ |
245 | ide_mm_outb(ATA_DEVCTL_OBS & ~0x80, io_ports->ctl_addr); | 245 | ide_mm_outb(ATA_DEVCTL_OBS & ~0x80, io_ports->ctl_addr); |
246 | 246 | ||
247 | if (task->tf_flags & IDE_TFLAG_IN_FEATURE) | 247 | if (cmd->tf_flags & IDE_TFLAG_IN_FEATURE) |
248 | tf->feature = ide_mm_inb(io_ports->feature_addr); | 248 | tf->feature = ide_mm_inb(io_ports->feature_addr); |
249 | if (task->tf_flags & IDE_TFLAG_IN_NSECT) | 249 | if (cmd->tf_flags & IDE_TFLAG_IN_NSECT) |
250 | tf->nsect = ide_mm_inb(io_ports->nsect_addr); | 250 | tf->nsect = ide_mm_inb(io_ports->nsect_addr); |
251 | if (task->tf_flags & IDE_TFLAG_IN_LBAL) | 251 | if (cmd->tf_flags & IDE_TFLAG_IN_LBAL) |
252 | tf->lbal = ide_mm_inb(io_ports->lbal_addr); | 252 | tf->lbal = ide_mm_inb(io_ports->lbal_addr); |
253 | if (task->tf_flags & IDE_TFLAG_IN_LBAM) | 253 | if (cmd->tf_flags & IDE_TFLAG_IN_LBAM) |
254 | tf->lbam = ide_mm_inb(io_ports->lbam_addr); | 254 | tf->lbam = ide_mm_inb(io_ports->lbam_addr); |
255 | if (task->tf_flags & IDE_TFLAG_IN_LBAH) | 255 | if (cmd->tf_flags & IDE_TFLAG_IN_LBAH) |
256 | tf->lbah = ide_mm_inb(io_ports->lbah_addr); | 256 | tf->lbah = ide_mm_inb(io_ports->lbah_addr); |
257 | if (task->tf_flags & IDE_TFLAG_IN_DEVICE) | 257 | if (cmd->tf_flags & IDE_TFLAG_IN_DEVICE) |
258 | tf->device = ide_mm_inb(io_ports->device_addr); | 258 | tf->device = ide_mm_inb(io_ports->device_addr); |
259 | 259 | ||
260 | if (task->tf_flags & IDE_TFLAG_LBA48) { | 260 | if (cmd->tf_flags & IDE_TFLAG_LBA48) { |
261 | ide_mm_outb(ATA_DEVCTL_OBS | 0x80, io_ports->ctl_addr); | 261 | ide_mm_outb(ATA_DEVCTL_OBS | 0x80, io_ports->ctl_addr); |
262 | 262 | ||
263 | if (task->tf_flags & IDE_TFLAG_IN_HOB_FEATURE) | 263 | if (cmd->tf_flags & IDE_TFLAG_IN_HOB_FEATURE) |
264 | tf->hob_feature = ide_mm_inb(io_ports->feature_addr); | 264 | tf->hob_feature = ide_mm_inb(io_ports->feature_addr); |
265 | if (task->tf_flags & IDE_TFLAG_IN_HOB_NSECT) | 265 | if (cmd->tf_flags & IDE_TFLAG_IN_HOB_NSECT) |
266 | tf->hob_nsect = ide_mm_inb(io_ports->nsect_addr); | 266 | tf->hob_nsect = ide_mm_inb(io_ports->nsect_addr); |
267 | if (task->tf_flags & IDE_TFLAG_IN_HOB_LBAL) | 267 | if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAL) |
268 | tf->hob_lbal = ide_mm_inb(io_ports->lbal_addr); | 268 | tf->hob_lbal = ide_mm_inb(io_ports->lbal_addr); |
269 | if (task->tf_flags & IDE_TFLAG_IN_HOB_LBAM) | 269 | if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAM) |
270 | tf->hob_lbam = ide_mm_inb(io_ports->lbam_addr); | 270 | tf->hob_lbam = ide_mm_inb(io_ports->lbam_addr); |
271 | if (task->tf_flags & IDE_TFLAG_IN_HOB_LBAH) | 271 | if (cmd->tf_flags & IDE_TFLAG_IN_HOB_LBAH) |
272 | tf->hob_lbah = ide_mm_inb(io_ports->lbah_addr); | 272 | tf->hob_lbah = ide_mm_inb(io_ports->lbah_addr); |
273 | } | 273 | } |
274 | } | 274 | } |