diff options
author | Kees Cook <keescook@chromium.org> | 2013-07-03 18:04:56 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-07-03 19:07:41 -0400 |
commit | 02aa2a37636c8fa4fb9322d91be46ff8225b7de0 (patch) | |
tree | 97c93d17cfcad186d229ef76f96de709eddfea8c /drivers/hsi | |
parent | 096a8aac6bf4a5a0b2ef812ad76d056bbf3fb2af (diff) |
drivers: avoid format string in dev_set_name
Calling dev_set_name with a single paramter causes it to be handled as a
format string. Many callers are passing potentially dynamic string
content, so use "%s" in those cases to avoid any potential accidents,
including wrappers like device_create*() and bdi_register().
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/hsi')
-rw-r--r-- | drivers/hsi/hsi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hsi/hsi.c b/drivers/hsi/hsi.c index 833dd1afbf46..66d44581e1b1 100644 --- a/drivers/hsi/hsi.c +++ b/drivers/hsi/hsi.c | |||
@@ -75,7 +75,7 @@ static void hsi_new_client(struct hsi_port *port, struct hsi_board_info *info) | |||
75 | cl->device.bus = &hsi_bus_type; | 75 | cl->device.bus = &hsi_bus_type; |
76 | cl->device.parent = &port->device; | 76 | cl->device.parent = &port->device; |
77 | cl->device.release = hsi_client_release; | 77 | cl->device.release = hsi_client_release; |
78 | dev_set_name(&cl->device, info->name); | 78 | dev_set_name(&cl->device, "%s", info->name); |
79 | cl->device.platform_data = info->platform_data; | 79 | cl->device.platform_data = info->platform_data; |
80 | if (info->archdata) | 80 | if (info->archdata) |
81 | cl->device.archdata = *info->archdata; | 81 | cl->device.archdata = *info->archdata; |