HID: debug: break out hid_dump_report() into hid-debug

No semantic changes, but hid_dump_report should be in hid-debug.c, not
in hid-core.c

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

1 files changed, 2 insertions, 23 deletions

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index aa341d135867..f86dd9708ca5 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1260,8 +1260,6 @@ int hid_input_report(struct hid_device *hid, int type, u8 *data, int size, int i
         struct hid_report_enum *report_enum;
         struct hid_driver *hdrv;
         struct hid_report *report;
-        char *buf;
-        unsigned int i;
         int ret = 0;
 
         if (!hid)
@@ -1284,28 +1282,9 @@ int hid_input_report(struct hid_device *hid, int type, u8 *data, int size, int i
         }
 
         /* Avoid unnecessary overhead if debugfs is disabled */
-        if (list_empty(&hid->debug_list))
-                goto nomem;
-
-        buf = kmalloc(sizeof(char) * HID_DEBUG_BUFSIZE, GFP_ATOMIC);
-
-        if (!buf)
-                goto nomem;
-
-        /* dump the report */
-        snprintf(buf, HID_DEBUG_BUFSIZE - 1,
-                        "\nreport (size %u) (%snumbered) = ", size, report_enum->numbered ? "" : "un");
-        hid_debug_event(hid, buf);
-
-        for (i = 0; i < size; i++) {
-                snprintf(buf, HID_DEBUG_BUFSIZE - 1,
-                                " %02x", data[i]);
-                hid_debug_event(hid, buf);
-        }
-        hid_debug_event(hid, "\n");
-        kfree(buf);
+        if (!list_empty(&hid->debug_list))
+                hid_dump_report(hid, type, data, size);
 
-nomem:
         report = hid_get_report(report_enum, data);
 
         if (!report) {