diff options
author | Dave Airlie <airlied@gmail.com> | 2013-05-12 22:48:40 -0400 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2013-05-16 21:45:45 -0400 |
commit | b2b4465d8bade681491e225fa6a5dc050820b004 (patch) | |
tree | 2d37399db7d314fd92687b3640b9a64b0317e487 /drivers/gpu | |
parent | d7292a07a1b3d0b31a54a3e949ed4dd99e9a85e8 (diff) |
drm/qxl: drop active_user_framebuffer as its unneeded
This was a bogus way to figure out what the active framebuffer was,
just check if the underlying bo is the primary bo.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu')
-rw-r--r-- | drivers/gpu/drm/qxl/qxl_display.c | 16 | ||||
-rw-r--r-- | drivers/gpu/drm/qxl/qxl_drv.h | 6 |
2 files changed, 4 insertions, 18 deletions
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 735ddd2cb99f..823d29e926ec 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c | |||
@@ -428,10 +428,10 @@ static int qxl_framebuffer_surface_dirty(struct drm_framebuffer *fb, | |||
428 | int inc = 1; | 428 | int inc = 1; |
429 | 429 | ||
430 | qobj = gem_to_qxl_bo(qxl_fb->obj); | 430 | qobj = gem_to_qxl_bo(qxl_fb->obj); |
431 | if (qxl_fb != qdev->active_user_framebuffer) { | 431 | /* if we aren't primary surface ignore this */ |
432 | DRM_INFO("%s: qxl_fb 0x%p != qdev->active_user_framebuffer 0x%p\n", | 432 | if (!qobj->is_primary) |
433 | __func__, qxl_fb, qdev->active_user_framebuffer); | 433 | return 0; |
434 | } | 434 | |
435 | if (!num_clips) { | 435 | if (!num_clips) { |
436 | num_clips = 1; | 436 | num_clips = 1; |
437 | clips = &norect; | 437 | clips = &norect; |
@@ -892,7 +892,6 @@ qxl_user_framebuffer_create(struct drm_device *dev, | |||
892 | { | 892 | { |
893 | struct drm_gem_object *obj; | 893 | struct drm_gem_object *obj; |
894 | struct qxl_framebuffer *qxl_fb; | 894 | struct qxl_framebuffer *qxl_fb; |
895 | struct qxl_device *qdev = dev->dev_private; | ||
896 | int ret; | 895 | int ret; |
897 | 896 | ||
898 | obj = drm_gem_object_lookup(dev, file_priv, mode_cmd->handles[0]); | 897 | obj = drm_gem_object_lookup(dev, file_priv, mode_cmd->handles[0]); |
@@ -908,13 +907,6 @@ qxl_user_framebuffer_create(struct drm_device *dev, | |||
908 | return NULL; | 907 | return NULL; |
909 | } | 908 | } |
910 | 909 | ||
911 | if (qdev->active_user_framebuffer) { | ||
912 | DRM_INFO("%s: active_user_framebuffer %p -> %p\n", | ||
913 | __func__, | ||
914 | qdev->active_user_framebuffer, qxl_fb); | ||
915 | } | ||
916 | qdev->active_user_framebuffer = qxl_fb; | ||
917 | |||
918 | return &qxl_fb->base; | 910 | return &qxl_fb->base; |
919 | } | 911 | } |
920 | 912 | ||
diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h index 5b7c130f4744..43d06ab28a21 100644 --- a/drivers/gpu/drm/qxl/qxl_drv.h +++ b/drivers/gpu/drm/qxl/qxl_drv.h | |||
@@ -255,12 +255,6 @@ struct qxl_device { | |||
255 | struct qxl_gem gem; | 255 | struct qxl_gem gem; |
256 | struct qxl_mode_info mode_info; | 256 | struct qxl_mode_info mode_info; |
257 | 257 | ||
258 | /* | ||
259 | * last created framebuffer with fb_create | ||
260 | * only used by debugfs dumbppm | ||
261 | */ | ||
262 | struct qxl_framebuffer *active_user_framebuffer; | ||
263 | |||
264 | struct fb_info *fbdev_info; | 258 | struct fb_info *fbdev_info; |
265 | struct qxl_framebuffer *fbdev_qfb; | 259 | struct qxl_framebuffer *fbdev_qfb; |
266 | void *ram_physical; | 260 | void *ram_physical; |