diff options
| author | Mika Kuoppala <mika.kuoppala@linux.intel.com> | 2015-01-13 04:32:25 -0500 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-01-27 03:51:06 -0500 |
| commit | a7cbedec8317a5cacecb567674fdbc1c3fb22de8 (patch) | |
| tree | 947b474fb193a9bc5c051a2406ebbc57ae13ec46 /drivers/gpu | |
| parent | 1197b4f230fb7c8fe3a9b549596fe130b09a0db2 (diff) | |
drm/i915: Rename unpin_count to pin_count
We increase it when we pin, so for the casual reader
rename it to cause less confusion.
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
Reviewed-by: Thomas Daniel <thomas.daniel@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/i915/i915_drv.h | 2 | ||||
| -rw-r--r-- | drivers/gpu/drm/i915/intel_lrc.c | 12 |
2 files changed, 7 insertions, 7 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 56fd2b80f8af..de304d78e2bf 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h | |||
| @@ -765,7 +765,7 @@ struct intel_context { | |||
| 765 | struct { | 765 | struct { |
| 766 | struct drm_i915_gem_object *state; | 766 | struct drm_i915_gem_object *state; |
| 767 | struct intel_ringbuffer *ringbuf; | 767 | struct intel_ringbuffer *ringbuf; |
| 768 | int unpin_count; | 768 | int pin_count; |
| 769 | } engine[I915_NUM_RINGS]; | 769 | } engine[I915_NUM_RINGS]; |
| 770 | 770 | ||
| 771 | struct list_head link; | 771 | struct list_head link; |
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index ec3998c5d32e..70e449b702cc 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c | |||
| @@ -807,11 +807,11 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring, | |||
| 807 | int ret = 0; | 807 | int ret = 0; |
| 808 | 808 | ||
| 809 | WARN_ON(!mutex_is_locked(&ring->dev->struct_mutex)); | 809 | WARN_ON(!mutex_is_locked(&ring->dev->struct_mutex)); |
| 810 | if (ctx->engine[ring->id].unpin_count++ == 0) { | 810 | if (ctx->engine[ring->id].pin_count++ == 0) { |
| 811 | ret = i915_gem_obj_ggtt_pin(ctx_obj, | 811 | ret = i915_gem_obj_ggtt_pin(ctx_obj, |
| 812 | GEN8_LR_CONTEXT_ALIGN, 0); | 812 | GEN8_LR_CONTEXT_ALIGN, 0); |
| 813 | if (ret) | 813 | if (ret) |
| 814 | goto reset_unpin_count; | 814 | goto reset_pin_count; |
| 815 | 815 | ||
| 816 | ret = intel_pin_and_map_ringbuffer_obj(ring->dev, ringbuf); | 816 | ret = intel_pin_and_map_ringbuffer_obj(ring->dev, ringbuf); |
| 817 | if (ret) | 817 | if (ret) |
| @@ -822,8 +822,8 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring, | |||
| 822 | 822 | ||
| 823 | unpin_ctx_obj: | 823 | unpin_ctx_obj: |
| 824 | i915_gem_object_ggtt_unpin(ctx_obj); | 824 | i915_gem_object_ggtt_unpin(ctx_obj); |
| 825 | reset_unpin_count: | 825 | reset_pin_count: |
| 826 | ctx->engine[ring->id].unpin_count = 0; | 826 | ctx->engine[ring->id].pin_count = 0; |
| 827 | 827 | ||
| 828 | return ret; | 828 | return ret; |
| 829 | } | 829 | } |
| @@ -836,7 +836,7 @@ void intel_lr_context_unpin(struct intel_engine_cs *ring, | |||
| 836 | 836 | ||
| 837 | if (ctx_obj) { | 837 | if (ctx_obj) { |
| 838 | WARN_ON(!mutex_is_locked(&ring->dev->struct_mutex)); | 838 | WARN_ON(!mutex_is_locked(&ring->dev->struct_mutex)); |
| 839 | if (--ctx->engine[ring->id].unpin_count == 0) { | 839 | if (--ctx->engine[ring->id].pin_count == 0) { |
| 840 | intel_unpin_ringbuffer_obj(ringbuf); | 840 | intel_unpin_ringbuffer_obj(ringbuf); |
| 841 | i915_gem_object_ggtt_unpin(ctx_obj); | 841 | i915_gem_object_ggtt_unpin(ctx_obj); |
| 842 | } | 842 | } |
| @@ -1751,7 +1751,7 @@ void intel_lr_context_free(struct intel_context *ctx) | |||
| 1751 | intel_unpin_ringbuffer_obj(ringbuf); | 1751 | intel_unpin_ringbuffer_obj(ringbuf); |
| 1752 | i915_gem_object_ggtt_unpin(ctx_obj); | 1752 | i915_gem_object_ggtt_unpin(ctx_obj); |
| 1753 | } | 1753 | } |
| 1754 | WARN_ON(ctx->engine[ring->id].unpin_count); | 1754 | WARN_ON(ctx->engine[ring->id].pin_count); |
| 1755 | intel_destroy_ringbuffer_obj(ringbuf); | 1755 | intel_destroy_ringbuffer_obj(ringbuf); |
| 1756 | kfree(ringbuf); | 1756 | kfree(ringbuf); |
| 1757 | drm_gem_object_unreference(&ctx_obj->base); | 1757 | drm_gem_object_unreference(&ctx_obj->base); |
