diff options
author | Sascha Hauer <s.hauer@pengutronix.de> | 2012-02-06 04:58:19 -0500 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2012-02-09 05:34:43 -0500 |
commit | fb2a99e15ff0d342de4ba58c84a791224a96a01a (patch) | |
tree | 7e7addff62f92f4ffed79162474a93c1ba25c49b /drivers/gpu/drm | |
parent | d9bc3c02e36d844c2d980e65ddda5c7699e073f8 (diff) |
drm: do not set fb_info->pixmap fields
The drm drivers set the fb_info->pixmap fields without setting
fb_info->pixmap.addr. If this is not set the fb core will overwrite
these all fb_info->pixmap fields anyway, so there is not much point
in setting them in the first place.
[airlied: dropped nvidiafb piece - not mine]
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm')
-rw-r--r-- | drivers/gpu/drm/gma500/framebuffer.c | 6 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_fb.c | 6 | ||||
-rw-r--r-- | drivers/gpu/drm/nouveau/nouveau_fbcon.c | 6 | ||||
-rw-r--r-- | drivers/gpu/drm/radeon/radeon_fb.c | 6 | ||||
-rw-r--r-- | drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 14 |
5 files changed, 5 insertions, 33 deletions
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 78733b5fd3fb..c1c4dc174fa2 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c | |||
@@ -507,11 +507,7 @@ static int psbfb_create(struct psb_fbdev *fbdev, | |||
507 | info->fix.mmio_start = pci_resource_start(dev->pdev, 0); | 507 | info->fix.mmio_start = pci_resource_start(dev->pdev, 0); |
508 | info->fix.mmio_len = pci_resource_len(dev->pdev, 0); | 508 | info->fix.mmio_len = pci_resource_len(dev->pdev, 0); |
509 | 509 | ||
510 | info->pixmap.size = 64 * 1024; | 510 | /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */ |
511 | info->pixmap.buf_align = 8; | ||
512 | info->pixmap.access_align = 32; | ||
513 | info->pixmap.flags = FB_PIXMAP_SYSTEM; | ||
514 | info->pixmap.scan_align = 1; | ||
515 | 511 | ||
516 | dev_info(dev->dev, "allocated %dx%d fb\n", | 512 | dev_info(dev->dev, "allocated %dx%d fb\n", |
517 | psbfb->base.width, psbfb->base.height); | 513 | psbfb->base.width, psbfb->base.height); |
diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c index 571375a3eef4..2d8766978388 100644 --- a/drivers/gpu/drm/i915/intel_fb.c +++ b/drivers/gpu/drm/i915/intel_fb.c | |||
@@ -152,11 +152,7 @@ static int intelfb_create(struct intel_fbdev *ifbdev, | |||
152 | drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); | 152 | drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth); |
153 | drm_fb_helper_fill_var(info, &ifbdev->helper, sizes->fb_width, sizes->fb_height); | 153 | drm_fb_helper_fill_var(info, &ifbdev->helper, sizes->fb_width, sizes->fb_height); |
154 | 154 | ||
155 | info->pixmap.size = 64*1024; | 155 | /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */ |
156 | info->pixmap.buf_align = 8; | ||
157 | info->pixmap.access_align = 32; | ||
158 | info->pixmap.flags = FB_PIXMAP_SYSTEM; | ||
159 | info->pixmap.scan_align = 1; | ||
160 | 156 | ||
161 | DRM_DEBUG_KMS("allocated %dx%d fb: 0x%08x, bo %p\n", | 157 | DRM_DEBUG_KMS("allocated %dx%d fb: 0x%08x, bo %p\n", |
162 | fb->width, fb->height, | 158 | fb->width, fb->height, |
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index 9892218d7452..8113e9201ed9 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c | |||
@@ -381,11 +381,7 @@ nouveau_fbcon_create(struct nouveau_fbdev *nfbdev, | |||
381 | goto out_unref; | 381 | goto out_unref; |
382 | } | 382 | } |
383 | 383 | ||
384 | info->pixmap.size = 64*1024; | 384 | /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */ |
385 | info->pixmap.buf_align = 8; | ||
386 | info->pixmap.access_align = 32; | ||
387 | info->pixmap.flags = FB_PIXMAP_SYSTEM; | ||
388 | info->pixmap.scan_align = 1; | ||
389 | 385 | ||
390 | mutex_unlock(&dev->struct_mutex); | 386 | mutex_unlock(&dev->struct_mutex); |
391 | 387 | ||
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c index cf2bf35b56b8..a5692d5f415d 100644 --- a/drivers/gpu/drm/radeon/radeon_fb.c +++ b/drivers/gpu/drm/radeon/radeon_fb.c | |||
@@ -254,11 +254,7 @@ static int radeonfb_create(struct radeon_fbdev *rfbdev, | |||
254 | info->apertures->ranges[0].base = rdev->ddev->mode_config.fb_base; | 254 | info->apertures->ranges[0].base = rdev->ddev->mode_config.fb_base; |
255 | info->apertures->ranges[0].size = rdev->mc.aper_size; | 255 | info->apertures->ranges[0].size = rdev->mc.aper_size; |
256 | 256 | ||
257 | info->pixmap.size = 64*1024; | 257 | /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */ |
258 | info->pixmap.buf_align = 8; | ||
259 | info->pixmap.access_align = 32; | ||
260 | info->pixmap.flags = FB_PIXMAP_SYSTEM; | ||
261 | info->pixmap.scan_align = 1; | ||
262 | 258 | ||
263 | if (info->screen_base == NULL) { | 259 | if (info->screen_base == NULL) { |
264 | ret = -ENOSPC; | 260 | ret = -ENOSPC; |
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c index 34e51a1695b8..67f1d54b79b4 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | |||
@@ -515,19 +515,7 @@ int vmw_fb_init(struct vmw_private *vmw_priv) | |||
515 | info->var.xres = initial_width; | 515 | info->var.xres = initial_width; |
516 | info->var.yres = initial_height; | 516 | info->var.yres = initial_height; |
517 | 517 | ||
518 | #if 0 | 518 | /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */ |
519 | info->pixmap.size = 64*1024; | ||
520 | info->pixmap.buf_align = 8; | ||
521 | info->pixmap.access_align = 32; | ||
522 | info->pixmap.flags = FB_PIXMAP_SYSTEM; | ||
523 | info->pixmap.scan_align = 1; | ||
524 | #else | ||
525 | info->pixmap.size = 0; | ||
526 | info->pixmap.buf_align = 8; | ||
527 | info->pixmap.access_align = 32; | ||
528 | info->pixmap.flags = FB_PIXMAP_SYSTEM; | ||
529 | info->pixmap.scan_align = 1; | ||
530 | #endif | ||
531 | 519 | ||
532 | info->apertures = alloc_apertures(1); | 520 | info->apertures = alloc_apertures(1); |
533 | if (!info->apertures) { | 521 | if (!info->apertures) { |