diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-09-28 05:35:31 -0400 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2013-10-09 17:13:48 -0400 |
| commit | 5fd9c581862a4874c0bdaf16231d8873832bbb99 (patch) | |
| tree | 41a83e11f3a26c9cb6838604b6a2eb2766f575ce /drivers/gpu/drm | |
| parent | 96d8df846f52a720c8ae1fadadfad7c9e733e336 (diff) | |
drm/radeon/dpm: off by one in si_set_mc_special_registers()
These checks should be ">=" instead of ">". j is used as an offset into
the table->mc_reg_address[] array and that has
SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE (16) elements.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/gpu/drm')
| -rw-r--r-- | drivers/gpu/drm/radeon/si_dpm.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c index 9ace28702c76..2332aa1bf93c 100644 --- a/drivers/gpu/drm/radeon/si_dpm.c +++ b/drivers/gpu/drm/radeon/si_dpm.c | |||
| @@ -5208,7 +5208,7 @@ static int si_set_mc_special_registers(struct radeon_device *rdev, | |||
| 5208 | table->mc_reg_table_entry[k].mc_data[j] |= 0x100; | 5208 | table->mc_reg_table_entry[k].mc_data[j] |= 0x100; |
| 5209 | } | 5209 | } |
| 5210 | j++; | 5210 | j++; |
| 5211 | if (j > SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) | 5211 | if (j >= SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) |
| 5212 | return -EINVAL; | 5212 | return -EINVAL; |
| 5213 | 5213 | ||
| 5214 | if (!pi->mem_gddr5) { | 5214 | if (!pi->mem_gddr5) { |
| @@ -5218,7 +5218,7 @@ static int si_set_mc_special_registers(struct radeon_device *rdev, | |||
| 5218 | table->mc_reg_table_entry[k].mc_data[j] = | 5218 | table->mc_reg_table_entry[k].mc_data[j] = |
| 5219 | (table->mc_reg_table_entry[k].mc_data[i] & 0xffff0000) >> 16; | 5219 | (table->mc_reg_table_entry[k].mc_data[i] & 0xffff0000) >> 16; |
| 5220 | j++; | 5220 | j++; |
| 5221 | if (j > SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) | 5221 | if (j >= SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) |
| 5222 | return -EINVAL; | 5222 | return -EINVAL; |
| 5223 | } | 5223 | } |
| 5224 | break; | 5224 | break; |
| @@ -5231,7 +5231,7 @@ static int si_set_mc_special_registers(struct radeon_device *rdev, | |||
| 5231 | (temp_reg & 0xffff0000) | | 5231 | (temp_reg & 0xffff0000) | |
| 5232 | (table->mc_reg_table_entry[k].mc_data[i] & 0x0000ffff); | 5232 | (table->mc_reg_table_entry[k].mc_data[i] & 0x0000ffff); |
| 5233 | j++; | 5233 | j++; |
| 5234 | if (j > SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) | 5234 | if (j >= SMC_SISLANDS_MC_REGISTER_ARRAY_SIZE) |
| 5235 | return -EINVAL; | 5235 | return -EINVAL; |
| 5236 | break; | 5236 | break; |
| 5237 | default: | 5237 | default: |