diff options
author | Paulo Zanoni <paulo.r.zanoni@intel.com> | 2012-11-23 13:46:41 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2012-11-29 08:59:12 -0500 |
commit | 0d536cb4e911c2496073f268e9730a9badaafa55 (patch) | |
tree | ca6e48249cee2e453984ea785cf773b9ee6750aa /drivers/gpu/drm | |
parent | affa935440733a79c5a9eb0e5357e2564ca4b355 (diff) |
drm/i915: invert the log inside intel_prepare_ddi
Do an early return in case we don't have DDI instead of having the
whole function inside an "if" statement.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm')
-rw-r--r-- | drivers/gpu/drm/i915/intel_ddi.c | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index 197dede1870a..ad936c68e4cb 100644 --- a/drivers/gpu/drm/i915/intel_ddi.c +++ b/drivers/gpu/drm/i915/intel_ddi.c | |||
@@ -115,16 +115,17 @@ void intel_prepare_ddi(struct drm_device *dev) | |||
115 | { | 115 | { |
116 | int port; | 116 | int port; |
117 | 117 | ||
118 | if (HAS_DDI(dev)) { | 118 | if (!HAS_DDI(dev)) |
119 | for (port = PORT_A; port < PORT_E; port++) | 119 | return; |
120 | intel_prepare_ddi_buffers(dev, port, false); | ||
121 | 120 | ||
122 | /* DDI E is the suggested one to work in FDI mode, so program is as such by | 121 | for (port = PORT_A; port < PORT_E; port++) |
123 | * default. It will have to be re-programmed in case a digital DP output | 122 | intel_prepare_ddi_buffers(dev, port, false); |
124 | * will be detected on it | 123 | |
125 | */ | 124 | /* DDI E is the suggested one to work in FDI mode, so program is as such |
126 | intel_prepare_ddi_buffers(dev, PORT_E, true); | 125 | * by default. It will have to be re-programmed in case a digital DP |
127 | } | 126 | * output will be detected on it |
127 | */ | ||
128 | intel_prepare_ddi_buffers(dev, PORT_E, true); | ||
128 | } | 129 | } |
129 | 130 | ||
130 | static const long hsw_ddi_buf_ctl_values[] = { | 131 | static const long hsw_ddi_buf_ctl_values[] = { |