diff options
| author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2010-10-26 17:21:51 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-10-26 19:52:08 -0400 |
| commit | 3e4d3af501cccdc8a8cca41bdbe57d54ad7e7e73 (patch) | |
| tree | 2ce507f7ec7275563653e52f18606aba4f99b7f1 /drivers/gpu/drm/ttm | |
| parent | 61ecdb801ef2cd28e32442383106d7837d76deac (diff) | |
mm: stack based kmap_atomic()
Keep the current interface but ignore the KM_type and use a stack based
approach.
The advantage is that we get rid of crappy code like:
#define __KM_PTE \
(in_nmi() ? KM_NMI_PTE : \
in_irq() ? KM_IRQ_PTE : \
KM_PTE0)
and in general can stop worrying about what context we're in and what kmap
slots might be appropriate for that.
The downside is that FRV kmap_atomic() gets more expensive.
For now we use a CPP trick suggested by Andrew:
#define kmap_atomic(page, args...) __kmap_atomic(page)
to avoid having to touch all kmap_atomic() users in a single patch.
[ not compiled on:
- mn10300: the arch doesn't actually build with highmem to begin with ]
[akpm@linux-foundation.org: coding-style fixes]
[akpm@linux-foundation.org: fix up drivers/gpu/drm/i915/intel_overlay.c]
Acked-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: David Miller <davem@davemloft.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Dave Airlie <airlied@linux.ie>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/gpu/drm/ttm')
| -rw-r--r-- | drivers/gpu/drm/ttm/ttm_bo_util.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c index 3451a82adba7..e8a73e65da69 100644 --- a/drivers/gpu/drm/ttm/ttm_bo_util.c +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c | |||
| @@ -170,7 +170,7 @@ static int ttm_copy_io_ttm_page(struct ttm_tt *ttm, void *src, | |||
| 170 | src = (void *)((unsigned long)src + (page << PAGE_SHIFT)); | 170 | src = (void *)((unsigned long)src + (page << PAGE_SHIFT)); |
| 171 | 171 | ||
| 172 | #ifdef CONFIG_X86 | 172 | #ifdef CONFIG_X86 |
| 173 | dst = kmap_atomic_prot(d, KM_USER0, prot); | 173 | dst = kmap_atomic_prot(d, prot); |
| 174 | #else | 174 | #else |
| 175 | if (pgprot_val(prot) != pgprot_val(PAGE_KERNEL)) | 175 | if (pgprot_val(prot) != pgprot_val(PAGE_KERNEL)) |
| 176 | dst = vmap(&d, 1, 0, prot); | 176 | dst = vmap(&d, 1, 0, prot); |
| @@ -183,7 +183,7 @@ static int ttm_copy_io_ttm_page(struct ttm_tt *ttm, void *src, | |||
| 183 | memcpy_fromio(dst, src, PAGE_SIZE); | 183 | memcpy_fromio(dst, src, PAGE_SIZE); |
| 184 | 184 | ||
| 185 | #ifdef CONFIG_X86 | 185 | #ifdef CONFIG_X86 |
| 186 | kunmap_atomic(dst, KM_USER0); | 186 | kunmap_atomic(dst); |
| 187 | #else | 187 | #else |
| 188 | if (pgprot_val(prot) != pgprot_val(PAGE_KERNEL)) | 188 | if (pgprot_val(prot) != pgprot_val(PAGE_KERNEL)) |
| 189 | vunmap(dst); | 189 | vunmap(dst); |
| @@ -206,7 +206,7 @@ static int ttm_copy_ttm_io_page(struct ttm_tt *ttm, void *dst, | |||
| 206 | 206 | ||
| 207 | dst = (void *)((unsigned long)dst + (page << PAGE_SHIFT)); | 207 | dst = (void *)((unsigned long)dst + (page << PAGE_SHIFT)); |
| 208 | #ifdef CONFIG_X86 | 208 | #ifdef CONFIG_X86 |
| 209 | src = kmap_atomic_prot(s, KM_USER0, prot); | 209 | src = kmap_atomic_prot(s, prot); |
| 210 | #else | 210 | #else |
| 211 | if (pgprot_val(prot) != pgprot_val(PAGE_KERNEL)) | 211 | if (pgprot_val(prot) != pgprot_val(PAGE_KERNEL)) |
| 212 | src = vmap(&s, 1, 0, prot); | 212 | src = vmap(&s, 1, 0, prot); |
| @@ -219,7 +219,7 @@ static int ttm_copy_ttm_io_page(struct ttm_tt *ttm, void *dst, | |||
| 219 | memcpy_toio(dst, src, PAGE_SIZE); | 219 | memcpy_toio(dst, src, PAGE_SIZE); |
| 220 | 220 | ||
| 221 | #ifdef CONFIG_X86 | 221 | #ifdef CONFIG_X86 |
| 222 | kunmap_atomic(src, KM_USER0); | 222 | kunmap_atomic(src); |
| 223 | #else | 223 | #else |
| 224 | if (pgprot_val(prot) != pgprot_val(PAGE_KERNEL)) | 224 | if (pgprot_val(prot) != pgprot_val(PAGE_KERNEL)) |
| 225 | vunmap(src); | 225 | vunmap(src); |
