diff options
author | Maarten Lankhorst <m.b.lankhorst@gmail.com> | 2012-11-28 06:25:44 -0500 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2012-12-10 05:21:30 -0500 |
commit | 97a875cbdf89a4638eea57c2b456c7cc4e3e8b21 (patch) | |
tree | 286ff23a3f8e389ec4fa1a6f3b58cbee4fc8e9fe /drivers/gpu/drm/ttm/ttm_bo_util.c | |
parent | e7ab20197be3ee5fd75441e1cff0c7cdfea5bf1a (diff) |
drm/ttm: remove no_wait_reserve, v3
All items on the lru list are always reservable, so this is a stupid
thing to keep. Not only that, it is used in a way which would
guarantee deadlocks if it were ever to be set to block on reserve.
This is a lot of churn, but mostly because of the removal of the
argument which can be nested arbitrarily deeply in many places.
No change of code in this patch except removal of the no_wait_reserve
argument, the previous patch removed the use of no_wait_reserve.
v2:
- Warn if -EBUSY is returned on reservation, all objects on the list
should be reservable. Adjusted patch slightly due to conflicts.
v3:
- Focus on no_wait_reserve removal only.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/ttm/ttm_bo_util.c')
-rw-r--r-- | drivers/gpu/drm/ttm/ttm_bo_util.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c index b9c4e515b1d8..9e9c5d2a5c74 100644 --- a/drivers/gpu/drm/ttm/ttm_bo_util.c +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c | |||
@@ -43,7 +43,7 @@ void ttm_bo_free_old_node(struct ttm_buffer_object *bo) | |||
43 | } | 43 | } |
44 | 44 | ||
45 | int ttm_bo_move_ttm(struct ttm_buffer_object *bo, | 45 | int ttm_bo_move_ttm(struct ttm_buffer_object *bo, |
46 | bool evict, bool no_wait_reserve, | 46 | bool evict, |
47 | bool no_wait_gpu, struct ttm_mem_reg *new_mem) | 47 | bool no_wait_gpu, struct ttm_mem_reg *new_mem) |
48 | { | 48 | { |
49 | struct ttm_tt *ttm = bo->ttm; | 49 | struct ttm_tt *ttm = bo->ttm; |
@@ -314,7 +314,7 @@ static int ttm_copy_ttm_io_page(struct ttm_tt *ttm, void *dst, | |||
314 | } | 314 | } |
315 | 315 | ||
316 | int ttm_bo_move_memcpy(struct ttm_buffer_object *bo, | 316 | int ttm_bo_move_memcpy(struct ttm_buffer_object *bo, |
317 | bool evict, bool no_wait_reserve, bool no_wait_gpu, | 317 | bool evict, bool no_wait_gpu, |
318 | struct ttm_mem_reg *new_mem) | 318 | struct ttm_mem_reg *new_mem) |
319 | { | 319 | { |
320 | struct ttm_bo_device *bdev = bo->bdev; | 320 | struct ttm_bo_device *bdev = bo->bdev; |
@@ -611,7 +611,7 @@ EXPORT_SYMBOL(ttm_bo_kunmap); | |||
611 | 611 | ||
612 | int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo, | 612 | int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo, |
613 | void *sync_obj, | 613 | void *sync_obj, |
614 | bool evict, bool no_wait_reserve, | 614 | bool evict, |
615 | bool no_wait_gpu, | 615 | bool no_wait_gpu, |
616 | struct ttm_mem_reg *new_mem) | 616 | struct ttm_mem_reg *new_mem) |
617 | { | 617 | { |