Merge branch 'drm-fbdev-cleanup' into drm-core-next

* drm-fbdev-cleanup:
  drm/fb: remove drm_fb_helper_setcolreg
  drm/kms/fb: use slow work mechanism for normal hotplug also.
  drm/kms/fb: add polling support for when nothing is connected.
  drm/kms/fb: provide a 1024x768 fbcon if no outputs found.
  drm/kms/fb: separate fbdev connector list from core drm connectors
  drm/kms/fb: move to using fb helper crtc grouping instead of core crtc list
  drm/fb: fix fbdev object model + cleanup properly.

Conflicts:
	drivers/gpu/drm/i915/i915_drv.h
	drivers/gpu/drm/nouveau/nouveau_drv.h

8 files changed, 259 insertions, 225 deletions

diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h
index 4ac97ab28947..be7570ac901c 100644
--- a/drivers/gpu/drm/radeon/radeon.h
+++ b/drivers/gpu/drm/radeon/radeon.h
@@ -938,9 +938,6 @@ struct radeon_device {
         bool                            is_atom_bios;
         uint16_t                        bios_header_start;
         struct radeon_bo                *stollen_vga_memory;
-        struct fb_info                  *fbdev_info;
-        struct radeon_bo                *fbdev_rbo;
-        struct radeon_framebuffer       *fbdev_rfb;
         /* Register mmio */
         resource_size_t                 rmmio_base;
         resource_size_t                 rmmio_size;
diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
index 1331351c5178..c48934677adf 100644
--- a/drivers/gpu/drm/radeon/radeon_connectors.c
+++ b/drivers/gpu/drm/radeon/radeon_connectors.c
@@ -1041,7 +1041,6 @@ radeon_add_atom_connector(struct drm_device *dev,
         struct radeon_connector_atom_dig *radeon_dig_connector;
         uint32_t subpixel_order = SubPixelNone;
         bool shared_ddc = false;
-        int ret;
 
         /* fixme - tv/cv/din */
         if (connector_type == DRM_MODE_CONNECTOR_Unknown)
@@ -1076,9 +1075,7 @@ radeon_add_atom_connector(struct drm_device *dev,
         switch (connector_type) {
         case DRM_MODE_CONNECTOR_VGA:
                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
-                ret = drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
-                if (ret)
-                        goto failed;
+                drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
                 if (i2c_bus->valid) {
                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "VGA");
                         if (!radeon_connector->ddc_bus)
@@ -1091,9 +1088,7 @@ radeon_add_atom_connector(struct drm_device *dev,
                 break;
         case DRM_MODE_CONNECTOR_DVIA:
                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
-                ret = drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
-                if (ret)
-                        goto failed;
+                drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
                 if (i2c_bus->valid) {
                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
                         if (!radeon_connector->ddc_bus)
@@ -1113,9 +1108,7 @@ radeon_add_atom_connector(struct drm_device *dev,
                 radeon_dig_connector->igp_lane_info = igp_lane_info;
                 radeon_connector->con_priv = radeon_dig_connector;
                 drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
-                ret = drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
-                if (ret)
-                        goto failed;
+                drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
                 if (i2c_bus->valid) {
                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
                         if (!radeon_connector->ddc_bus)
@@ -1141,9 +1134,7 @@ radeon_add_atom_connector(struct drm_device *dev,
                 radeon_dig_connector->igp_lane_info = igp_lane_info;
                 radeon_connector->con_priv = radeon_dig_connector;
                 drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
-                ret = drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
-                if (ret)
-                        goto failed;
+                drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
                 if (i2c_bus->valid) {
                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "HDMI");
                         if (!radeon_connector->ddc_bus)
@@ -1163,9 +1154,7 @@ radeon_add_atom_connector(struct drm_device *dev,
                 radeon_dig_connector->igp_lane_info = igp_lane_info;
                 radeon_connector->con_priv = radeon_dig_connector;
                 drm_connector_init(dev, &radeon_connector->base, &radeon_dp_connector_funcs, connector_type);
-                ret = drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
-                if (ret)
-                        goto failed;
+                drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
                 if (i2c_bus->valid) {
                         /* add DP i2c bus */
                         if (connector_type == DRM_MODE_CONNECTOR_eDP)
@@ -1191,9 +1180,7 @@ radeon_add_atom_connector(struct drm_device *dev,
         case DRM_MODE_CONNECTOR_9PinDIN:
                 if (radeon_tv == 1) {
                         drm_connector_init(dev, &radeon_connector->base, &radeon_tv_connector_funcs, connector_type);
-                        ret = drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
-                        if (ret)
-                                goto failed;
+                        drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
                         radeon_connector->dac_load_detect = true;
                         drm_connector_attach_property(&radeon_connector->base,
                                                       rdev->mode_info.load_detect_property,
@@ -1211,9 +1198,7 @@ radeon_add_atom_connector(struct drm_device *dev,
                 radeon_dig_connector->igp_lane_info = igp_lane_info;
                 radeon_connector->con_priv = radeon_dig_connector;
                 drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
-                ret = drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
-                if (ret)
-                        goto failed;
+                drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
                 if (i2c_bus->valid) {
                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "LVDS");
                         if (!radeon_connector->ddc_bus)
@@ -1250,7 +1235,6 @@ radeon_add_legacy_connector(struct drm_device *dev,
         struct drm_connector *connector;
         struct radeon_connector *radeon_connector;
         uint32_t subpixel_order = SubPixelNone;
-        int ret;
 
         /* fixme - tv/cv/din */
         if (connector_type == DRM_MODE_CONNECTOR_Unknown)
@@ -1278,9 +1262,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
         switch (connector_type) {
         case DRM_MODE_CONNECTOR_VGA:
                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
-                ret = drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
-                if (ret)
-                        goto failed;
+                drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
                 if (i2c_bus->valid) {
                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "VGA");
                         if (!radeon_connector->ddc_bus)
@@ -1293,9 +1275,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
                 break;
         case DRM_MODE_CONNECTOR_DVIA:
                 drm_connector_init(dev, &radeon_connector->base, &radeon_vga_connector_funcs, connector_type);
-                ret = drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
-                if (ret)
-                        goto failed;
+                drm_connector_helper_add(&radeon_connector->base, &radeon_vga_connector_helper_funcs);
                 if (i2c_bus->valid) {
                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
                         if (!radeon_connector->ddc_bus)
@@ -1309,9 +1289,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
         case DRM_MODE_CONNECTOR_DVII:
         case DRM_MODE_CONNECTOR_DVID:
                 drm_connector_init(dev, &radeon_connector->base, &radeon_dvi_connector_funcs, connector_type);
-                ret = drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
-                if (ret)
-                        goto failed;
+                drm_connector_helper_add(&radeon_connector->base, &radeon_dvi_connector_helper_funcs);
                 if (i2c_bus->valid) {
                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "DVI");
                         if (!radeon_connector->ddc_bus)
@@ -1328,9 +1306,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
         case DRM_MODE_CONNECTOR_9PinDIN:
                 if (radeon_tv == 1) {
                         drm_connector_init(dev, &radeon_connector->base, &radeon_tv_connector_funcs, connector_type);
-                        ret = drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
-                        if (ret)
-                                goto failed;
+                        drm_connector_helper_add(&radeon_connector->base, &radeon_tv_connector_helper_funcs);
                         radeon_connector->dac_load_detect = true;
                         /* RS400,RC410,RS480 chipset seems to report a lot
                          * of false positive on load detect, we haven't yet
@@ -1349,9 +1325,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
                 break;
         case DRM_MODE_CONNECTOR_LVDS:
                 drm_connector_init(dev, &radeon_connector->base, &radeon_lvds_connector_funcs, connector_type);
-                ret = drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
-                if (ret)
-                        goto failed;
+                drm_connector_helper_add(&radeon_connector->base, &radeon_lvds_connector_helper_funcs);
                 if (i2c_bus->valid) {
                         radeon_connector->ddc_bus = radeon_i2c_create(dev, i2c_bus, "LVDS");
                         if (!radeon_connector->ddc_bus)
diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
index 001779d678b5..26217ffe0355 100644
--- a/drivers/gpu/drm/radeon/radeon_device.c
+++ b/drivers/gpu/drm/radeon/radeon_device.c
@@ -730,9 +730,10 @@ int radeon_suspend_kms(struct drm_device *dev, pm_message_t state)
                         continue;
                 }
                 robj = rfb->obj->driver_private;
-                if (robj != rdev->fbdev_rbo) {
+                /* don't unpin kernel fb objects */
+                if (!radeon_fbdev_robj_is_fb(rdev, robj)) {
                         r = radeon_bo_reserve(robj, false);
-                        if (unlikely(r == 0)) {
+                        if (r == 0) {
                                 radeon_bo_unpin(robj);
                                 radeon_bo_unreserve(robj);
                         }
@@ -757,7 +758,7 @@ int radeon_suspend_kms(struct drm_device *dev, pm_message_t state)
                 pci_set_power_state(dev->pdev, PCI_D3hot);
         }
         acquire_console_sem();
-        fb_set_suspend(rdev->fbdev_info, 1);
+        radeon_fbdev_set_suspend(rdev, 1);
         release_console_sem();
         return 0;
 }
@@ -781,7 +782,7 @@ int radeon_resume_kms(struct drm_device *dev)
         radeon_agp_resume(rdev);
         radeon_resume(rdev);
         radeon_restore_bios_scratch_regs(rdev);
-        fb_set_suspend(rdev->fbdev_info, 0);
+        radeon_fbdev_set_suspend(rdev, 0);
         release_console_sem();
 
         /* reset hpd state */
diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index b8d672828246..243c1c4bc836 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -831,10 +831,6 @@ void radeon_compute_pll(struct radeon_pll *pll,
 static void radeon_user_framebuffer_destroy(struct drm_framebuffer *fb)
 {
         struct radeon_framebuffer *radeon_fb = to_radeon_framebuffer(fb);
-        struct drm_device *dev = fb->dev;
-
-        if (fb->fbdev)
-                radeonfb_remove(dev, fb);
 
         if (radeon_fb->obj)
                 drm_gem_object_unreference_unlocked(radeon_fb->obj);
@@ -856,21 +852,15 @@ static const struct drm_framebuffer_funcs radeon_fb_funcs = {
         .create_handle = radeon_user_framebuffer_create_handle,
 };
 
-struct drm_framebuffer *
-radeon_framebuffer_create(struct drm_device *dev,
-                          struct drm_mode_fb_cmd *mode_cmd,
-                          struct drm_gem_object *obj)
+void
+radeon_framebuffer_init(struct drm_device *dev,
+                        struct radeon_framebuffer *rfb,
+                        struct drm_mode_fb_cmd *mode_cmd,
+                        struct drm_gem_object *obj)
 {
-        struct radeon_framebuffer *radeon_fb;
-
-        radeon_fb = kzalloc(sizeof(*radeon_fb), GFP_KERNEL);
-        if (radeon_fb == NULL) {
-                return NULL;
-        }
-        drm_framebuffer_init(dev, &radeon_fb->base, &radeon_fb_funcs);
-        drm_helper_mode_fill_fb_struct(&radeon_fb->base, mode_cmd);
-        radeon_fb->obj = obj;
-        return &radeon_fb->base;
+        rfb->obj = obj;
+        drm_framebuffer_init(dev, &rfb->base, &radeon_fb_funcs);
+        drm_helper_mode_fill_fb_struct(&rfb->base, mode_cmd);
 }
 
 static struct drm_framebuffer *
@@ -879,6 +869,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
                                struct drm_mode_fb_cmd *mode_cmd)
 {
         struct drm_gem_object *obj;
+        struct radeon_framebuffer *radeon_fb;
 
         obj = drm_gem_object_lookup(dev, file_priv, mode_cmd->handle);
         if (obj ==  NULL) {
@@ -886,12 +877,19 @@ radeon_user_framebuffer_create(struct drm_device *dev,
                         "can't create framebuffer\n", mode_cmd->handle);
                 return NULL;
         }
-        return radeon_framebuffer_create(dev, mode_cmd, obj);
+
+        radeon_fb = kzalloc(sizeof(*radeon_fb), GFP_KERNEL);
+        if (radeon_fb == NULL) {
+                return NULL;
+        }
+
+        radeon_framebuffer_init(dev, radeon_fb, mode_cmd, obj);
+
+        return &radeon_fb->base;
 }
 
 static const struct drm_mode_config_funcs radeon_mode_funcs = {
         .fb_create = radeon_user_framebuffer_create,
-        .fb_changed = radeonfb_probe,
 };
 
 struct drm_prop_enum_list {
@@ -1031,12 +1029,14 @@ int radeon_modeset_init(struct radeon_device *rdev)
         }
         /* initialize hpd */
         radeon_hpd_init(rdev);
-        drm_helper_initial_config(rdev->ddev);
+
+        radeon_fbdev_init(rdev);
         return 0;
 }
 
 void radeon_modeset_fini(struct radeon_device *rdev)
 {
+        radeon_fbdev_fini(rdev);
         kfree(rdev->mode_info.bios_hardcoded_edid);
 
         if (rdev->mode_info.mode_config_initialized) {
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
index 9ac57a09784b..fcb5b52727b0 100644
--- a/drivers/gpu/drm/radeon/radeon_fb.c
+++ b/drivers/gpu/drm/radeon/radeon_fb.c
@@ -23,10 +23,6 @@
  * Authors:
  *     David Airlie
  */
-    /*
-     *  Modularization
-     */
-
 #include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/fb.h>
@@ -42,17 +38,21 @@
 
 #include <linux/vga_switcheroo.h>
 
-struct radeon_fb_device {
+/* object hierarchy -
+   this contains a helper + a radeon fb
+   the helper contains a pointer to radeon framebuffer baseclass.
+*/
+struct radeon_fbdev {
         struct drm_fb_helper helper;
-        struct radeon_framebuffer       *rfb;
-        struct radeon_device            *rdev;
+        struct radeon_framebuffer rfb;
+        struct list_head fbdev_list;
+        struct radeon_device *rdev;
 };
 
 static struct fb_ops radeonfb_ops = {
         .owner = THIS_MODULE,
         .fb_check_var = drm_fb_helper_check_var,
         .fb_set_par = drm_fb_helper_set_par,
-        .fb_setcolreg = drm_fb_helper_setcolreg,
         .fb_fillrect = cfb_fillrect,
         .fb_copyarea = cfb_copyarea,
         .fb_imageblit = cfb_imageblit,
@@ -61,45 +61,6 @@ static struct fb_ops radeonfb_ops = {
         .fb_setcmap = drm_fb_helper_setcmap,
 };
 
-/**
- * Currently it is assumed that the old framebuffer is reused.
- *
- * LOCKING
- * caller should hold the mode config lock.
- *
- */
-int radeonfb_resize(struct drm_device *dev, struct drm_crtc *crtc)
-{
-        struct fb_info *info;
-        struct drm_framebuffer *fb;
-        struct drm_display_mode *mode = crtc->desired_mode;
-
-        fb = crtc->fb;
-        if (fb == NULL) {
-                return 1;
-        }
-        info = fb->fbdev;
-        if (info == NULL) {
-                return 1;
-        }
-        if (mode == NULL) {
-                return 1;
-        }
-        info->var.xres = mode->hdisplay;
-        info->var.right_margin = mode->hsync_start - mode->hdisplay;
-        info->var.hsync_len = mode->hsync_end - mode->hsync_start;
-        info->var.left_margin = mode->htotal - mode->hsync_end;
-        info->var.yres = mode->vdisplay;
-        info->var.lower_margin = mode->vsync_start - mode->vdisplay;
-        info->var.vsync_len = mode->vsync_end - mode->vsync_start;
-        info->var.upper_margin = mode->vtotal - mode->vsync_end;
-        info->var.pixclock = 10000000 / mode->htotal * 1000 / mode->vtotal * 100;
-        /* avoid overflow */
-        info->var.pixclock = info->var.pixclock * 1000 / mode->vrefresh;
-
-        return 0;
-}
-EXPORT_SYMBOL(radeonfb_resize);
 
 static int radeon_align_pitch(struct radeon_device *rdev, int width, int bpp, bool tiled)
 {
@@ -125,57 +86,44 @@ static int radeon_align_pitch(struct radeon_device *rdev, int width, int bpp, bo
         return aligned;
 }
 
-static struct drm_fb_helper_funcs radeon_fb_helper_funcs = {
-        .gamma_set = radeon_crtc_fb_gamma_set,
-        .gamma_get = radeon_crtc_fb_gamma_get,
-};
+static void radeonfb_destroy_pinned_object(struct drm_gem_object *gobj)
+{
+        struct radeon_bo *rbo = gobj->driver_private;
+        int ret;
+
+        ret = radeon_bo_reserve(rbo, false);
+        if (likely(ret == 0)) {
+                radeon_bo_kunmap(rbo);
+                radeon_bo_unreserve(rbo);
+        }
+        drm_gem_object_unreference_unlocked(gobj);
+}
 
-int radeonfb_create(struct drm_device *dev,
-                    uint32_t fb_width, uint32_t fb_height,
-                    uint32_t surface_width, uint32_t surface_height,
-                    uint32_t surface_depth, uint32_t surface_bpp,
-                    struct drm_framebuffer **fb_p)
+static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev,
+                                         struct drm_mode_fb_cmd *mode_cmd,
+                                         struct drm_gem_object **gobj_p)
 {
-        struct radeon_device *rdev = dev->dev_private;
-        struct fb_info *info;
-        struct radeon_fb_device *rfbdev;
-        struct drm_framebuffer *fb = NULL;
-        struct radeon_framebuffer *rfb;
-        struct drm_mode_fb_cmd mode_cmd;
+        struct radeon_device *rdev = rfbdev->rdev;
         struct drm_gem_object *gobj = NULL;
         struct radeon_bo *rbo = NULL;
-        struct device *device = &rdev->pdev->dev;
-        int size, aligned_size, ret;
-        u64 fb_gpuaddr;
-        void *fbptr = NULL;
-        unsigned long tmp;
         bool fb_tiled = false; /* useful for testing */
         u32 tiling_flags = 0;
+        int ret;
+        int aligned_size, size;
 
-        mode_cmd.width = surface_width;
-        mode_cmd.height = surface_height;
-
-        /* avivo can't scanout real 24bpp */
-        if ((surface_bpp == 24) && ASIC_IS_AVIVO(rdev))
-                surface_bpp = 32;
-
-        mode_cmd.bpp = surface_bpp;
         /* need to align pitch with crtc limits */
-        mode_cmd.pitch = radeon_align_pitch(rdev, mode_cmd.width, mode_cmd.bpp, fb_tiled) * ((mode_cmd.bpp + 1) / 8);
-        mode_cmd.depth = surface_depth;
+        mode_cmd->pitch = radeon_align_pitch(rdev, mode_cmd->width, mode_cmd->bpp, fb_tiled) * ((mode_cmd->bpp + 1) / 8);
 
-        size = mode_cmd.pitch * mode_cmd.height;
+        size = mode_cmd->pitch * mode_cmd->height;
         aligned_size = ALIGN(size, PAGE_SIZE);
-
         ret = radeon_gem_object_create(rdev, aligned_size, 0,
-                        RADEON_GEM_DOMAIN_VRAM,
-                        false, ttm_bo_type_kernel,
-                        &gobj);
+                                       RADEON_GEM_DOMAIN_VRAM,
+                                       false, ttm_bo_type_kernel,
+                                       &gobj);
         if (ret) {
-                printk(KERN_ERR "failed to allocate framebuffer (%d %d)\n",
-                       surface_width, surface_height);
-                ret = -ENOMEM;
-                goto out;
+                printk(KERN_ERR "failed to allocate framebuffer (%d)\n",
+                       aligned_size);
+                return -ENOMEM;
         }
         rbo = gobj->driver_private;
 
@@ -183,7 +131,7 @@ int radeonfb_create(struct drm_device *dev,
                 tiling_flags = RADEON_TILING_MACRO;
 
 #ifdef __BIG_ENDIAN
-        switch (mode_cmd.bpp) {
+        switch (mode_cmd->bpp) {
         case 32:
                 tiling_flags |= RADEON_TILING_SWAP_32BIT;
                 break;
@@ -196,57 +144,81 @@ int radeonfb_create(struct drm_device *dev,
 
         if (tiling_flags) {
                 ret = radeon_bo_set_tiling_flags(rbo,
-                                        tiling_flags | RADEON_TILING_SURFACE,
-                                        mode_cmd.pitch);
+                                                 tiling_flags | RADEON_TILING_SURFACE,
+                                                 mode_cmd->pitch);
                 if (ret)
                         dev_err(rdev->dev, "FB failed to set tiling flags\n");
         }
-        mutex_lock(&rdev->ddev->struct_mutex);
-        fb = radeon_framebuffer_create(rdev->ddev, &mode_cmd, gobj);
-        if (fb == NULL) {
-                DRM_ERROR("failed to allocate fb.\n");
-                ret = -ENOMEM;
-                goto out_unref;
-        }
+
+
         ret = radeon_bo_reserve(rbo, false);
         if (unlikely(ret != 0))
                 goto out_unref;
-        ret = radeon_bo_pin(rbo, RADEON_GEM_DOMAIN_VRAM, &fb_gpuaddr);
+        ret = radeon_bo_pin(rbo, RADEON_GEM_DOMAIN_VRAM, NULL);
         if (ret) {
                 radeon_bo_unreserve(rbo);
                 goto out_unref;
         }
         if (fb_tiled)
                 radeon_bo_check_tiling(rbo, 0, 0);
-        ret = radeon_bo_kmap(rbo, &fbptr);
+        ret = radeon_bo_kmap(rbo, NULL);
         radeon_bo_unreserve(rbo);
         if (ret) {
                 goto out_unref;
         }
 
-        list_add(&fb->filp_head, &rdev->ddev->mode_config.fb_kernel_list);
+        *gobj_p = gobj;
+        return 0;
+out_unref:
+        radeonfb_destroy_pinned_object(gobj);
+        *gobj_p = NULL;
+        return ret;
+}
+
+static int radeonfb_create(struct radeon_fbdev *rfbdev,
+                           struct drm_fb_helper_surface_size *sizes)
+{
+        struct radeon_device *rdev = rfbdev->rdev;
+        struct fb_info *info;
+        struct drm_framebuffer *fb = NULL;
+        struct drm_mode_fb_cmd mode_cmd;
+        struct drm_gem_object *gobj = NULL;
+        struct radeon_bo *rbo = NULL;
+        struct device *device = &rdev->pdev->dev;
+        int ret;
+        unsigned long tmp;
+
+        mode_cmd.width = sizes->surface_width;
+        mode_cmd.height = sizes->surface_height;
+
+        /* avivo can't scanout real 24bpp */
+        if ((sizes->surface_bpp == 24) && ASIC_IS_AVIVO(rdev))
+                sizes->surface_bpp = 32;
+
+        mode_cmd.bpp = sizes->surface_bpp;
+        mode_cmd.depth = sizes->surface_depth;
 
-        *fb_p = fb;
-        rfb = to_radeon_framebuffer(fb);
-        rdev->fbdev_rfb = rfb;
-        rdev->fbdev_rbo = rbo;
+        ret = radeonfb_create_pinned_object(rfbdev, &mode_cmd, &gobj);
+        rbo = gobj->driver_private;
 
-        info = framebuffer_alloc(sizeof(struct radeon_fb_device), device);
+        /* okay we have an object now allocate the framebuffer */
+        info = framebuffer_alloc(0, device);
         if (info == NULL) {
                 ret = -ENOMEM;
                 goto out_unref;
         }
 
-        rdev->fbdev_info = info;
-        rfbdev = info->par;
-        rfbdev->helper.funcs = &radeon_fb_helper_funcs;
-        rfbdev->helper.dev = dev;
-        ret = drm_fb_helper_init_crtc_count(&rfbdev->helper, rdev->num_crtc,
-                                            RADEONFB_CONN_LIMIT);
-        if (ret)
-                goto out_unref;
+        info->par = rfbdev;
 
-        memset_io(fbptr, 0x0, aligned_size);
+        radeon_framebuffer_init(rdev->ddev, &rfbdev->rfb, &mode_cmd, gobj);
+
+        fb = &rfbdev->rfb.base;
+
+        /* setup helper */
+        rfbdev->helper.fb = fb;
+        rfbdev->helper.fbdev = info;
+
+        memset_io(rbo->kptr, 0x0, radeon_bo_size(rbo));
 
         strcpy(info->fix.id, "radeondrmfb");
 
@@ -255,13 +227,13 @@ int radeonfb_create(struct drm_device *dev,
         info->flags = FBINFO_DEFAULT;
         info->fbops = &radeonfb_ops;
 
-        tmp = fb_gpuaddr - rdev->mc.vram_start;
+        tmp = radeon_bo_gpu_offset(rbo) - rdev->mc.vram_start;
         info->fix.smem_start = rdev->mc.aper_base + tmp;
-        info->fix.smem_len = size;
-        info->screen_base = fbptr;
-        info->screen_size = size;
+        info->fix.smem_len = radeon_bo_size(rbo);
+        info->screen_base = rbo->kptr;
+        info->screen_size = radeon_bo_size(rbo);
 
-        drm_fb_helper_fill_var(info, fb, fb_width, fb_height);
+        drm_fb_helper_fill_var(info, &rfbdev->helper, sizes->fb_width, sizes->fb_height);
 
         /* setup aperture base/size for vesafb takeover */
         info->aperture_base = rdev->ddev->mode_config.fb_base;
@@ -274,44 +246,55 @@ int radeonfb_create(struct drm_device *dev,
         info->pixmap.access_align = 32;
         info->pixmap.flags = FB_PIXMAP_SYSTEM;
         info->pixmap.scan_align = 1;
+
         if (info->screen_base == NULL) {
                 ret = -ENOSPC;
                 goto out_unref;
         }
+
+        ret = fb_alloc_cmap(&info->cmap, 256, 0);
+        if (ret) {
+                ret = -ENOMEM;
+                goto out_unref;
+        }
+
         DRM_INFO("fb mappable at 0x%lX\n",  info->fix.smem_start);
         DRM_INFO("vram apper at 0x%lX\n",  (unsigned long)rdev->mc.aper_base);
-        DRM_INFO("size %lu\n", (unsigned long)size);
+        DRM_INFO("size %lu\n", (unsigned long)radeon_bo_size(rbo));
         DRM_INFO("fb depth is %d\n", fb->depth);
         DRM_INFO("   pitch is %d\n", fb->pitch);
 
-        fb->fbdev = info;
-        rfbdev->rfb = rfb;
-        rfbdev->rdev = rdev;
-
-        mutex_unlock(&rdev->ddev->struct_mutex);
         vga_switcheroo_client_fb_set(rdev->ddev->pdev, info);
         return 0;
 
 out_unref:
         if (rbo) {
-                ret = radeon_bo_reserve(rbo, false);
-                if (likely(ret == 0)) {
-                        radeon_bo_kunmap(rbo);
-                        radeon_bo_unreserve(rbo);
-                }
+
         }
         if (fb && ret) {
-                list_del(&fb->filp_head);
                 drm_gem_object_unreference(gobj);
                 drm_framebuffer_cleanup(fb);
                 kfree(fb);
         }
-        drm_gem_object_unreference(gobj);
-        mutex_unlock(&rdev->ddev->struct_mutex);
-out:
         return ret;
 }
 
+static int radeon_fb_find_or_create_single(struct drm_fb_helper *helper,
+                                           struct drm_fb_helper_surface_size *sizes)
+{
+        struct radeon_fbdev *rfbdev = (struct radeon_fbdev *)helper;
+        int new_fb = 0;
+        int ret;
+
+        if (!helper->fb) {
+                ret = radeonfb_create(rfbdev, sizes);
+                if (ret)
+                        return ret;
+                new_fb = 1;
+        }
+        return new_fb;
+}
+
 static char *mode_option;
 int radeon_parse_options(char *options)
 {
@@ -328,46 +311,111 @@ int radeon_parse_options(char *options)
         return 0;
 }
 
-int radeonfb_probe(struct drm_device *dev)
+void radeonfb_hotplug(struct drm_device *dev, bool polled)
 {
         struct radeon_device *rdev = dev->dev_private;
-        int bpp_sel = 32;
 
-        /* select 8 bpp console on RN50 or 16MB cards */
-        if (ASIC_IS_RN50(rdev) || rdev->mc.real_vram_size <= (32*1024*1024))
-                bpp_sel = 8;
+        drm_helper_fb_hpd_irq_event(&rdev->mode_info.rfbdev->helper);
+}
 
-        return drm_fb_helper_single_fb_probe(dev, bpp_sel, &radeonfb_create);
+static void radeon_fb_output_status_changed(struct drm_fb_helper *fb_helper)
+{
+        drm_helper_fb_hotplug_event(fb_helper, true);
 }
 
-int radeonfb_remove(struct drm_device *dev, struct drm_framebuffer *fb)
+static int radeon_fbdev_destroy(struct drm_device *dev, struct radeon_fbdev *rfbdev)
 {
         struct fb_info *info;
-        struct radeon_framebuffer *rfb = to_radeon_framebuffer(fb);
+        struct radeon_framebuffer *rfb = &rfbdev->rfb;
         struct radeon_bo *rbo;
         int r;
 
-        if (!fb) {
-                return -EINVAL;
+        if (rfbdev->helper.fbdev) {
+                info = rfbdev->helper.fbdev;
+
+                unregister_framebuffer(info);
+                if (info->cmap.len)
+                        fb_dealloc_cmap(&info->cmap);
+                framebuffer_release(info);
         }
-        info = fb->fbdev;
-        if (info) {
-                struct radeon_fb_device *rfbdev = info->par;
+
+        if (rfb->obj) {
                 rbo = rfb->obj->driver_private;
-                unregister_framebuffer(info);
                 r = radeon_bo_reserve(rbo, false);
                 if (likely(r == 0)) {
                         radeon_bo_kunmap(rbo);
                         radeon_bo_unpin(rbo);
                         radeon_bo_unreserve(rbo);
                 }
-                drm_fb_helper_free(&rfbdev->helper);
-                framebuffer_release(info);
+                drm_gem_object_unreference_unlocked(rfb->obj);
         }
+        drm_fb_helper_fini(&rfbdev->helper);
+        drm_framebuffer_cleanup(&rfb->base);
 
-        printk(KERN_INFO "unregistered panic notifier\n");
+        return 0;
+}
 
+static struct drm_fb_helper_funcs radeon_fb_helper_funcs = {
+        .gamma_set = radeon_crtc_fb_gamma_set,
+        .gamma_get = radeon_crtc_fb_gamma_get,
+        .fb_probe = radeon_fb_find_or_create_single,
+        .fb_output_status_changed = radeon_fb_output_status_changed,
+};
+
+int radeon_fbdev_init(struct radeon_device *rdev)
+{
+        struct radeon_fbdev *rfbdev;
+        int bpp_sel = 32;
+
+        /* select 8 bpp console on RN50 or 16MB cards */
+        if (ASIC_IS_RN50(rdev) || rdev->mc.real_vram_size <= (32*1024*1024))
+                bpp_sel = 8;
+
+        rfbdev = kzalloc(sizeof(struct radeon_fbdev), GFP_KERNEL);
+        if (!rfbdev)
+                return -ENOMEM;
+
+        rfbdev->rdev = rdev;
+        rdev->mode_info.rfbdev = rfbdev;
+        rfbdev->helper.funcs = &radeon_fb_helper_funcs;
+
+        drm_fb_helper_init(rdev->ddev, &rfbdev->helper,
+                           rdev->num_crtc,
+                           RADEONFB_CONN_LIMIT, true);
+        drm_fb_helper_single_add_all_connectors(&rfbdev->helper);
+        drm_fb_helper_initial_config(&rfbdev->helper, bpp_sel);
         return 0;
+
+}
+
+void radeon_fbdev_fini(struct radeon_device *rdev)
+{
+        if (!rdev->mode_info.rfbdev)
+                return;
+
+        radeon_fbdev_destroy(rdev->ddev, rdev->mode_info.rfbdev);
+        kfree(rdev->mode_info.rfbdev);
+        rdev->mode_info.rfbdev = NULL;
+}
+
+void radeon_fbdev_set_suspend(struct radeon_device *rdev, int state)
+{
+        fb_set_suspend(rdev->mode_info.rfbdev->helper.fbdev, state);
+}
+
+int radeon_fbdev_total_size(struct radeon_device *rdev)
+{
+        struct radeon_bo *robj;
+        int size = 0;
+
+        robj = rdev->mode_info.rfbdev->rfb.obj->driver_private;
+        size += radeon_bo_size(robj);
+        return size;
+}
+
+bool radeon_fbdev_robj_is_fb(struct radeon_device *rdev, struct radeon_bo *robj)
+{
+        if (robj == rdev->mode_info.rfbdev->rfb.obj->driver_private)
+                return true;
+        return false;
 }
-EXPORT_SYMBOL(radeonfb_remove);
-MODULE_LICENSE("GPL");
diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon/radeon_gem.c
index ef92d147d8f0..28dd3e1b9c3a 100644
--- a/drivers/gpu/drm/radeon/radeon_gem.c
+++ b/drivers/gpu/drm/radeon/radeon_gem.c
@@ -158,8 +158,7 @@ int radeon_gem_info_ioctl(struct drm_device *dev, void *data,
         args->vram_visible = rdev->mc.real_vram_size;
         if (rdev->stollen_vga_memory)
                 args->vram_visible -= radeon_bo_size(rdev->stollen_vga_memory);
-        if (rdev->fbdev_rbo)
-                args->vram_visible -= radeon_bo_size(rdev->fbdev_rbo);
+        args->vram_visible -= radeon_fbdev_total_size(rdev);
         args->gart_size = rdev->mc.gtt_size - rdev->cp.ring_size - 4096 -
                 RADEON_IB_POOL_SIZE*64*1024;
         return 0;
diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c b/drivers/gpu/drm/radeon/radeon_irq_kms.c
index a212041e8b0b..a95907aa7eae 100644
--- a/drivers/gpu/drm/radeon/radeon_irq_kms.c
+++ b/drivers/gpu/drm/radeon/radeon_irq_kms.c
@@ -55,6 +55,8 @@ static void radeon_hotplug_work_func(struct work_struct *work)
                         radeon_connector_hotplug(connector);
         }
         /* Just fire off a uevent and let userspace tell us what to do */
+        radeonfb_hotplug(dev, false);
+
         drm_sysfs_hotplug_event(dev);
 }
 
diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h
index 0b8e32776b10..4a086c09e117 100644
--- a/drivers/gpu/drm/radeon/radeon_mode.h
+++ b/drivers/gpu/drm/radeon/radeon_mode.h
@@ -39,6 +39,7 @@
 #include <linux/i2c-algo-bit.h>
 #include "radeon_fixed.h"
 
+struct radeon_bo;
 struct radeon_device;
 
 #define to_radeon_crtc(x) container_of(x, struct radeon_crtc, base)
@@ -202,6 +203,8 @@ enum radeon_dvo_chip {
         DVO_SIL1178,
 };
 
+struct radeon_fbdev;
+
 struct radeon_mode_info {
         struct atom_context *atom_context;
         struct card_info *atom_card_info;
@@ -218,6 +221,9 @@ struct radeon_mode_info {
         struct drm_property *tmds_pll_property;
         /* hardcoded DFP edid from BIOS */
         struct edid *bios_hardcoded_edid;
+
+        /* pointer to fbdev info structure */
+        struct radeon_fbdev *rfbdev;
 };
 
 #define MAX_H_CODE_TIMING_LEN 32
@@ -532,11 +538,10 @@ extern void radeon_crtc_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green,
                                      u16 blue, int regno);
 extern void radeon_crtc_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green,
                                      u16 *blue, int regno);
-struct drm_framebuffer *radeon_framebuffer_create(struct drm_device *dev,
-                                                  struct drm_mode_fb_cmd *mode_cmd,
-                                                  struct drm_gem_object *obj);
-
-int radeonfb_probe(struct drm_device *dev);
+void radeon_framebuffer_init(struct drm_device *dev,
+                             struct radeon_framebuffer *rfb,
+                             struct drm_mode_fb_cmd *mode_cmd,
+                             struct drm_gem_object *obj);
 
 int radeonfb_remove(struct drm_device *dev, struct drm_framebuffer *fb);
 bool radeon_get_legacy_connector_info_from_bios(struct drm_device *dev);
@@ -573,4 +578,12 @@ void radeon_legacy_tv_adjust_pll2(struct drm_encoder *encoder,
 void radeon_legacy_tv_mode_set(struct drm_encoder *encoder,
                                struct drm_display_mode *mode,
                                struct drm_display_mode *adjusted_mode);
+
+/* fbdev layer */
+int radeon_fbdev_init(struct radeon_device *rdev);
+void radeon_fbdev_fini(struct radeon_device *rdev);
+void radeon_fbdev_set_suspend(struct radeon_device *rdev, int state);
+int radeon_fbdev_total_size(struct radeon_device *rdev);
+bool radeon_fbdev_robj_is_fb(struct radeon_device *rdev, struct radeon_bo *robj);
+void radeonfb_hotplug(struct drm_device *dev, bool polled);
 #endif