drm/radeon: use radeon device for request firmware

Avoid creating temporary platform device that will lead to issue
when several radeon gpu are in same computer. Instead directly use
the radeon device for requesting firmware.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Jerome Glisse <jglisse@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

1 files changed, 6 insertions, 17 deletions

diff --git a/drivers/gpu/drm/radeon/si.c b/drivers/gpu/drm/radeon/si.c
index 234906709067..f305768c3dfa 100644
--- a/drivers/gpu/drm/radeon/si.c
+++ b/drivers/gpu/drm/radeon/si.c
@@ -22,7 +22,6 @@
  * Authors: Alex Deucher
  */
 #include <linux/firmware.h>
-#include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/module.h>
 #include <drm/drmP.h>
@@ -1541,7 +1540,6 @@ static int si_mc_load_microcode(struct radeon_device *rdev)
 
 static int si_init_microcode(struct radeon_device *rdev)
 {
-        struct platform_device *pdev;
         const char *chip_name;
         const char *rlc_chip_name;
         size_t pfp_req_size, me_req_size, ce_req_size, rlc_req_size, mc_req_size;
@@ -1551,13 +1549,6 @@ static int si_init_microcode(struct radeon_device *rdev)
 
         DRM_DEBUG("\n");
 
-        pdev = platform_device_register_simple("radeon_cp", 0, NULL, 0);
-        err = IS_ERR(pdev);
-        if (err) {
-                printk(KERN_ERR "radeon_cp: Failed to register firmware\n");
-                return -EINVAL;
-        }
-
         switch (rdev->family) {
         case CHIP_TAHITI:
                 chip_name = "TAHITI";
@@ -1615,7 +1606,7 @@ static int si_init_microcode(struct radeon_device *rdev)
         DRM_INFO("Loading %s Microcode\n", chip_name);
 
         snprintf(fw_name, sizeof(fw_name), "radeon/%s_pfp.bin", chip_name);
-        err = request_firmware(&rdev->pfp_fw, fw_name, &pdev->dev);
+        err = request_firmware(&rdev->pfp_fw, fw_name, rdev->dev);
         if (err)
                 goto out;
         if (rdev->pfp_fw->size != pfp_req_size) {
@@ -1627,7 +1618,7 @@ static int si_init_microcode(struct radeon_device *rdev)
         }
 
         snprintf(fw_name, sizeof(fw_name), "radeon/%s_me.bin", chip_name);
-        err = request_firmware(&rdev->me_fw, fw_name, &pdev->dev);
+        err = request_firmware(&rdev->me_fw, fw_name, rdev->dev);
         if (err)
                 goto out;
         if (rdev->me_fw->size != me_req_size) {
@@ -1638,7 +1629,7 @@ static int si_init_microcode(struct radeon_device *rdev)
         }
 
         snprintf(fw_name, sizeof(fw_name), "radeon/%s_ce.bin", chip_name);
-        err = request_firmware(&rdev->ce_fw, fw_name, &pdev->dev);
+        err = request_firmware(&rdev->ce_fw, fw_name, rdev->dev);
         if (err)
                 goto out;
         if (rdev->ce_fw->size != ce_req_size) {
@@ -1649,7 +1640,7 @@ static int si_init_microcode(struct radeon_device *rdev)
         }
 
         snprintf(fw_name, sizeof(fw_name), "radeon/%s_rlc.bin", rlc_chip_name);
-        err = request_firmware(&rdev->rlc_fw, fw_name, &pdev->dev);
+        err = request_firmware(&rdev->rlc_fw, fw_name, rdev->dev);
         if (err)
                 goto out;
         if (rdev->rlc_fw->size != rlc_req_size) {
@@ -1660,7 +1651,7 @@ static int si_init_microcode(struct radeon_device *rdev)
         }
 
         snprintf(fw_name, sizeof(fw_name), "radeon/%s_mc.bin", chip_name);
-        err = request_firmware(&rdev->mc_fw, fw_name, &pdev->dev);
+        err = request_firmware(&rdev->mc_fw, fw_name, rdev->dev);
         if (err)
                 goto out;
         if (rdev->mc_fw->size != mc_req_size) {
@@ -1671,7 +1662,7 @@ static int si_init_microcode(struct radeon_device *rdev)
         }
 
         snprintf(fw_name, sizeof(fw_name), "radeon/%s_smc.bin", chip_name);
-        err = request_firmware(&rdev->smc_fw, fw_name, &pdev->dev);
+        err = request_firmware(&rdev->smc_fw, fw_name, rdev->dev);
         if (err)
                 goto out;
         if (rdev->smc_fw->size != smc_req_size) {
@@ -1682,8 +1673,6 @@ static int si_init_microcode(struct radeon_device *rdev)
         }
 
 out:
-        platform_device_unregister(pdev);
-
         if (err) {
                 if (err != -EINVAL)
                         printk(KERN_ERR