diff options
author | Dave Airlie <airlied@redhat.com> | 2014-04-17 23:12:04 -0400 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2014-04-17 23:12:04 -0400 |
commit | d62c3e7a73f87defb17651109a55d36adedadc6f (patch) | |
tree | 76de169974960e3dfc46de2829e357c8cf1539fc /drivers/gpu/drm/omapdrm/omap_plane.c | |
parent | 90e48970c206a2dd7810a5d3dcf07effab956919 (diff) | |
parent | f2d022aa421ca903a30f63b04528064b7eceaf5e (diff) |
Merge tag 'omapdrm-fixes-3.15' of git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux into drm-next
Fixes for omapdrm, some of which were already present in 3.14, and some which
appeared in 3.15-rc1:
- fixes for primary-plane handling which caused crashes
- fix all kinds of uninit issues which prevented from unloading the omapdrm
module.
- fixes for HDMI enable/disable issues
* tag 'omapdrm-fixes-3.15' of git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux:
drm/omap: fix the handling of fb ref counts
drm/omap: protect omap_crtc's event with event_lock spinlock
drm/omap: Use old_fb to synchronize between successive page flips
drm/omap: Fix crash when using LCD3 overlay manager
drm/omap: gem sync: wait on correct events
drm/omap: Fix memory leak in omap_gem_op_async
drm/omap: remove warn from debugfs
drm/omap: remove extra plane->destroy from crtc destroy
drm/omap: print warning when rotating non-TILER fb
drm/omap: fix missing unref to fb's buf object
drm/omap: fix plane rotation
drm/omap: fix enabling/disabling of video pipeline
drm/omap: fix missing disable for unused encoder
drm/omap: fix race issue when unloading omapdrm
drm/omap: fix DMM driver (un)registration
drm/omap: fix uninit order in pdev_remove()
drm/omap: fix output enable/disable sequence
Diffstat (limited to 'drivers/gpu/drm/omapdrm/omap_plane.c')
-rw-r--r-- | drivers/gpu/drm/omapdrm/omap_plane.c | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c index 046d5e660c04..3cf31ee59aac 100644 --- a/drivers/gpu/drm/omapdrm/omap_plane.c +++ b/drivers/gpu/drm/omapdrm/omap_plane.c | |||
@@ -225,6 +225,11 @@ int omap_plane_mode_set(struct drm_plane *plane, | |||
225 | omap_plane->apply_done_cb.arg = arg; | 225 | omap_plane->apply_done_cb.arg = arg; |
226 | } | 226 | } |
227 | 227 | ||
228 | if (plane->fb) | ||
229 | drm_framebuffer_unreference(plane->fb); | ||
230 | |||
231 | drm_framebuffer_reference(fb); | ||
232 | |||
228 | plane->fb = fb; | 233 | plane->fb = fb; |
229 | plane->crtc = crtc; | 234 | plane->crtc = crtc; |
230 | 235 | ||
@@ -241,10 +246,13 @@ static int omap_plane_update(struct drm_plane *plane, | |||
241 | struct omap_plane *omap_plane = to_omap_plane(plane); | 246 | struct omap_plane *omap_plane = to_omap_plane(plane); |
242 | omap_plane->enabled = true; | 247 | omap_plane->enabled = true; |
243 | 248 | ||
244 | if (plane->fb) | 249 | /* omap_plane_mode_set() takes adjusted src */ |
245 | drm_framebuffer_unreference(plane->fb); | 250 | switch (omap_plane->win.rotation & 0xf) { |
246 | 251 | case BIT(DRM_ROTATE_90): | |
247 | drm_framebuffer_reference(fb); | 252 | case BIT(DRM_ROTATE_270): |
253 | swap(src_w, src_h); | ||
254 | break; | ||
255 | } | ||
248 | 256 | ||
249 | return omap_plane_mode_set(plane, crtc, fb, | 257 | return omap_plane_mode_set(plane, crtc, fb, |
250 | crtc_x, crtc_y, crtc_w, crtc_h, | 258 | crtc_x, crtc_y, crtc_w, crtc_h, |