diff options
author | Marcin Slusarz <marcin.slusarz@gmail.com> | 2012-11-25 17:04:23 -0500 |
---|---|---|
committer | Ben Skeggs <bskeggs@redhat.com> | 2012-11-28 18:58:11 -0500 |
commit | 04c8c21085e13011a2eaf3ae518ab44e23e21917 (patch) | |
tree | eb7fe589503f248555e3fc7e33d071932c78dd86 /drivers/gpu/drm/nouveau/nvc0_fence.c | |
parent | 124ea297c8f0e0a3a567af0894fdbe05caaf80ec (diff) |
drm/nouveau: unpin various bo's before destroying
These objects leak VRAM - but only on module unload.
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/nouveau/nvc0_fence.c')
-rw-r--r-- | drivers/gpu/drm/nouveau/nvc0_fence.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/gpu/drm/nouveau/nvc0_fence.c b/drivers/gpu/drm/nouveau/nvc0_fence.c index 2747baaa3c39..2a56b1b551cb 100644 --- a/drivers/gpu/drm/nouveau/nvc0_fence.c +++ b/drivers/gpu/drm/nouveau/nvc0_fence.c | |||
@@ -190,6 +190,8 @@ nvc0_fence_destroy(struct nouveau_drm *drm) | |||
190 | { | 190 | { |
191 | struct nvc0_fence_priv *priv = drm->fence; | 191 | struct nvc0_fence_priv *priv = drm->fence; |
192 | nouveau_bo_unmap(priv->bo); | 192 | nouveau_bo_unmap(priv->bo); |
193 | if (priv->bo) | ||
194 | nouveau_bo_unpin(priv->bo); | ||
193 | nouveau_bo_ref(NULL, &priv->bo); | 195 | nouveau_bo_ref(NULL, &priv->bo); |
194 | drm->fence = NULL; | 196 | drm->fence = NULL; |
195 | kfree(priv); | 197 | kfree(priv); |
@@ -219,8 +221,11 @@ nvc0_fence_create(struct nouveau_drm *drm) | |||
219 | TTM_PL_FLAG_VRAM, 0, 0, NULL, &priv->bo); | 221 | TTM_PL_FLAG_VRAM, 0, 0, NULL, &priv->bo); |
220 | if (ret == 0) { | 222 | if (ret == 0) { |
221 | ret = nouveau_bo_pin(priv->bo, TTM_PL_FLAG_VRAM); | 223 | ret = nouveau_bo_pin(priv->bo, TTM_PL_FLAG_VRAM); |
222 | if (ret == 0) | 224 | if (ret == 0) { |
223 | ret = nouveau_bo_map(priv->bo); | 225 | ret = nouveau_bo_map(priv->bo); |
226 | if (ret) | ||
227 | nouveau_bo_unpin(priv->bo); | ||
228 | } | ||
224 | if (ret) | 229 | if (ret) |
225 | nouveau_bo_ref(NULL, &priv->bo); | 230 | nouveau_bo_ref(NULL, &priv->bo); |
226 | } | 231 | } |