diff options
author | Rob Clark <robdclark@gmail.com> | 2014-11-18 14:28:43 -0500 |
---|---|---|
committer | Rob Clark <robdclark@gmail.com> | 2014-11-21 08:57:20 -0500 |
commit | 42238da8b10320420be19f056cc8e0d95cc606a3 (patch) | |
tree | 5d3a32a11f00d59b01d33d50f1b1dbcedaddca35 /drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | |
parent | 0deed25b65aaf495e36818481cfc9f58dfa5cd3f (diff) |
drm/msm/mdp5: don't use void * for opaque types
For example, use 'struct mdp5_smp *' everywhere instead of 'void *', but
only declare it as 'struct mdp5_smp;' in common headers, so the struct
body is still private. The accomplishes the desired modularity while
still letting the compiler provide some type checking for us.
Signed-off-by: Rob Clark <robdclark@gmail.com>
Diffstat (limited to 'drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c')
-rw-r--r-- | drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c index 59703faa9d13..49c10a9cd6c6 100644 --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | |||
@@ -77,7 +77,7 @@ static int mdp5_plane_disable(struct drm_plane *plane) | |||
77 | 77 | ||
78 | if (mdp5_kms) { | 78 | if (mdp5_kms) { |
79 | /* Release the memory we requested earlier from the SMP: */ | 79 | /* Release the memory we requested earlier from the SMP: */ |
80 | mdp5_smp_release(mdp5_kms->smp_priv, pipe); | 80 | mdp5_smp_release(mdp5_kms->smp, pipe); |
81 | } | 81 | } |
82 | 82 | ||
83 | /* TODO detaching now will cause us not to get the last | 83 | /* TODO detaching now will cause us not to get the last |
@@ -232,7 +232,7 @@ int mdp5_plane_mode_set(struct drm_plane *plane, | |||
232 | crtc->base.id, crtc_x, crtc_y, crtc_w, crtc_h); | 232 | crtc->base.id, crtc_x, crtc_y, crtc_w, crtc_h); |
233 | 233 | ||
234 | /* Request some memory from the SMP: */ | 234 | /* Request some memory from the SMP: */ |
235 | ret = mdp5_smp_request(mdp5_kms->smp_priv, | 235 | ret = mdp5_smp_request(mdp5_kms->smp, |
236 | mdp5_plane->pipe, fb->pixel_format, src_w); | 236 | mdp5_plane->pipe, fb->pixel_format, src_w); |
237 | if (ret) | 237 | if (ret) |
238 | return ret; | 238 | return ret; |
@@ -243,7 +243,7 @@ int mdp5_plane_mode_set(struct drm_plane *plane, | |||
243 | * would move into atomic->check_plane_state(), while updating the | 243 | * would move into atomic->check_plane_state(), while updating the |
244 | * hw would remain here: | 244 | * hw would remain here: |
245 | */ | 245 | */ |
246 | mdp5_smp_configure(mdp5_kms->smp_priv, pipe); | 246 | mdp5_smp_configure(mdp5_kms->smp, pipe); |
247 | 247 | ||
248 | if (src_w != crtc_w) { | 248 | if (src_w != crtc_w) { |
249 | config |= MDP5_PIPE_SCALE_CONFIG_SCALEX_EN; | 249 | config |= MDP5_PIPE_SCALE_CONFIG_SCALEX_EN; |
@@ -335,7 +335,7 @@ void mdp5_plane_complete_flip(struct drm_plane *plane) | |||
335 | struct mdp5_kms *mdp5_kms = get_kms(plane); | 335 | struct mdp5_kms *mdp5_kms = get_kms(plane); |
336 | enum mdp5_pipe pipe = to_mdp5_plane(plane)->pipe; | 336 | enum mdp5_pipe pipe = to_mdp5_plane(plane)->pipe; |
337 | 337 | ||
338 | mdp5_smp_commit(mdp5_kms->smp_priv, pipe); | 338 | mdp5_smp_commit(mdp5_kms->smp, pipe); |
339 | } | 339 | } |
340 | 340 | ||
341 | enum mdp5_pipe mdp5_plane_pipe(struct drm_plane *plane) | 341 | enum mdp5_pipe mdp5_plane_pipe(struct drm_plane *plane) |