diff options
author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2014-11-14 11:16:56 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-12-05 09:16:35 -0500 |
commit | 8edfbb8bfc7ef291b12f683f40de8cf274ae8ed3 (patch) | |
tree | 66188008a3caeda21a06942ed565f6640e1bd8a7 /drivers/gpu/drm/i915 | |
parent | 7bcc3777b12a05687e5080e4de3c108f35d6aec8 (diff) |
drm/i915: s/MI_STORE_DWORD_IMM_GEN8/MI_STORE_DWORD_IMM_GEN4/
MI_STORE_DWORD_IMM length has been the same ever since gen4. Rename
the define to avoid potential confusion if someone tries to use this
on pre-gen8.
Also correct the comment on MI_MEM_VIRTUAL bit. It's present on 945,g33
and 965 only.
Cc: Oscar Mateo <oscar.mateo@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
[danvet: Add USE_GGTT define for g4x+ too.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915')
-rw-r--r-- | drivers/gpu/drm/i915/i915_reg.h | 5 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_lrc.c | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index dc03facd587a..82da2323896c 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h | |||
@@ -293,8 +293,9 @@ | |||
293 | #define MI_SEMAPHORE_POLL (1<<15) | 293 | #define MI_SEMAPHORE_POLL (1<<15) |
294 | #define MI_SEMAPHORE_SAD_GTE_SDD (1<<12) | 294 | #define MI_SEMAPHORE_SAD_GTE_SDD (1<<12) |
295 | #define MI_STORE_DWORD_IMM MI_INSTR(0x20, 1) | 295 | #define MI_STORE_DWORD_IMM MI_INSTR(0x20, 1) |
296 | #define MI_STORE_DWORD_IMM_GEN8 MI_INSTR(0x20, 2) | 296 | #define MI_STORE_DWORD_IMM_GEN4 MI_INSTR(0x20, 2) |
297 | #define MI_MEM_VIRTUAL (1 << 22) /* 965+ only */ | 297 | #define MI_MEM_VIRTUAL (1 << 22) /* 945,g33,965 */ |
298 | #define MI_USE_GGTT (1 << 22) /* g4x+ */ | ||
298 | #define MI_STORE_DWORD_INDEX MI_INSTR(0x21, 1) | 299 | #define MI_STORE_DWORD_INDEX MI_INSTR(0x21, 1) |
299 | #define MI_STORE_DWORD_INDEX_SHIFT 2 | 300 | #define MI_STORE_DWORD_INDEX_SHIFT 2 |
300 | /* Official intel docs are somewhat sloppy concerning MI_LOAD_REGISTER_IMM: | 301 | /* Official intel docs are somewhat sloppy concerning MI_LOAD_REGISTER_IMM: |
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index 52e9952206d9..7986eb3e5027 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c | |||
@@ -1319,7 +1319,7 @@ static int gen8_emit_request(struct intel_ringbuffer *ringbuf) | |||
1319 | if (ret) | 1319 | if (ret) |
1320 | return ret; | 1320 | return ret; |
1321 | 1321 | ||
1322 | cmd = MI_STORE_DWORD_IMM_GEN8; | 1322 | cmd = MI_STORE_DWORD_IMM_GEN4; |
1323 | cmd |= MI_GLOBAL_GTT; | 1323 | cmd |= MI_GLOBAL_GTT; |
1324 | 1324 | ||
1325 | intel_logical_ring_emit(ringbuf, cmd); | 1325 | intel_logical_ring_emit(ringbuf, cmd); |