aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2012-09-06 16:08:34 -0400
committerDaniel Vetter <daniel.vetter@ffwll.ch>2012-09-20 08:23:09 -0400
commit172a1ae141a20f8279dfa285d99ff0541b7eb044 (patch)
tree0927ff45bca808cbff786213bbd96dd4c858814d /drivers/gpu/drm/i915
parent46b6f8149a7a631ae8789f4eaebf8c27c1279b5a (diff)
drm/i915: don't call dpms funcs after set_mode
... because our current set_mode implementation doesn't bother to adjust for the dpms state, we just forcefully update it. So stop pretending that we're better than we are and rip out this extranous call. Note that this totally confuses userspace, because the exposed connector property isn't actually updated ... Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915')
-rw-r--r--drivers/gpu/drm/i915/intel_display.c10
1 files changed, 0 insertions, 10 deletions
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 5e42a03f2685..00e8541f81ca 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7296,7 +7296,6 @@ static int intel_crtc_set_config(struct drm_mode_set *set)
7296 struct drm_mode_set save_set; 7296 struct drm_mode_set save_set;
7297 struct intel_set_config *config; 7297 struct intel_set_config *config;
7298 int ret; 7298 int ret;
7299 int i;
7300 7299
7301 BUG_ON(!set); 7300 BUG_ON(!set);
7302 BUG_ON(!set->crtc); 7301 BUG_ON(!set->crtc);
@@ -7360,15 +7359,6 @@ static int intel_crtc_set_config(struct drm_mode_set *set)
7360 ret = -EINVAL; 7359 ret = -EINVAL;
7361 goto fail; 7360 goto fail;
7362 } 7361 }
7363
7364 if (set->crtc->enabled) {
7365 DRM_DEBUG_KMS("Setting connector DPMS state to on\n");
7366 for (i = 0; i < set->num_connectors; i++) {
7367 DRM_DEBUG_KMS("\t[CONNECTOR:%d:%s] set DPMS on\n", set->connectors[i]->base.id,
7368 drm_get_connector_name(set->connectors[i]));
7369 set->connectors[i]->funcs->dpms(set->connectors[i], DRM_MODE_DPMS_ON);
7370 }
7371 }
7372 } else if (config->fb_changed) { 7362 } else if (config->fb_changed) {
7373 ret = intel_pipe_set_base(set->crtc, 7363 ret = intel_pipe_set_base(set->crtc,
7374 set->x, set->y, set->fb); 7364 set->x, set->y, set->fb);