diff options
author | Paulo Zanoni <paulo.r.zanoni@intel.com> | 2013-02-19 14:21:47 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-03-04 17:17:00 -0500 |
commit | 4f3a8bc7ba6e34403f36e600bc6f54cf0e0041e4 (patch) | |
tree | 7f2381ea438a176ead41b82484031eacc256aada /drivers/gpu/drm/i915/intel_sdvo.c | |
parent | dc0fa7181132b1fde269accc4e067b8b833f34ef (diff) |
drm/i915: rename some HDMI bit definitions
Bits used only on HDMI mode now have HDMI_ prefix instead of SDVO_.
The COLOR_FORMAT bits now have prefixes (and the 12bpc bit is for HDMI
only).
Notice that this patch uncovers a bug on the SDVO code: the
COLOR_RANGE_16_235 bit can only be used if the port is in TMDS mode,
not SDVO mode. This will have to be fixed in a later patch.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_sdvo.c')
-rw-r--r-- | drivers/gpu/drm/i915/intel_sdvo.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index eef073114f7a..63dcb760b004 100644 --- a/drivers/gpu/drm/i915/intel_sdvo.c +++ b/drivers/gpu/drm/i915/intel_sdvo.c | |||
@@ -1076,9 +1076,11 @@ static bool intel_sdvo_mode_fixup(struct drm_encoder *encoder, | |||
1076 | 1076 | ||
1077 | if (intel_sdvo->color_range_auto) { | 1077 | if (intel_sdvo->color_range_auto) { |
1078 | /* See CEA-861-E - 5.1 Default Encoding Parameters */ | 1078 | /* See CEA-861-E - 5.1 Default Encoding Parameters */ |
1079 | /* FIXME: This bit is only valid when using TMDS encoding and 8 | ||
1080 | * bit per color mode. */ | ||
1079 | if (intel_sdvo->has_hdmi_monitor && | 1081 | if (intel_sdvo->has_hdmi_monitor && |
1080 | drm_mode_cea_vic(adjusted_mode) > 1) | 1082 | drm_mode_cea_vic(adjusted_mode) > 1) |
1081 | intel_sdvo->color_range = SDVO_COLOR_RANGE_16_235; | 1083 | intel_sdvo->color_range = HDMI_COLOR_RANGE_16_235; |
1082 | else | 1084 | else |
1083 | intel_sdvo->color_range = 0; | 1085 | intel_sdvo->color_range = 0; |
1084 | } | 1086 | } |
@@ -1926,7 +1928,9 @@ intel_sdvo_set_property(struct drm_connector *connector, | |||
1926 | break; | 1928 | break; |
1927 | case INTEL_BROADCAST_RGB_LIMITED: | 1929 | case INTEL_BROADCAST_RGB_LIMITED: |
1928 | intel_sdvo->color_range_auto = false; | 1930 | intel_sdvo->color_range_auto = false; |
1929 | intel_sdvo->color_range = SDVO_COLOR_RANGE_16_235; | 1931 | /* FIXME: this bit is only valid when using TMDS |
1932 | * encoding and 8 bit per color mode. */ | ||
1933 | intel_sdvo->color_range = HDMI_COLOR_RANGE_16_235; | ||
1930 | break; | 1934 | break; |
1931 | default: | 1935 | default: |
1932 | return -EINVAL; | 1936 | return -EINVAL; |