diff options
author | Jani Nikula <jani.nikula@intel.com> | 2014-01-21 04:24:25 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-01-27 11:16:45 -0500 |
commit | d330a9530c97b8ee4704fdd7f228712029438ea9 (patch) | |
tree | 7e2c111e25a63e8d166d92cc31e8b57852e287ae /drivers/gpu/drm/i915/intel_dp.c | |
parent | 2b7e8082b258eebcff49acff040a9110ed6f2c09 (diff) |
drm/i915: move module parameters into a struct, in a new file
With 20+ module parameters, I think referring to them via a struct
improves clarity over just having a bunch of globals. While at it, move
the parameter initialization and definitions into a new file
i915_params.c to reduce clutter in i915_drv.c.
Apart from the ill-named i915_enable_rc6, i915_enable_fbc and
i915_enable_ppgtt parameters, for which we lose the "i915_" prefix
internally, the module parameters now look the same both on the kernel
command line and in code. For example, "i915.modeset".
The downsides of the change are losing static on a couple of variables
and not having the initialization and module_param_named() right next to
each other. On the other hand, all module parameters are now defined in
one place at i915_params.c. Plus you can do this to find all module
parameter references:
$ git grep "i915\." -- drivers/gpu/drm/i915
v2:
- move the definitions into a new file
- s/i915_params/i915/
- make i915_try_reset i915.reset, for consistency
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_dp.c')
-rw-r--r-- | drivers/gpu/drm/i915/intel_dp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 389eabf898ad..376089052e12 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c | |||
@@ -1725,7 +1725,7 @@ static bool intel_edp_psr_match_conditions(struct intel_dp *intel_dp) | |||
1725 | return false; | 1725 | return false; |
1726 | } | 1726 | } |
1727 | 1727 | ||
1728 | if (!i915_enable_psr) { | 1728 | if (!i915.enable_psr) { |
1729 | DRM_DEBUG_KMS("PSR disable by flag\n"); | 1729 | DRM_DEBUG_KMS("PSR disable by flag\n"); |
1730 | return false; | 1730 | return false; |
1731 | } | 1731 | } |