diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2009-09-15 16:57:34 -0400 |
---|---|---|
committer | Eric Anholt <eric@anholt.net> | 2009-11-05 17:47:08 -0500 |
commit | 02e792fbaadb75dec8e476a05b610e49908fc6a4 (patch) | |
tree | 3c813fbf64431827b0e56291c647e60443a52277 /drivers/gpu/drm/i915/i915_drv.h | |
parent | f0f8a9cecea322b215600d96cf0c1eb08343a4e9 (diff) |
drm/i915: implement drmmode overlay support v4
This implements intel overlay support for kms via a device-specific
ioctl. Thomas Hellstrom brought up the idea of a general ioctl (on
dri-devel). We've reached the conclusion that such an infrastructure
only makes sense when multiple kms overlay implementations exists,
which atm don't (and it doesn't look like this is gonna change).
Open issues:
- Runs in sync with the gpu, i.e. unnecessary waiting. I've decided
to wait on this because the hw tends to hang when changing something
in this area. I left some dummy functions as infrastructure.
- polyphase filtering uses a static table.
- uses uninterruptible sleeps. Unfortunately the alternatives may
unnecessarily wedged the hw if/when we timeout too early (and
userspace only overloaded the batch buffers with stuff worth a few
secs of gpu time).
Changes since v1:
- fix off-by-one misconception on my side. This fixes fullscreen
playback.
Changes since v2:
- add underrun detection as spec'ed for i965.
- flush caches properly, fixing visual corruptions.
Changes since v4:
- fix up cache flushing of overlay memory regs.
- killed require_pipe_a logic - it hangs the chip.
Tested-By: diego.abelenda@gmail.com (on a 865G)
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
[anholt: Resolved against the MADVISE ioctl going in before this one]
Signed-off-by: Eric Anholt <eric@anholt.net>
Diffstat (limited to 'drivers/gpu/drm/i915/i915_drv.h')
-rw-r--r-- | drivers/gpu/drm/i915/i915_drv.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 4e8b26161a74..ce03fd5b3f5b 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h | |||
@@ -170,6 +170,8 @@ struct drm_i915_display_funcs { | |||
170 | /* clock gating init */ | 170 | /* clock gating init */ |
171 | }; | 171 | }; |
172 | 172 | ||
173 | struct intel_overlay; | ||
174 | |||
173 | typedef struct drm_i915_private { | 175 | typedef struct drm_i915_private { |
174 | struct drm_device *dev; | 176 | struct drm_device *dev; |
175 | 177 | ||
@@ -241,6 +243,9 @@ typedef struct drm_i915_private { | |||
241 | 243 | ||
242 | struct intel_opregion opregion; | 244 | struct intel_opregion opregion; |
243 | 245 | ||
246 | /* overlay */ | ||
247 | struct intel_overlay *overlay; | ||
248 | |||
244 | /* LVDS info */ | 249 | /* LVDS info */ |
245 | int backlight_duty_cycle; /* restore backlight to this value */ | 250 | int backlight_duty_cycle; /* restore backlight to this value */ |
246 | bool panel_wants_dither; | 251 | bool panel_wants_dither; |