drm: add atomic properties

Once a driver is using atomic helpers for modeset, the next step is to
switch over to atomic properties.  To do this, make sure that any
modeset objects have their ->atomic_{get,set}_property() vfuncs suitably
populated if they have custom properties (you did already remember to
plug in atomic-helper func for the legacy ->set_property() vfuncs,
right?), and then set DRIVER_ATOMIC bit in driver_features flag.

A new cap is introduced, DRM_CLIENT_CAP_ATOMIC, for the purposes of
shielding legacy userspace from atomic properties.  Mostly for the
benefit of legacy DDX drivers that do silly things like getting/setting
each property at startup (since some of the new atomic properties will
be able to trigger modeset).

Signed-off-by: Rob Clark <robdclark@gmail.com>
[danvet: Squash in fixup patch to check for DRM_MODE_PROP_ATOMIC
instaed of the CAP define when filtering properties. Reported by
Tvrtko Uruslin, acked by Rob.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

1 files changed, 24 insertions, 7 deletions

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index f5f34d0d7c20..3bac877228fa 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -38,6 +38,7 @@
 #include <drm/drm_edid.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_modeset_lock.h>
+#include <drm/drm_atomic.h>
 
 #include "drm_crtc_internal.h"
 #include "drm_internal.h"
@@ -1992,19 +1993,25 @@ static struct drm_encoder *drm_connector_get_encoder(struct drm_connector *conne
 }
 
 /* helper for getconnector and getproperties ioctls */
-static int get_properties(struct drm_mode_object *obj,
+static int get_properties(struct drm_mode_object *obj, bool atomic,
                 uint32_t __user *prop_ptr, uint64_t __user *prop_values,
                 uint32_t *arg_count_props)
 {
-        int props_count = obj->properties->count;
-        int i, ret, copied = 0;
+        int props_count;
+        int i, ret, copied;
+
+        props_count = obj->properties->count;
+        if (!atomic)
+                props_count -= obj->properties->atomic_count;
 
         if ((*arg_count_props >= props_count) && props_count) {
-                copied = 0;
-                for (i = 0; i < props_count; i++) {
+                for (i = 0, copied = 0; copied < props_count; i++) {
                         struct drm_property *prop = obj->properties->properties[i];
                         uint64_t val;
 
+                        if ((prop->flags & DRM_MODE_PROP_ATOMIC) && !atomic)
+                                continue;
+
                         ret = drm_object_property_get_value(obj, prop, &val);
                         if (ret)
                                 return ret;
@@ -2118,7 +2125,7 @@ int drm_mode_getconnector(struct drm_device *dev, void *data,
         }
         out_resp->count_modes = mode_count;
 
-        ret = get_properties(&connector->base,
+        ret = get_properties(&connector->base, file_priv->atomic,
                         (uint32_t __user *)(unsigned long)(out_resp->props_ptr),
                         (uint64_t __user *)(unsigned long)(out_resp->prop_values_ptr),
                         &out_resp->count_props);
@@ -3832,6 +3839,8 @@ void drm_object_attach_property(struct drm_mode_object *obj,
         obj->properties->properties[count] = property;
         obj->properties->values[count] = init_val;
         obj->properties->count++;
+        if (property->flags & DRM_MODE_PROP_ATOMIC)
+                obj->properties->atomic_count++;
 }
 EXPORT_SYMBOL(drm_object_attach_property);
 
@@ -3883,6 +3892,14 @@ int drm_object_property_get_value(struct drm_mode_object *obj,
 {
         int i;
 
+        /* read-only properties bypass atomic mechanism and still store
+         * their value in obj->properties->values[].. mostly to avoid
+         * having to deal w/ EDID and similar props in atomic paths:
+         */
+        if (drm_core_check_feature(property->dev, DRIVER_ATOMIC) &&
+                        !(property->flags & DRM_MODE_PROP_IMMUTABLE))
+                return drm_atomic_get_property(obj, property, val);
+
         for (i = 0; i < obj->properties->count; i++) {
                 if (obj->properties->properties[i] == property) {
                         *val = obj->properties->values[i];
@@ -4413,7 +4430,7 @@ int drm_mode_obj_get_properties_ioctl(struct drm_device *dev, void *data,
                 goto out;
         }
 
-        ret = get_properties(obj,
+        ret = get_properties(obj, file_priv->atomic,
                         (uint32_t __user *)(unsigned long)(arg->props_ptr),
                         (uint64_t __user *)(unsigned long)(arg->prop_values_ptr),
                         &arg->count_props);