drm: Check in setcrtc if the primary plane supports the fb pixel format

Drivers implementing the universal planes API report the list of
supported pixel formats for the primary plane. Make sure the fb passed
to the setcrtc ioctl is compatible.

Drivers not implementing the universal planes API will have no format
reported for the primary plane, skip the check in that case.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

1 files changed, 17 insertions, 0 deletions

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 447db50e6838..5785336695ca 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -2798,6 +2798,23 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data,
 
                 drm_mode_set_crtcinfo(mode, CRTC_INTERLACE_HALVE_V);
 
+                /*
+                 * Check whether the primary plane supports the fb pixel format.
+                 * Drivers not implementing the universal planes API use a
+                 * default formats list provided by the DRM core which doesn't
+                 * match real hardware capabilities. Skip the check in that
+                 * case.
+                 */
+                if (!crtc->primary->format_default) {
+                        ret = drm_plane_check_pixel_format(crtc->primary,
+                                                           fb->pixel_format);
+                        if (ret) {
+                                DRM_DEBUG_KMS("Invalid pixel format %s\n",
+                                        drm_get_format_name(fb->pixel_format));
+                                goto out;
+                        }
+                }
+
                 ret = drm_crtc_check_viewport(crtc, crtc_req->x, crtc_req->y,
                                               mode, fb);
                 if (ret)