diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-05 04:11:16 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-22 09:39:10 -0400 |
commit | 183c1a32cf7175dfaa9e8889a6e9eb330ddc3c75 (patch) | |
tree | a3625e38b653509b79256d5a4d62182e563cb86b /drivers/gpu/drm/ast | |
parent | eb649a614d3a2204825cc41f32a7ae79ff74da35 (diff) |
drm/ast: Remove unecessary NULL check in gem_free
The ->gem_free_object never gets called with a NULL pointer, the check
is redundant. Also checking after the upcast allows compilers to elide
it anyway.
Spotted by coverity.
v2: Fix patch subject.
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/ast')
-rw-r--r-- | drivers/gpu/drm/ast/ast_main.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index 38941a656312..01bf9e730acf 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c | |||
@@ -418,8 +418,6 @@ void ast_gem_free_object(struct drm_gem_object *obj) | |||
418 | { | 418 | { |
419 | struct ast_bo *ast_bo = gem_to_ast_bo(obj); | 419 | struct ast_bo *ast_bo = gem_to_ast_bo(obj); |
420 | 420 | ||
421 | if (!ast_bo) | ||
422 | return; | ||
423 | ast_bo_unref(&ast_bo); | 421 | ast_bo_unref(&ast_bo); |
424 | } | 422 | } |
425 | 423 | ||