diff options
| author | Vladimir Zapolskiy <vz@mleia.com> | 2015-03-28 22:37:20 -0400 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2015-04-08 03:53:57 -0400 |
| commit | 33c07b46774219ceaa2e6650413aa4d2cd6d6dd0 (patch) | |
| tree | 21cd7c318b1be036f285db95a0c50a2f3b0b0be7 /drivers/gpio | |
| parent | cbfb3ea7f8c8da2e12d6d5aeca6d483de4297427 (diff) | |
gpio: x-gene: fix devm_ioremap_resource() check
devm_ioremap_resource() returns IOMEM_ERR_PTR() and it never
returns NULL, fix the check to prevent access to invalid
virtual address.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-xgene-sb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c index b6a15c39293e..fb9d29a5d584 100644 --- a/drivers/gpio/gpio-xgene-sb.c +++ b/drivers/gpio/gpio-xgene-sb.c | |||
| @@ -93,7 +93,7 @@ static int xgene_gpio_sb_probe(struct platform_device *pdev) | |||
| 93 | 93 | ||
| 94 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | 94 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| 95 | regs = devm_ioremap_resource(&pdev->dev, res); | 95 | regs = devm_ioremap_resource(&pdev->dev, res); |
| 96 | if (!regs) | 96 | if (IS_ERR(regs)) |
| 97 | return PTR_ERR(regs); | 97 | return PTR_ERR(regs); |
| 98 | 98 | ||
| 99 | ret = bgpio_init(&priv->bgc, &pdev->dev, 4, | 99 | ret = bgpio_init(&priv->bgc, &pdev->dev, 4, |