aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpiolib.c
diff options
context:
space:
mode:
authorOlliver Schinagl <oliver@schinagl.nl>2015-01-21 16:33:45 -0500
committerLinus Walleij <linus.walleij@linaro.org>2015-01-30 08:43:04 -0500
commit9e089246a53cce0e14f04fb24de0e1bc62ec5400 (patch)
treec4aa8567014cdc23f1b0afa29af4bd88d3f9c423 /drivers/gpio/gpiolib.c
parent161af6cd899508506ac5df101af7e569f28aa0e6 (diff)
gpio: use sizeof() instead of hardcoded values
gpiolib uses a fixed string for the suffixes and defines it at 32 bytes. Later in the code snprintf is used with this fixed value of 32. Using sizeof() is safer in case the size for the suffixes is ever changed. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpiolib.c')
-rw-r--r--drivers/gpio/gpiolib.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index c9266410d84c..bf6016d7a023 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1665,9 +1665,11 @@ static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id,
1665 1665
1666 for (i = 0; i < ARRAY_SIZE(suffixes); i++) { 1666 for (i = 0; i < ARRAY_SIZE(suffixes); i++) {
1667 if (con_id) 1667 if (con_id)
1668 snprintf(prop_name, 32, "%s-%s", con_id, suffixes[i]); 1668 snprintf(prop_name, sizeof(prop_name), "%s-%s", con_id,
1669 suffixes[i]);
1669 else 1670 else
1670 snprintf(prop_name, 32, "%s", suffixes[i]); 1671 snprintf(prop_name, sizeof(prop_name), "%s",
1672 suffixes[i]);
1671 1673
1672 desc = of_get_named_gpiod_flags(dev->of_node, prop_name, idx, 1674 desc = of_get_named_gpiod_flags(dev->of_node, prop_name, idx,
1673 &of_flags); 1675 &of_flags);