diff options
author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2013-08-05 09:10:38 -0400 |
---|---|---|
committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2013-08-19 03:02:05 -0400 |
commit | af53122a2a6239ef235e55cedc324499e31dad87 (patch) | |
tree | fa306710075bf5136d9571b5d0b916fa4014c55f /drivers/firewire/ohci.c | |
parent | 0a41981803fcd4107fff4e943afb72940ba653d2 (diff) |
firewire: ohci: change confusing name of a struct member
We have got
struct descriptor *descriptors;
dma_addr_t descriptors_bus;
dma_addr_t buffer_bus;
struct descriptor buffer[0];
void *misc_buffer;
dma_addr_t misc_buffer_bus;
__be32 *config_rom;
dma_addr_t config_rom_bus;
__be32 *next_config_rom;
dma_addr_t next_config_rom_bus;
But then we have got
__le32 *self_id_cpu;
dma_addr_t self_id_bus;
Better apply the pattern of xyz vs. xyz_bus to self_id vs. self_id_bus
as well. The _cpu suffix looks particularly weird in conversions from
little endian to CPU endian.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/ohci.c')
-rw-r--r-- | drivers/firewire/ohci.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index afb701ec90ca..4dc65679312c 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c | |||
@@ -235,7 +235,7 @@ struct fw_ohci { | |||
235 | dma_addr_t next_config_rom_bus; | 235 | dma_addr_t next_config_rom_bus; |
236 | __be32 next_header; | 236 | __be32 next_header; |
237 | 237 | ||
238 | __le32 *self_id_cpu; | 238 | __le32 *self_id; |
239 | dma_addr_t self_id_bus; | 239 | dma_addr_t self_id_bus; |
240 | struct work_struct bus_reset_work; | 240 | struct work_struct bus_reset_work; |
241 | 241 | ||
@@ -1929,12 +1929,12 @@ static void bus_reset_work(struct work_struct *work) | |||
1929 | return; | 1929 | return; |
1930 | } | 1930 | } |
1931 | 1931 | ||
1932 | generation = (cond_le32_to_cpu(ohci->self_id_cpu[0]) >> 16) & 0xff; | 1932 | generation = (cond_le32_to_cpu(ohci->self_id[0]) >> 16) & 0xff; |
1933 | rmb(); | 1933 | rmb(); |
1934 | 1934 | ||
1935 | for (i = 1, j = 0; j < self_id_count; i += 2, j++) { | 1935 | for (i = 1, j = 0; j < self_id_count; i += 2, j++) { |
1936 | u32 id = cond_le32_to_cpu(ohci->self_id_cpu[i]); | 1936 | u32 id = cond_le32_to_cpu(ohci->self_id[i]); |
1937 | u32 id2 = cond_le32_to_cpu(ohci->self_id_cpu[i + 1]); | 1937 | u32 id2 = cond_le32_to_cpu(ohci->self_id[i + 1]); |
1938 | 1938 | ||
1939 | if (id != ~id2) { | 1939 | if (id != ~id2) { |
1940 | /* | 1940 | /* |
@@ -3692,7 +3692,7 @@ static int pci_probe(struct pci_dev *dev, | |||
3692 | goto fail_contexts; | 3692 | goto fail_contexts; |
3693 | } | 3693 | } |
3694 | 3694 | ||
3695 | ohci->self_id_cpu = ohci->misc_buffer + PAGE_SIZE/2; | 3695 | ohci->self_id = ohci->misc_buffer + PAGE_SIZE/2; |
3696 | ohci->self_id_bus = ohci->misc_buffer_bus + PAGE_SIZE/2; | 3696 | ohci->self_id_bus = ohci->misc_buffer_bus + PAGE_SIZE/2; |
3697 | 3697 | ||
3698 | bus_options = reg_read(ohci, OHCI1394_BusOptions); | 3698 | bus_options = reg_read(ohci, OHCI1394_BusOptions); |