aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/firewire/fw-ohci.c
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2009-02-03 11:55:19 -0500
committerStefan Richter <stefanr@s5r6.in-berlin.de>2009-03-24 15:56:48 -0400
commite1eff7a393d4a4e3ad1cf65fcba899146840bfd2 (patch)
tree88a040babea1853f40072ed199a78b60f4dcb387 /drivers/firewire/fw-ohci.c
parentd01b01787680a1156ff6a554e40baa460bb88efb (diff)
firewire: normalize a variable name
Standardize on if (err) handle_error; and if (ret < 0) handle_error; Don't call a variable err if we store values in it which mean success. Also, offset some return statements by a blank line since this how we do it in drivers/firewire. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/fw-ohci.c')
-rw-r--r--drivers/firewire/fw-ohci.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/firewire/fw-ohci.c b/drivers/firewire/fw-ohci.c
index 859af71b06a8..c92278374658 100644
--- a/drivers/firewire/fw-ohci.c
+++ b/drivers/firewire/fw-ohci.c
@@ -2459,11 +2459,12 @@ static int __devinit pci_probe(struct pci_dev *dev,
2459 reg_read(ohci, OHCI1394_GUIDLo); 2459 reg_read(ohci, OHCI1394_GUIDLo);
2460 2460
2461 err = fw_card_add(&ohci->card, max_receive, link_speed, guid); 2461 err = fw_card_add(&ohci->card, max_receive, link_speed, guid);
2462 if (err < 0) 2462 if (err)
2463 goto fail_self_id; 2463 goto fail_self_id;
2464 2464
2465 fw_notify("Added fw-ohci device %s, OHCI version %x.%x\n", 2465 fw_notify("Added fw-ohci device %s, OHCI version %x.%x\n",
2466 dev_name(&dev->dev), version >> 16, version & 0xff); 2466 dev_name(&dev->dev), version >> 16, version & 0xff);
2467
2467 return 0; 2468 return 0;
2468 2469
2469 fail_self_id: 2470 fail_self_id: