aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/firewire/core-transaction.c
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2010-06-14 19:22:45 -0400
committerStefan Richter <stefanr@s5r6.in-berlin.de>2010-06-19 07:01:41 -0400
commitae86e81e434072be28ff4e9c1be3cc2562be8749 (patch)
treef73b99c0fa7d96cc94e2ae6110bcc9d5855a02f7 /drivers/firewire/core-transaction.c
parent5030c807907ae90ad21e9220c1a9d592558deba2 (diff)
firewire: core: remove unused variable
which caused gcc 4.6 to warn about variable 'destination' set but not used. Since the hardware ensures that we receive only response packets with proper destination node ID (in a given bus generation), we have no use for destination here in the core as well as in upper layers. (This is different with request packets. There we pass destination node ID to upper layers because they may for example need to check whether this was an unicast or broadcast request.) Reported-and-Tested-By: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/core-transaction.c')
-rw-r--r--drivers/firewire/core-transaction.c11
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/firewire/core-transaction.c b/drivers/firewire/core-transaction.c
index 182da69eae44..cb6390fe3686 100644
--- a/drivers/firewire/core-transaction.c
+++ b/drivers/firewire/core-transaction.c
@@ -881,13 +881,12 @@ void fw_core_handle_response(struct fw_card *card, struct fw_packet *p)
881 unsigned long flags; 881 unsigned long flags;
882 u32 *data; 882 u32 *data;
883 size_t data_length; 883 size_t data_length;
884 int tcode, tlabel, destination, source, rcode; 884 int tcode, tlabel, source, rcode;
885 885
886 tcode = HEADER_GET_TCODE(p->header[0]); 886 tcode = HEADER_GET_TCODE(p->header[0]);
887 tlabel = HEADER_GET_TLABEL(p->header[0]); 887 tlabel = HEADER_GET_TLABEL(p->header[0]);
888 destination = HEADER_GET_DESTINATION(p->header[0]); 888 source = HEADER_GET_SOURCE(p->header[1]);
889 source = HEADER_GET_SOURCE(p->header[1]); 889 rcode = HEADER_GET_RCODE(p->header[1]);
890 rcode = HEADER_GET_RCODE(p->header[1]);
891 890
892 spin_lock_irqsave(&card->lock, flags); 891 spin_lock_irqsave(&card->lock, flags);
893 list_for_each_entry(t, &card->transaction_list, link) { 892 list_for_each_entry(t, &card->transaction_list, link) {