aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/extcon
diff options
context:
space:
mode:
authorChanwoo Choi <cw00.choi@samsung.com>2014-08-11 21:15:39 -0400
committerChanwoo Choi <cw00.choi@samsung.com>2014-09-21 22:43:08 -0400
commitfbae30d8dd35454bd4a55445d1bb51c620f8e646 (patch)
tree3088a00419a74d4709d0794685f2ebd45576b848 /drivers/extcon
parentca2a07e45d1d3d31a0a85d2f63d81a897c610040 (diff)
extcon: sm5502: Clean up codes by using checkpatch script
This patch just clean up codes by using checkpatch script and fix warning message about if statement. - the result of checkpatch script as following: WARNING: void function return statements are not generally useful + return; +} WARNING: quoted string split across lines + dev_err(info->dev, "failed: irq request (IRQ: %d," + " error :%d)\n", muic_irq->irq, ret); - warning message about coding style. drivers/extcon/extcon-sm5502.c:398 sm5502_muic_cable_handler() warn: we tested 'attached' before and it was 'false' Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Diffstat (limited to 'drivers/extcon')
-rw-r--r--drivers/extcon/extcon-sm5502.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c
index f94d66aae9e3..8e6e66942d61 100644
--- a/drivers/extcon/extcon-sm5502.c
+++ b/drivers/extcon/extcon-sm5502.c
@@ -391,7 +391,7 @@ static int sm5502_muic_cable_handler(struct sm5502_muic_info *info,
391 /* Get the type of attached or detached cable */ 391 /* Get the type of attached or detached cable */
392 if (attached) 392 if (attached)
393 cable_type = sm5502_muic_get_cable_type(info); 393 cable_type = sm5502_muic_get_cable_type(info);
394 else if (!attached) 394 else
395 cable_type = prev_cable_type; 395 cable_type = prev_cable_type;
396 prev_cable_type = cable_type; 396 prev_cable_type = cable_type;
397 397
@@ -453,8 +453,6 @@ static void sm5502_muic_irq_work(struct work_struct *work)
453 dev_err(info->dev, "failed to handle MUIC interrupt\n"); 453 dev_err(info->dev, "failed to handle MUIC interrupt\n");
454 454
455 mutex_unlock(&info->mutex); 455 mutex_unlock(&info->mutex);
456
457 return;
458} 456}
459 457
460/* 458/*
@@ -613,8 +611,9 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c,
613 IRQF_NO_SUSPEND, 611 IRQF_NO_SUSPEND,
614 muic_irq->name, info); 612 muic_irq->name, info);
615 if (ret) { 613 if (ret) {
616 dev_err(info->dev, "failed: irq request (IRQ: %d," 614 dev_err(info->dev,
617 " error :%d)\n", muic_irq->irq, ret); 615 "failed: irq request (IRQ: %d, error :%d)\n",
616 muic_irq->irq, ret);
618 return ret; 617 return ret;
619 } 618 }
620 } 619 }