diff options
| author | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> | 2014-05-30 08:19:17 -0400 |
|---|---|---|
| committer | Chanwoo Choi <cw00.choi@samsung.com> | 2014-06-16 00:33:19 -0400 |
| commit | 24a279b1cae0af0eb4bf0dd8b3ef85956a96ff7a (patch) | |
| tree | 6dcf3da94e99ecd5029c0773602e25ef88f8a6e2 /drivers/extcon | |
| parent | e368f525218497a9943b61301148d30382c1e014 (diff) | |
extcon: arizona: Update manual headphone detection calculation
The higher levels of impedance have a higher minimum value than the
first level. As the same value was used for all levels, higher impedances
were reported with a very low level of accuracy. This patch applies the
approriate lower threshold for each level, whilst we are changing things
add a define for the maximum value at each level to improve readability.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Diffstat (limited to 'drivers/extcon')
| -rw-r--r-- | drivers/extcon/extcon-arizona.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index c6347965c639..c2eed30cfc3a 100644 --- a/drivers/extcon/extcon-arizona.c +++ b/drivers/extcon/extcon-arizona.c | |||
| @@ -329,14 +329,17 @@ static void arizona_stop_mic(struct arizona_extcon_info *info) | |||
| 329 | } | 329 | } |
| 330 | 330 | ||
| 331 | static struct { | 331 | static struct { |
| 332 | unsigned int threshold; | ||
| 332 | unsigned int factor_a; | 333 | unsigned int factor_a; |
| 333 | unsigned int factor_b; | 334 | unsigned int factor_b; |
| 334 | } arizona_hpdet_b_ranges[] = { | 335 | } arizona_hpdet_b_ranges[] = { |
| 335 | { 5528, 362464 }, | 336 | { 100, 5528, 362464 }, |
| 336 | { 11084, 6186851 }, | 337 | { 169, 11084, 6186851 }, |
| 337 | { 11065, 65460395 }, | 338 | { 169, 11065, 65460395 }, |
| 338 | }; | 339 | }; |
| 339 | 340 | ||
| 341 | #define ARIZONA_HPDET_B_RANGE_MAX 0x3fb | ||
| 342 | |||
| 340 | static struct { | 343 | static struct { |
| 341 | int min; | 344 | int min; |
| 342 | int max; | 345 | int max; |
| @@ -391,7 +394,8 @@ static int arizona_hpdet_read(struct arizona_extcon_info *info) | |||
| 391 | >> ARIZONA_HP_IMPEDANCE_RANGE_SHIFT; | 394 | >> ARIZONA_HP_IMPEDANCE_RANGE_SHIFT; |
| 392 | 395 | ||
| 393 | if (range < ARRAY_SIZE(arizona_hpdet_b_ranges) - 1 && | 396 | if (range < ARRAY_SIZE(arizona_hpdet_b_ranges) - 1 && |
| 394 | (val < 100 || val >= 0x3fb)) { | 397 | (val < arizona_hpdet_b_ranges[range].threshold || |
| 398 | val >= ARIZONA_HPDET_B_RANGE_MAX)) { | ||
| 395 | range++; | 399 | range++; |
| 396 | dev_dbg(arizona->dev, "Moving to HPDET range %d\n", | 400 | dev_dbg(arizona->dev, "Moving to HPDET range %d\n", |
| 397 | range); | 401 | range); |
| @@ -404,7 +408,8 @@ static int arizona_hpdet_read(struct arizona_extcon_info *info) | |||
| 404 | } | 408 | } |
| 405 | 409 | ||
| 406 | /* If we go out of range report top of range */ | 410 | /* If we go out of range report top of range */ |
| 407 | if (val < 100 || val >= 0x3fb) { | 411 | if (val < arizona_hpdet_b_ranges[range].threshold || |
| 412 | val >= ARIZONA_HPDET_B_RANGE_MAX) { | ||
| 408 | dev_dbg(arizona->dev, "Measurement out of range\n"); | 413 | dev_dbg(arizona->dev, "Measurement out of range\n"); |
| 409 | return ARIZONA_HPDET_MAX; | 414 | return ARIZONA_HPDET_MAX; |
| 410 | } | 415 | } |
