diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-08-14 05:11:11 -0400 |
---|---|---|
committer | Vinod Koul <vinod.koul@intel.com> | 2013-08-14 05:21:28 -0400 |
commit | f2d04c32092635256bdad4e868a3590ba94daf00 (patch) | |
tree | e3975dcfa78048679e32d28c8194a669703a1eaa /drivers/dma | |
parent | 6fc4573c4e17eb57f6e1a20992dcf0b6a105afdb (diff) |
dma: mmp: simplify use of devm_ioremap_resource
Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@
- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
e = devm_ioremap_resource(e1, res);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma')
-rw-r--r-- | drivers/dma/mmp_pdma.c | 3 | ||||
-rw-r--r-- | drivers/dma/mmp_tdma.c | 3 |
2 files changed, 0 insertions, 6 deletions
diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index dba9fe9cbbbe..5c4318c5a5b1 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c | |||
@@ -843,9 +843,6 @@ static int mmp_pdma_probe(struct platform_device *op) | |||
843 | spin_lock_init(&pdev->phy_lock); | 843 | spin_lock_init(&pdev->phy_lock); |
844 | 844 | ||
845 | iores = platform_get_resource(op, IORESOURCE_MEM, 0); | 845 | iores = platform_get_resource(op, IORESOURCE_MEM, 0); |
846 | if (!iores) | ||
847 | return -EINVAL; | ||
848 | |||
849 | pdev->base = devm_ioremap_resource(pdev->dev, iores); | 846 | pdev->base = devm_ioremap_resource(pdev->dev, iores); |
850 | if (IS_ERR(pdev->base)) | 847 | if (IS_ERR(pdev->base)) |
851 | return PTR_ERR(pdev->base); | 848 | return PTR_ERR(pdev->base); |
diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c index a9345d0387d8..38cb517fb2eb 100644 --- a/drivers/dma/mmp_tdma.c +++ b/drivers/dma/mmp_tdma.c | |||
@@ -550,9 +550,6 @@ static int mmp_tdma_probe(struct platform_device *pdev) | |||
550 | } | 550 | } |
551 | 551 | ||
552 | iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); | 552 | iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
553 | if (!iores) | ||
554 | return -EINVAL; | ||
555 | |||
556 | tdev->base = devm_ioremap_resource(&pdev->dev, iores); | 553 | tdev->base = devm_ioremap_resource(&pdev->dev, iores); |
557 | if (IS_ERR(tdev->base)) | 554 | if (IS_ERR(tdev->base)) |
558 | return PTR_ERR(tdev->base); | 555 | return PTR_ERR(tdev->base); |