aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/crypto
diff options
context:
space:
mode:
authorDave Jones <davej@redhat.com>2014-02-08 20:59:14 -0500
committerHerbert Xu <herbert@gondor.apana.org.au>2014-02-08 20:59:14 -0500
commit80e84c16e72a0eac30085322b4664b7b6b0dde75 (patch)
tree7f9e360d57d193f64284123f6cf47e8d7f6c62dd /drivers/crypto
parent0a63b09dd6e321d4488347d6283685d08ee4bb7f (diff)
crypto: ccp - Fix ccp_run_passthru_cmd dma variable assignments
There are some suspicious looking lines of code in the new ccp driver, including one that assigns a variable to itself, and another that overwrites a previous assignment. This may have been a cut-and-paste error where 'src' was forgotten to be changed to 'dst'. I have no hardware to test this, so this is untested. Signed-off-by: Dave Jones <davej@fedoraproject.org> Acked-by: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
-rw-r--r--drivers/crypto/ccp/ccp-ops.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
index 71ed3ade7e12..c266a7b154bb 100644
--- a/drivers/crypto/ccp/ccp-ops.c
+++ b/drivers/crypto/ccp/ccp-ops.c
@@ -1666,8 +1666,8 @@ static int ccp_run_passthru_cmd(struct ccp_cmd_queue *cmd_q,
1666 1666
1667 op.dst.type = CCP_MEMTYPE_SYSTEM; 1667 op.dst.type = CCP_MEMTYPE_SYSTEM;
1668 op.dst.u.dma.address = sg_dma_address(dst.sg_wa.sg); 1668 op.dst.u.dma.address = sg_dma_address(dst.sg_wa.sg);
1669 op.src.u.dma.offset = dst.sg_wa.sg_used; 1669 op.dst.u.dma.offset = dst.sg_wa.sg_used;
1670 op.src.u.dma.length = op.src.u.dma.length; 1670 op.dst.u.dma.length = op.src.u.dma.length;
1671 1671
1672 ret = ccp_perform_passthru(&op); 1672 ret = ccp_perform_passthru(&op);
1673 if (ret) { 1673 if (ret) {