aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/crypto/nx
diff options
context:
space:
mode:
authorMonam Agarwal <monamagarwal123@gmail.com>2014-03-23 15:32:42 -0400
committerHerbert Xu <herbert@gondor.apana.org.au>2014-04-16 08:16:46 -0400
commit7ded6e3d1bf5f83786753d1e0556a5c9711ced8a (patch)
treec0d552d7dced0e54dabaa8a74f3eeb1d60d87d88 /drivers/crypto/nx
parent0ea481466d1c7cbd9d8f70ddc17a443a6c6fc09b (diff)
crypto: nx - Use RCU_INIT_POINTER(x, NULL)
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure. And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL) Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto/nx')
-rw-r--r--drivers/crypto/nx/nx-842.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/crypto/nx/nx-842.c b/drivers/crypto/nx/nx-842.c
index 1e5481d88a26..c4fcbf47475f 100644
--- a/drivers/crypto/nx/nx-842.c
+++ b/drivers/crypto/nx/nx-842.c
@@ -1234,7 +1234,7 @@ static int __exit nx842_remove(struct vio_dev *viodev)
1234 old_devdata = rcu_dereference_check(devdata, 1234 old_devdata = rcu_dereference_check(devdata,
1235 lockdep_is_held(&devdata_mutex)); 1235 lockdep_is_held(&devdata_mutex));
1236 of_reconfig_notifier_unregister(&nx842_of_nb); 1236 of_reconfig_notifier_unregister(&nx842_of_nb);
1237 rcu_assign_pointer(devdata, NULL); 1237 RCU_INIT_POINTER(devdata, NULL);
1238 spin_unlock_irqrestore(&devdata_mutex, flags); 1238 spin_unlock_irqrestore(&devdata_mutex, flags);
1239 synchronize_rcu(); 1239 synchronize_rcu();
1240 dev_set_drvdata(&viodev->dev, NULL); 1240 dev_set_drvdata(&viodev->dev, NULL);
@@ -1285,7 +1285,7 @@ static void __exit nx842_exit(void)
1285 spin_lock_irqsave(&devdata_mutex, flags); 1285 spin_lock_irqsave(&devdata_mutex, flags);
1286 old_devdata = rcu_dereference_check(devdata, 1286 old_devdata = rcu_dereference_check(devdata,
1287 lockdep_is_held(&devdata_mutex)); 1287 lockdep_is_held(&devdata_mutex));
1288 rcu_assign_pointer(devdata, NULL); 1288 RCU_INIT_POINTER(devdata, NULL);
1289 spin_unlock_irqrestore(&devdata_mutex, flags); 1289 spin_unlock_irqrestore(&devdata_mutex, flags);
1290 synchronize_rcu(); 1290 synchronize_rcu();
1291 if (old_devdata) 1291 if (old_devdata)