diff options
author | Viresh Kumar <viresh.kumar@linaro.org> | 2013-08-14 10:08:24 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-10-30 19:11:08 -0400 |
commit | d4019f0a92ab802f385cc9c8ad3ab7b5449712cb (patch) | |
tree | ebd06695585e457ae1bf219653452b111e7508db /drivers/cpufreq/sc520_freq.c | |
parent | 7dbf694db6ac7c759599316d50d7050efcbd512a (diff) |
cpufreq: move freq change notifications to cpufreq core
Most of the drivers do following in their ->target_index() routines:
struct cpufreq_freqs freqs;
freqs.old = old freq...
freqs.new = new freq...
cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE);
/* Change rate here */
cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);
This is replicated over all cpufreq drivers today and there doesn't exists a
good enough reason why this shouldn't be moved to cpufreq core instead.
There are few special cases though, like exynos5440, which doesn't do everything
on the call to ->target_index() routine and call some kind of bottom halves for
doing this work, work/tasklet/etc..
They may continue doing notification from their own code as flag:
CPUFREQ_ASYNC_NOTIFICATION is already set for them.
All drivers are also modified in this patch to avoid breaking 'git bisect', as
double notification would happen otherwise.
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Russell King <linux@arm.linux.org.uk>
Acked-by: Stephen Warren <swarren@nvidia.com>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq/sc520_freq.c')
-rw-r--r-- | drivers/cpufreq/sc520_freq.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/drivers/cpufreq/sc520_freq.c b/drivers/cpufreq/sc520_freq.c index 6c86452e1737..6adb354e359c 100644 --- a/drivers/cpufreq/sc520_freq.c +++ b/drivers/cpufreq/sc520_freq.c | |||
@@ -56,17 +56,8 @@ static unsigned int sc520_freq_get_cpu_frequency(unsigned int cpu) | |||
56 | static int sc520_freq_target(struct cpufreq_policy *policy, unsigned int state) | 56 | static int sc520_freq_target(struct cpufreq_policy *policy, unsigned int state) |
57 | { | 57 | { |
58 | 58 | ||
59 | struct cpufreq_freqs freqs; | ||
60 | u8 clockspeed_reg; | 59 | u8 clockspeed_reg; |
61 | 60 | ||
62 | freqs.old = sc520_freq_get_cpu_frequency(0); | ||
63 | freqs.new = sc520_freq_table[state].frequency; | ||
64 | |||
65 | cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE); | ||
66 | |||
67 | pr_debug("attempting to set frequency to %i kHz\n", | ||
68 | sc520_freq_table[state].frequency); | ||
69 | |||
70 | local_irq_disable(); | 61 | local_irq_disable(); |
71 | 62 | ||
72 | clockspeed_reg = *cpuctl & ~0x03; | 63 | clockspeed_reg = *cpuctl & ~0x03; |
@@ -74,8 +65,6 @@ static int sc520_freq_target(struct cpufreq_policy *policy, unsigned int state) | |||
74 | 65 | ||
75 | local_irq_enable(); | 66 | local_irq_enable(); |
76 | 67 | ||
77 | cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE); | ||
78 | |||
79 | return 0; | 68 | return 0; |
80 | } | 69 | } |
81 | 70 | ||